You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/27 15:36:27 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6129: tools:minidumpserver.py support xtensa

xiaoxiang781216 commented on code in PR #6129:
URL: https://github.com/apache/incubator-nuttx/pull/6129#discussion_r859949765


##########
tools/minidumpserver.py:
##########
@@ -261,6 +283,11 @@ def parse(self):
             memory = {"start": start, "end": start + len(data), "data": data}
             self.memories.append(memory)
 
+        # hardcode to handle xtensa A0 register.
+        if self.arch == "xtensa":
+             self.registers[reg_table[self.arch]["A0"]] &= 0x3fffffff

Review Comment:
   let's remove the hack. It isn't enough to just correct one frame pointer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org