You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ismaël Mejía <ie...@gmail.com> on 2017/02/08 14:40:52 UTC
Some questions about the changes in version 0.8
Hello,
I tried to create a new entity (a kafka topic) using the new option in the
Search pane and it shows an error "Something went wrong". Is this already
reported ?
Looking at the request it seems to be an error 500, I tried to reproduce it
with
the JSON and curl but I got always an error, is there any document available
about the API v2 what's improved in particular?
And finally, I noticed that there are new clients for each endpoint in the
atlas-client codebase, is the traditional AtlasClient going to be changed so
that it uses all the new endpoints before the 0.8 release ?
Thanks,
Ismaël Mejía
Re: Some questions about the changes in version 0.8
Posted by Keval Bhatt <ke...@gmail.com>.
Hi Ismael,
Create entity from UI was working, due to Regression it started failing.
since this commit. (
https://github.com/apache/incubator-atlas/commit/d8c2a10e080eb79ba23f646270313089b2afdfda
)
Community is working for PUT and POST Entity V2 API changes once that is
done then we will be able to create and edit entity using UI.
Thanks,
Keval Bhatt.
On Wed, Feb 8, 2017 at 10:36 PM, Jean-Baptiste Onofré <jb...@nanthrax.net>
wrote:
> Hi Ismael
>
> I started a bunch of change in the rest client that I would like to
> propose. All changes should be backward compatible. Not sure it will end in
> 0.8 anyway.
>
> Regards
> JB
>
> On Feb 8, 2017, 10:41, at 10:41, "Ismaël Mejía" <ie...@gmail.com> wrote:
> >Hello,
> >
> >I tried to create a new entity (a kafka topic) using the new option in
> >the
> >Search pane and it shows an error "Something went wrong". Is this
> >already
> >reported ?
> >
> >Looking at the request it seems to be an error 500, I tried to
> >reproduce it
> >with
> >the JSON and curl but I got always an error, is there any document
> >available
> >about the API v2 what's improved in particular?
> >
> >And finally, I noticed that there are new clients for each endpoint in
> >the
> >atlas-client codebase, is the traditional AtlasClient going to be
> >changed so
> >that it uses all the new endpoints before the 0.8 release ?
> >
> >Thanks,
> >Ismaël Mejía
>
--
*From:*
*Keval P. Bhatt*
*Mumbai*
Re: Some questions about the changes in version 0.8
Posted by Apoorv Naik <an...@hortonworks.com>.
I think consolidating the V2 clients into one makes more sense so that the migration path becomes easier and the rewrite is relatively easier.
+1 on creating a migration guide/doc.
On 2/14/17, 1:45 AM, "Ismaël Mejía" <ie...@gmail.com> wrote:
>Thanks everyone for answering,
>
>Having a single endpoint seems to me as a good idea as well as other
>improvements, and I know this project is incubating so breaking changes are
>easier to do at this moment.
>
>@Apporv I don't think that achieving backward compatibility (if not
>complete at least at the most possible) is going to be easy, but if you
>guys achieve this it would be great!.
>
>I just skimmed through the new code and tested our current integration with
>Atlas (that uses the V1 client) and most things break because of the move
>from Referenceable to AtlasEntity as well as other type changes, I
>understand that this is a new API, but have you guys considered documenting
>a migration path (at least for the breaking changes), also I understand
>that API improvements are welcome, but users may expect atlas-client be the
>place to have a more stable API contract and so many changes are going
>there, that I have the impression that basically a full rewrite is needed
>for the users (even if it is a simple rewrite).
>
>Regards,
>Ismaël
>
>On Thu, Feb 9, 2017 at 7:37 PM, Apoorv Naik <an...@hortonworks.com> wrote:
>
>> 1. The V2 APIs have introduced strong typed REST interfaces like
>> TypesREST, EntityREST etc. The main motive is cleanup and providing more
>> clarity on what kind of data is being transmitted over the wire rather that
>> just saying that the resource method will return a JSON (which is implied).
>> 2. Also the V2 APIs aim to reduce the current complexity of the type
>> system (which seem to have a great influence from Scala and the underlying
>> DB)
>> 3. The client code was split into smaller pieces in order to reduce the
>> code in the existing client classes. Lot of refactoring has went in the
>> client code to allow easy extension, a couple of bugs/side-effects (retries
>> more that expected number while testing) from older code were fixed.
>>
>> @Ismael: I think for backward compatibility the AtlasClient (v1) shouldn’t
>> change instead once the V2 APIs undergo rigorous test cycles we should wire
>> ALL the V1 endpoints to talk to the new code.
>> @JB: Can you share what changes/improvements you have in mind ?
>>
>>
>>
>> On 2/8/17, 9:06 AM, "Jean-Baptiste Onofré" <jb...@nanthrax.net> wrote:
>>
>> >Hi Ismael
>> >
>> >I started a bunch of change in the rest client that I would like to
>> propose. All changes should be backward compatible. Not sure it will end in
>> 0.8 anyway.
>> >
>> >Regards
>> >JB
>> >
>> >On Feb 8, 2017, 10:41, at 10:41, "Ismaël Mejía" <ie...@gmail.com>
>> wrote:
>> >>Hello,
>> >>
>> >>I tried to create a new entity (a kafka topic) using the new option in
>> >>the
>> >>Search pane and it shows an error "Something went wrong". Is this
>> >>already
>> >>reported ?
>> >>
>> >>Looking at the request it seems to be an error 500, I tried to
>> >>reproduce it
>> >>with
>> >>the JSON and curl but I got always an error, is there any document
>> >>available
>> >>about the API v2 what's improved in particular?
>> >>
>> >>And finally, I noticed that there are new clients for each endpoint in
>> >>the
>> >>atlas-client codebase, is the traditional AtlasClient going to be
>> >>changed so
>> >>that it uses all the new endpoints before the 0.8 release ?
>> >>
>> >>Thanks,
>> >>Ismaël Mejía
>>
>>
Re: Some questions about the changes in version 0.8
Posted by Ismaël Mejía <ie...@gmail.com>.
Thanks everyone for answering,
Having a single endpoint seems to me as a good idea as well as other
improvements, and I know this project is incubating so breaking changes are
easier to do at this moment.
@Apporv I don't think that achieving backward compatibility (if not
complete at least at the most possible) is going to be easy, but if you
guys achieve this it would be great!.
I just skimmed through the new code and tested our current integration with
Atlas (that uses the V1 client) and most things break because of the move
from Referenceable to AtlasEntity as well as other type changes, I
understand that this is a new API, but have you guys considered documenting
a migration path (at least for the breaking changes), also I understand
that API improvements are welcome, but users may expect atlas-client be the
place to have a more stable API contract and so many changes are going
there, that I have the impression that basically a full rewrite is needed
for the users (even if it is a simple rewrite).
Regards,
Ismaël
On Thu, Feb 9, 2017 at 7:37 PM, Apoorv Naik <an...@hortonworks.com> wrote:
> 1. The V2 APIs have introduced strong typed REST interfaces like
> TypesREST, EntityREST etc. The main motive is cleanup and providing more
> clarity on what kind of data is being transmitted over the wire rather that
> just saying that the resource method will return a JSON (which is implied).
> 2. Also the V2 APIs aim to reduce the current complexity of the type
> system (which seem to have a great influence from Scala and the underlying
> DB)
> 3. The client code was split into smaller pieces in order to reduce the
> code in the existing client classes. Lot of refactoring has went in the
> client code to allow easy extension, a couple of bugs/side-effects (retries
> more that expected number while testing) from older code were fixed.
>
> @Ismael: I think for backward compatibility the AtlasClient (v1) shouldn’t
> change instead once the V2 APIs undergo rigorous test cycles we should wire
> ALL the V1 endpoints to talk to the new code.
> @JB: Can you share what changes/improvements you have in mind ?
>
>
>
> On 2/8/17, 9:06 AM, "Jean-Baptiste Onofré" <jb...@nanthrax.net> wrote:
>
> >Hi Ismael
> >
> >I started a bunch of change in the rest client that I would like to
> propose. All changes should be backward compatible. Not sure it will end in
> 0.8 anyway.
> >
> >Regards
> >JB
> >
> >On Feb 8, 2017, 10:41, at 10:41, "Ismaël Mejía" <ie...@gmail.com>
> wrote:
> >>Hello,
> >>
> >>I tried to create a new entity (a kafka topic) using the new option in
> >>the
> >>Search pane and it shows an error "Something went wrong". Is this
> >>already
> >>reported ?
> >>
> >>Looking at the request it seems to be an error 500, I tried to
> >>reproduce it
> >>with
> >>the JSON and curl but I got always an error, is there any document
> >>available
> >>about the API v2 what's improved in particular?
> >>
> >>And finally, I noticed that there are new clients for each endpoint in
> >>the
> >>atlas-client codebase, is the traditional AtlasClient going to be
> >>changed so
> >>that it uses all the new endpoints before the 0.8 release ?
> >>
> >>Thanks,
> >>Ismaël Mejía
>
>
Re: Some questions about the changes in version 0.8
Posted by Apoorv Naik <an...@hortonworks.com>.
1. The V2 APIs have introduced strong typed REST interfaces like TypesREST, EntityREST etc. The main motive is cleanup and providing more clarity on what kind of data is being transmitted over the wire rather that just saying that the resource method will return a JSON (which is implied).
2. Also the V2 APIs aim to reduce the current complexity of the type system (which seem to have a great influence from Scala and the underlying DB)
3. The client code was split into smaller pieces in order to reduce the code in the existing client classes. Lot of refactoring has went in the client code to allow easy extension, a couple of bugs/side-effects (retries more that expected number while testing) from older code were fixed.
@Ismael: I think for backward compatibility the AtlasClient (v1) shouldn’t change instead once the V2 APIs undergo rigorous test cycles we should wire ALL the V1 endpoints to talk to the new code.
@JB: Can you share what changes/improvements you have in mind ?
On 2/8/17, 9:06 AM, "Jean-Baptiste Onofré" <jb...@nanthrax.net> wrote:
>Hi Ismael
>
>I started a bunch of change in the rest client that I would like to propose. All changes should be backward compatible. Not sure it will end in 0.8 anyway.
>
>Regards
>JB
>
>On Feb 8, 2017, 10:41, at 10:41, "Ismaël Mejía" <ie...@gmail.com> wrote:
>>Hello,
>>
>>I tried to create a new entity (a kafka topic) using the new option in
>>the
>>Search pane and it shows an error "Something went wrong". Is this
>>already
>>reported ?
>>
>>Looking at the request it seems to be an error 500, I tried to
>>reproduce it
>>with
>>the JSON and curl but I got always an error, is there any document
>>available
>>about the API v2 what's improved in particular?
>>
>>And finally, I noticed that there are new clients for each endpoint in
>>the
>>atlas-client codebase, is the traditional AtlasClient going to be
>>changed so
>>that it uses all the new endpoints before the 0.8 release ?
>>
>>Thanks,
>>Ismaël Mejía
Re: Some questions about the changes in version 0.8
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Ismael
I started a bunch of change in the rest client that I would like to propose. All changes should be backward compatible. Not sure it will end in 0.8 anyway.
Regards
JB
On Feb 8, 2017, 10:41, at 10:41, "Ismaël Mejía" <ie...@gmail.com> wrote:
>Hello,
>
>I tried to create a new entity (a kafka topic) using the new option in
>the
>Search pane and it shows an error "Something went wrong". Is this
>already
>reported ?
>
>Looking at the request it seems to be an error 500, I tried to
>reproduce it
>with
>the JSON and curl but I got always an error, is there any document
>available
>about the API v2 what's improved in particular?
>
>And finally, I noticed that there are new clients for each endpoint in
>the
>atlas-client codebase, is the traditional AtlasClient going to be
>changed so
>that it uses all the new endpoints before the 0.8 release ?
>
>Thanks,
>Ismaël Mejía
Re: Some questions about the changes in version 0.8
Posted by David Radley <da...@uk.ibm.com>.
Hi,
I agree - there should be one endpoint Ismaël - this was one of the review
points for the new V2 quickstart. I think we need to update the
documentation to add in the details of the version 2 API itself (currently
the documentation generated by the build has an invalid url),
Thanks , David.
From: Ismaël Mejía <ie...@gmail.com>
To: dev@atlas.incubator.apache.org
Date: 08/02/2017 14:41
Subject: Some questions about the changes in version 0.8
Hello,
I tried to create a new entity (a kafka topic) using the new option in the
Search pane and it shows an error "Something went wrong". Is this already
reported ?
Looking at the request it seems to be an error 500, I tried to reproduce
it
with
the JSON and curl but I got always an error, is there any document
available
about the API v2 what's improved in particular?
And finally, I noticed that there are new clients for each endpoint in the
atlas-client codebase, is the traditional AtlasClient going to be changed
so
that it uses all the new endpoints before the 0.8 release ?
Thanks,
Ismaël Mejía
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU