You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by hulk <hu...@gmail.com> on 2023/09/12 10:39:15 UTC
[DISCUSS] Proposal for donating kvrocks_controller to the Apache Kvrocks project
## Motivation
As you may know, Kvrocks cluster mode doesn't maintain the cluster
topology itself, so it depends on the controller component to manage
its cluster topology data. So RocksLabs[1] invented
kvrocks_controller[2] to make this process easier for users, and it's
open-sourced under Apache 2.0 license for more than 2 years.
Now, we’d like to propose donating it to the Apache Kvrocks project since
Apache provides a solid way to release software and run the community.
## Features
The cluster controller has the following key features:
- Health check and failover
- Cluster operations include creating a cluster and managing its shards/nodes
- Slot migration
- Web UI(work in progress)
It now only supports ETCD as the storage, but we also would like to
support more like Apache Zookeeper, and so on.
Does it sound good for you? Hope to hear your feedback!
[1] https://github.com/RocksLabs/
[2] https://github.com/RocksLabs/kvrocks_controller
--
Best Regards,
- Hulk Lin
Re: [DISCUSS] Proposal for donating kvrocks_controller to the Apache Kvrocks project
Posted by hulk <hu...@gmail.com>.
Hi Twice and Bibin
Thanks for your support! Yes, I will finish IP clearance and ask
mentors(only IPMC members have permission to add this) to help before
calling the formal vote.
On Wed, 13 Sept 2023 at 21:14, Twice <tw...@gmail.com> wrote:
>
> Glad to hear that!
>
> Maybe IP clearance is needed to accept a project for ASF.
>
> You can refer to this donation proposal:
> https://cwiki.apache.org/confluence/display/SKYWALKING/%5BApproved%5DRocketBot+Donation+Proposal
>
> Best wishes,
> Twice
>
> On Wed, Sep 13, 2023 at 11:59 AM Binbin Zhu <bi...@apache.org> wrote:
> >
> > sound good to me.
--
Best Regards,
- Hulk Lin
Re: [DISCUSS] Proposal for donating kvrocks_controller to the Apache Kvrocks project
Posted by Twice <tw...@gmail.com>.
Glad to hear that!
Maybe IP clearance is needed to accept a project for ASF.
You can refer to this donation proposal:
https://cwiki.apache.org/confluence/display/SKYWALKING/%5BApproved%5DRocketBot+Donation+Proposal
Best wishes,
Twice
On Wed, Sep 13, 2023 at 11:59 AM Binbin Zhu <bi...@apache.org> wrote:
>
> sound good to me.
Re: [DISCUSS] Proposal for donating kvrocks_controller to the Apache Kvrocks project
Posted by Binbin Zhu <bi...@apache.org>.
sound good to me.
Re: [DISCUSS] Proposal for donating kvrocks_controller to the Apache Kvrocks project
Posted by hulk <hu...@gmail.com>.
Hi tison,
Got it, many thanks for your help and detailed guidance. That helps a lot
to understand the next steps for me.
On Thu, Sep 21, 2023 at 01:07 tison <wa...@gmail.com> wrote:
> Hi,
>
> I second JB's comments and with hulk's reply the agreements should be fine.
> As for new committers, according to the contribution I think it's OK to
> encourage other contributors to participate in the new repo and we can
> promote them when they show a passion and make a bit more contributions. As
> hulk said, the project is most of his code. I don't identify a good
> candidate for committers according to this project.
>
> I'd like to share with you the process to do the actual IP clearance as I
> did it in the last month for donating pulsar-admin-go:
>
> 1. Check the license of dependencies
> 2. Check IPs, and determine whether iCLAs/CCLAs/SGA are required. I suppose
> we can reuse the CCLA of Kvrocks since they should be in the same
> background.
> 3. Check if any new committers/PMC members should be nominated. (Discussed
> above)
> 4. Mailing list vote in dev@ or private@.
> 5. Make an incubator IP clearance page. You can refer to [1] as an example.
> 6. general@incubator.a.o announcement. You can refer to [2] as an example.
> 7. File an INFRA ticket for repo transfer if needed.
>
> Best,
> tison.
>
> [1] https://incubator.apache.org/ip-clearance/pulsar-admin-go.html
> [2] https://lists.apache.org/thread/85hynjryvr2869v9wtrqb8ym1853vx88
>
>
>
> hulk <hu...@gmail.com> 于2023年9月21日周四 00:49写道：
>
> > Hi JB,
> >
> > Thanks for your support first.
> >
> > > do you have approval from contributors to push code to ASF ?
> >
> > I have asked contributors in GitHub Issues[1] and most of them are
> > good for this(7/8 and one of them didn't respond).
> >
> > > what's your plan aboutthe current contributors ? invite them as
> > committers ?
> >
> > Most of the codes are from me and don't have a plan to invite
> > contributors as committers. Not sure if this sounds good?
> >
> > [1] https://github.com/RocksLabs/kvrocks_controller/issues/94
> >
> > On Thu, 21 Sept 2023 at 00:08, Jean-Baptiste Onofré <jb...@nanthrax.net>
> > wrote:
> > >
> > > Hi,
> > >
> > > I have a question regarding the contributors: what's your plan about
> > > the current contributors ? invite them as committers ? do you have
> > > approval from contributors to push code to ASF ?
> > > Anyway, it looks good to me.
> > >
> > > Thanks !
> > > Regards
> > > JB
> > >
> > > On Thu, Sep 14, 2023 at 2:48 PM Yaroslav Stepanchuk <torwig@apache.org
> >
> > wrote:
> > > >
> > > > Good idea. +1 from me.
> > > >
> > > > On 2023/09/12 10:39:15 hulk wrote:
> > > > > ## Motivation
> > > > >
> > > > > As you may know, Kvrocks cluster mode doesn't maintain the cluster
> > > > > topology itself, so it depends on the controller component to
> manage
> > > > > its cluster topology data. So RocksLabs[1] invented
> > > > > kvrocks_controller[2] to make this process easier for users, and
> it's
> > > > > open-sourced under Apache 2.0 license for more than 2 years.
> > > > >
> > > > > Now, we’d like to propose donating it to the Apache Kvrocks project
> > since
> > > > > Apache provides a solid way to release software and run the
> > community.
> > > > >
> > > > >
> > > > > ## Features
> > > > >
> > > > > The cluster controller has the following key features:
> > > > >
> > > > > - Health check and failover
> > > > > - Cluster operations include creating a cluster and managing its
> > shards/nodes
> > > > > - Slot migration
> > > > > - Web UI(work in progress)
> > > > >
> > > > > It now only supports ETCD as the storage, but we also would like to
> > > > > support more like Apache Zookeeper, and so on.
> > > > >
> > > > > Does it sound good for you? Hope to hear your feedback!
> > > > >
> > > > > [1] https://github.com/RocksLabs/
> > > > > [2] https://github.com/RocksLabs/kvrocks_controller
> > > > >
> > > > > --
> > > > > Best Regards,
> > > > > - Hulk Lin
> > > > >
> >
> >
> >
> > --
> > Best Regards,
> > - Hulk Lin
> >
>
--
Best Regards,
- *Hulk Lin*
Re: [DISCUSS] Proposal for donating kvrocks_controller to the Apache Kvrocks project
Posted by tison <wa...@gmail.com>.
Hi,
I second JB's comments and with hulk's reply the agreements should be fine.
As for new committers, according to the contribution I think it's OK to
encourage other contributors to participate in the new repo and we can
promote them when they show a passion and make a bit more contributions. As
hulk said, the project is most of his code. I don't identify a good
candidate for committers according to this project.
I'd like to share with you the process to do the actual IP clearance as I
did it in the last month for donating pulsar-admin-go:
1. Check the license of dependencies
2. Check IPs, and determine whether iCLAs/CCLAs/SGA are required. I suppose
we can reuse the CCLA of Kvrocks since they should be in the same
background.
3. Check if any new committers/PMC members should be nominated. (Discussed
above)
4. Mailing list vote in dev@ or private@.
5. Make an incubator IP clearance page. You can refer to [1] as an example.
6. general@incubator.a.o announcement. You can refer to [2] as an example.
7. File an INFRA ticket for repo transfer if needed.
Best,
tison.
[1] https://incubator.apache.org/ip-clearance/pulsar-admin-go.html
[2] https://lists.apache.org/thread/85hynjryvr2869v9wtrqb8ym1853vx88
hulk <hu...@gmail.com> 于2023年9月21日周四 00:49写道：
> Hi JB,
>
> Thanks for your support first.
>
> > do you have approval from contributors to push code to ASF ?
>
> I have asked contributors in GitHub Issues[1] and most of them are
> good for this(7/8 and one of them didn't respond).
>
> > what's your plan aboutthe current contributors ? invite them as
> committers ?
>
> Most of the codes are from me and don't have a plan to invite
> contributors as committers. Not sure if this sounds good?
>
> [1] https://github.com/RocksLabs/kvrocks_controller/issues/94
>
> On Thu, 21 Sept 2023 at 00:08, Jean-Baptiste Onofré <jb...@nanthrax.net>
> wrote:
> >
> > Hi,
> >
> > I have a question regarding the contributors: what's your plan about
> > the current contributors ? invite them as committers ? do you have
> > approval from contributors to push code to ASF ?
> > Anyway, it looks good to me.
> >
> > Thanks !
> > Regards
> > JB
> >
> > On Thu, Sep 14, 2023 at 2:48 PM Yaroslav Stepanchuk <to...@apache.org>
> wrote:
> > >
> > > Good idea. +1 from me.
> > >
> > > On 2023/09/12 10:39:15 hulk wrote:
> > > > ## Motivation
> > > >
> > > > As you may know, Kvrocks cluster mode doesn't maintain the cluster
> > > > topology itself, so it depends on the controller component to manage
> > > > its cluster topology data. So RocksLabs[1] invented
> > > > kvrocks_controller[2] to make this process easier for users, and it's
> > > > open-sourced under Apache 2.0 license for more than 2 years.
> > > >
> > > > Now, we’d like to propose donating it to the Apache Kvrocks project
> since
> > > > Apache provides a solid way to release software and run the
> community.
> > > >
> > > >
> > > > ## Features
> > > >
> > > > The cluster controller has the following key features:
> > > >
> > > > - Health check and failover
> > > > - Cluster operations include creating a cluster and managing its
> shards/nodes
> > > > - Slot migration
> > > > - Web UI(work in progress)
> > > >
> > > > It now only supports ETCD as the storage, but we also would like to
> > > > support more like Apache Zookeeper, and so on.
> > > >
> > > > Does it sound good for you? Hope to hear your feedback!
> > > >
> > > > [1] https://github.com/RocksLabs/
> > > > [2] https://github.com/RocksLabs/kvrocks_controller
> > > >
> > > > --
> > > > Best Regards,
> > > > - Hulk Lin
> > > >
>
>
>
> --
> Best Regards,
> - Hulk Lin
>
Re: [DISCUSS] Proposal for donating kvrocks_controller to the Apache Kvrocks project
Posted by hulk <hu...@gmail.com>.
Hi JB,
Thanks for your support first.
> do you have approval from contributors to push code to ASF ?
I have asked contributors in GitHub Issues[1] and most of them are
good for this(7/8 and one of them didn't respond).
> what's your plan aboutthe current contributors ? invite them as committers ?
Most of the codes are from me and don't have a plan to invite
contributors as committers. Not sure if this sounds good?
[1] https://github.com/RocksLabs/kvrocks_controller/issues/94
On Thu, 21 Sept 2023 at 00:08, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
>
> Hi,
>
> I have a question regarding the contributors: what's your plan about
> the current contributors ? invite them as committers ? do you have
> approval from contributors to push code to ASF ?
> Anyway, it looks good to me.
>
> Thanks !
> Regards
> JB
>
> On Thu, Sep 14, 2023 at 2:48 PM Yaroslav Stepanchuk <to...@apache.org> wrote:
> >
> > Good idea. +1 from me.
> >
> > On 2023/09/12 10:39:15 hulk wrote:
> > > ## Motivation
> > >
> > > As you may know, Kvrocks cluster mode doesn't maintain the cluster
> > > topology itself, so it depends on the controller component to manage
> > > its cluster topology data. So RocksLabs[1] invented
> > > kvrocks_controller[2] to make this process easier for users, and it's
> > > open-sourced under Apache 2.0 license for more than 2 years.
> > >
> > > Now, we’d like to propose donating it to the Apache Kvrocks project since
> > > Apache provides a solid way to release software and run the community.
> > >
> > >
> > > ## Features
> > >
> > > The cluster controller has the following key features:
> > >
> > > - Health check and failover
> > > - Cluster operations include creating a cluster and managing its shards/nodes
> > > - Slot migration
> > > - Web UI(work in progress)
> > >
> > > It now only supports ETCD as the storage, but we also would like to
> > > support more like Apache Zookeeper, and so on.
> > >
> > > Does it sound good for you? Hope to hear your feedback!
> > >
> > > [1] https://github.com/RocksLabs/
> > > [2] https://github.com/RocksLabs/kvrocks_controller
> > >
> > > --
> > > Best Regards,
> > > - Hulk Lin
> > >
--
Best Regards,
- Hulk Lin
Re: [DISCUSS] Proposal for donating kvrocks_controller to the Apache Kvrocks project
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi,
I have a question regarding the contributors: what's your plan about
the current contributors ? invite them as committers ? do you have
approval from contributors to push code to ASF ?
Anyway, it looks good to me.
Thanks !
Regards
JB
On Thu, Sep 14, 2023 at 2:48 PM Yaroslav Stepanchuk <to...@apache.org> wrote:
>
> Good idea. +1 from me.
>
> On 2023/09/12 10:39:15 hulk wrote:
> > ## Motivation
> >
> > As you may know, Kvrocks cluster mode doesn't maintain the cluster
> > topology itself, so it depends on the controller component to manage
> > its cluster topology data. So RocksLabs[1] invented
> > kvrocks_controller[2] to make this process easier for users, and it's
> > open-sourced under Apache 2.0 license for more than 2 years.
> >
> > Now, we’d like to propose donating it to the Apache Kvrocks project since
> > Apache provides a solid way to release software and run the community.
> >
> >
> > ## Features
> >
> > The cluster controller has the following key features:
> >
> > - Health check and failover
> > - Cluster operations include creating a cluster and managing its shards/nodes
> > - Slot migration
> > - Web UI(work in progress)
> >
> > It now only supports ETCD as the storage, but we also would like to
> > support more like Apache Zookeeper, and so on.
> >
> > Does it sound good for you? Hope to hear your feedback!
> >
> > [1] https://github.com/RocksLabs/
> > [2] https://github.com/RocksLabs/kvrocks_controller
> >
> > --
> > Best Regards,
> > - Hulk Lin
> >
Re: [DISCUSS] Proposal for donating kvrocks_controller to the Apache Kvrocks project
Posted by Yaroslav Stepanchuk <to...@apache.org>.
Good idea. +1 from me.
On 2023/09/12 10:39:15 hulk wrote:
> ## Motivation
>
> As you may know, Kvrocks cluster mode doesn't maintain the cluster
> topology itself, so it depends on the controller component to manage
> its cluster topology data. So RocksLabs[1] invented
> kvrocks_controller[2] to make this process easier for users, and it's
> open-sourced under Apache 2.0 license for more than 2 years.
>
> Now, we’d like to propose donating it to the Apache Kvrocks project since
> Apache provides a solid way to release software and run the community.
>
>
> ## Features
>
> The cluster controller has the following key features:
>
> - Health check and failover
> - Cluster operations include creating a cluster and managing its shards/nodes
> - Slot migration
> - Web UI(work in progress)
>
> It now only supports ETCD as the storage, but we also would like to
> support more like Apache Zookeeper, and so on.
>
> Does it sound good for you? Hope to hear your feedback!
>
> [1] https://github.com/RocksLabs/
> [2] https://github.com/RocksLabs/kvrocks_controller
>
> --
> Best Regards,
> - Hulk Lin
>