[GitHub] srowen commented on a change in pull request #23868: [SPARK-26966][ML] Update to JPMML 1.4.8

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #23868: [SPARK-26966][ML] Update to JPMML 1.4.8
URL: https://github.com/apache/spark/pull/23868#discussion_r259218374
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/mllib/pmml/export/PMMLModelExportFactory.scala
 ##########
 @@ -44,12 +44,12 @@ private[mllib] object PMMLModelExportFactory {
         new GeneralizedLinearPMMLModelExport(lasso, "lasso regression")
       case svm: SVMModel =>
         new BinaryClassificationPMMLModelExport(
-          svm, "linear SVM", RegressionNormalizationMethodType.NONE,
+          svm, "linear SVM", RegressionModel.NormalizationMethod.NONE,
 
 Review comment:
   I think it's because the two classifiers it supports are logistic regression and SVM. The former makes sense but not so much SVM, but, it looks like only PMML 4.3 established an export format for it: http://dmg.org/pmml/v4-3/SupportVectorMachine.html . But now we're on PMML 4.3 with this change. That's probably worth doing, though my real purpose in this change is to get Java 9+ working. That can be handled separately.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org