[jira] [Commented] (DRILL-5838) Fix MaprDB filter pushdown for the case of nested field (reg. of DRILL-4264)

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191418#comment-16191418 ] 

ASF GitHub Bot commented on DRILL-5838:
---------------------------------------

GitHub user vvysotskyi opened a pull request:

    https://github.com/apache/drill/pull/972

    DRILL-5838: Fix MaprDB filter pushdown for the case of nested field (reg. of DRILL-4264)

    Please see [DRILL-4264|https://issues.apache.org/jira/browse/DRILL-5838] for the problem description.
    
    `FieldPath.asPathString()` returns string in which field names may be quoted if `FieldPath` instance was created from the string, in which these fields were quoted. `SchemaPath.toExpr()` returns string were all field names are quoted.
    
    - Created new method in `SchemaPath` which quotes only field names which contain dots.
    - Fixed existing MaprDB unit tests to handle this case.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vvysotskyi/drill DRILL-5838

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/972.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #972
    
----

----


> Fix MaprDB filter pushdown for the case of nested field (reg. of DRILL-4264)
> ----------------------------------------------------------------------------
>
>                 Key: DRILL-5838
>                 URL: https://issues.apache.org/jira/browse/DRILL-5838
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Storage - MapRDB
>    Affects Versions: 1.11.0
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Volodymyr Vysotskyi
>
> After the changes in DRILL-4264, filter for MaprDB tables operate only with root field name, but {{MaprDBJsonRecordReader}} expects to use condition with full field path. In MaprDB classes compares the results of calling {{org.ojai.FieldPath.asPathString()}} method for the fields from project list and from filter list. 
> So current code works only for cases when compares root fields, but not nested.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)