You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by sh...@apache.org on 2023/02/23 02:24:07 UTC
[kafka] branch trunk updated: MINOR: Adjust logging with ZK log format (#13281)
This is an automated email from the ASF dual-hosted git repository.
showuon pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new ea08d0dd297 MINOR: Adjust logging with ZK log format (#13281)
ea08d0dd297 is described below
commit ea08d0dd29750b0af25c6d8c3cf14f976848eb6f
Author: Nikolay <ni...@apache.org>
AuthorDate: Thu Feb 23 05:23:59 2023 +0300
MINOR: Adjust logging with ZK log format (#13281)
This PR adjust Kafka log format with ZK by printing ZK session id in hex format like ZK do.
Reviewers: Luke Chen <sh...@gmail.com>
---
core/src/main/scala/kafka/zk/KafkaZkClient.scala | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/core/src/main/scala/kafka/zk/KafkaZkClient.scala b/core/src/main/scala/kafka/zk/KafkaZkClient.scala
index f4fbaa116c8..78dda799f17 100644
--- a/core/src/main/scala/kafka/zk/KafkaZkClient.scala
+++ b/core/src/main/scala/kafka/zk/KafkaZkClient.scala
@@ -43,6 +43,7 @@ import org.apache.zookeeper.common.ZKConfig
import org.apache.zookeeper.data.{ACL, Stat}
import org.apache.zookeeper.{CreateMode, KeeperException, OpResult, ZooKeeper}
+import java.lang.{Long => JLong}
import scala.collection.{Map, Seq, mutable}
sealed trait KRaftRegistrationResult
@@ -2176,12 +2177,12 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, isSecure: Boo
// be deleted.
case Code.OK if shouldReCreateEphemeralZNode(ephemeralOwnerId) =>
info(s"Was not possible to create the ephemeral at $path, node already exists and owner " +
- s"'$ephemeralOwnerId' does not match current session '${zooKeeperClient.sessionId}'" +
+ s"'0x${JLong.toHexString(ephemeralOwnerId)}' does not match current session '0x${JLong.toHexString(zooKeeperClient.sessionId)}'" +
s", trying to delete and re-create it with the newest Zookeeper session")
reCreate()
case Code.OK if ephemeralOwnerId != zooKeeperClient.sessionId =>
error(s"Error while creating ephemeral at $path, node already exists and owner " +
- s"'$ephemeralOwnerId' does not match current session '${zooKeeperClient.sessionId}'")
+ s"'0x${JLong.toHexString(ephemeralOwnerId)}' does not match current session '0x${JLong.toHexString(zooKeeperClient.sessionId)}'")
throw KeeperException.create(Code.NODEEXISTS)
case Code.OK =>
getDataResponse.stat