You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/04/25 19:53:11 UTC

Review Request 20720: Collect Isolator::cleanup() before completing container destroy.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20720/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Chi Zhang, Jie Yu, and Vinod Kone.


Bugs: MESOS-1238
    https://issues.apache.org/jira/browse/MESOS-1238


Repository: mesos-git


Description
-------

Ensure MesosContainerizer waits for all isolators to complete cleanup before setting the termination promise. 
+ Container Termination will now fail if cleanup fails rather than silently ignoring it. 
+ Tests can now wait on containers before destroying a containerizer.


Diffs
-----

  src/slave/containerizer/mesos_containerizer.hpp 99c1354366b3fc99f57773aeb3beece6c6544da2 
  src/slave/containerizer/mesos_containerizer.cpp 722f3fe70c1eae3bd8aa425b3407b6823f23c32a 

Diff: https://reviews.apache.org/r/20720/diff/


Testing
-------

make check


Thanks,

Ian Downes


Re: Review Request 20720: Collect Isolator::cleanup() before completing container destroy.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20720/#review41503
-----------------------------------------------------------

Ship it!



src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20720/#comment74953>

    @jie: that would result in two log lines with similar info.



src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20720/#comment74951>

    s/Now all/Now that all/ ?



src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20720/#comment74952>

    s/Wait for all cleanup to complete/Wait for all isolators to cleanup/ ?



src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20720/#comment74954>

    Actually you can kill this because the caller of destroy is likely going to log it.


- Vinod Kone


On April 25, 2014, 5:53 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20720/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 5:53 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1238
>     https://issues.apache.org/jira/browse/MESOS-1238
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Ensure MesosContainerizer waits for all isolators to complete cleanup before setting the termination promise. 
> + Container Termination will now fail if cleanup fails rather than silently ignoring it. 
> + Tests can now wait on containers before destroying a containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos_containerizer.hpp 99c1354366b3fc99f57773aeb3beece6c6544da2 
>   src/slave/containerizer/mesos_containerizer.cpp 722f3fe70c1eae3bd8aa425b3407b6823f23c32a 
> 
> Diff: https://reviews.apache.org/r/20720/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Re: Review Request 20720: Collect Isolator::cleanup() before completing container destroy.

Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20720/
-----------------------------------------------------------

(Updated April 28, 2014, 8:33 p.m.)


Review request for mesos, Ben Mahler, Chi Zhang, Jie Yu, and Vinod Kone.


Changes
-------

Updated some comments and log messages. NNTR.


Bugs: MESOS-1238
    https://issues.apache.org/jira/browse/MESOS-1238


Repository: mesos-git


Description
-------

Ensure MesosContainerizer waits for all isolators to complete cleanup before setting the termination promise. 
+ Container Termination will now fail if cleanup fails rather than silently ignoring it. 
+ Tests can now wait on containers before destroying a containerizer.


Diffs (updated)
-----

  src/slave/containerizer/mesos_containerizer.hpp 99c1354366b3fc99f57773aeb3beece6c6544da2 
  src/slave/containerizer/mesos_containerizer.cpp 27813af2c132e094a26a4aa31929d7aa84ddd969 

Diff: https://reviews.apache.org/r/20720/diff/


Testing
-------

make check


Thanks,

Ian Downes


Re: Review Request 20720: Collect Isolator::cleanup() before completing container destroy.

Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20720/#review41500
-----------------------------------------------------------

Ship it!


- Chi Zhang


On April 25, 2014, 5:53 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20720/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 5:53 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1238
>     https://issues.apache.org/jira/browse/MESOS-1238
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Ensure MesosContainerizer waits for all isolators to complete cleanup before setting the termination promise. 
> + Container Termination will now fail if cleanup fails rather than silently ignoring it. 
> + Tests can now wait on containers before destroying a containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos_containerizer.hpp 99c1354366b3fc99f57773aeb3beece6c6544da2 
>   src/slave/containerizer/mesos_containerizer.cpp 722f3fe70c1eae3bd8aa425b3407b6823f23c32a 
> 
> Diff: https://reviews.apache.org/r/20720/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Re: Review Request 20720: Collect Isolator::cleanup() before completing container destroy.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20720/#review41497
-----------------------------------------------------------

Ship it!



src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20720/#comment74939>

    Can you also add a LOG(ERROR) here as you did in ___destroy?
    
    Also, probably say:
    
    "Failed to kill all processes when destroying container..."



src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20720/#comment74940>

    Probably say:
    
    "Failed to cleanup isolators when destroying container... "



src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20720/#comment74941>

    Ditto above.


- Jie Yu


On April 25, 2014, 5:53 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20720/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 5:53 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1238
>     https://issues.apache.org/jira/browse/MESOS-1238
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Ensure MesosContainerizer waits for all isolators to complete cleanup before setting the termination promise. 
> + Container Termination will now fail if cleanup fails rather than silently ignoring it. 
> + Tests can now wait on containers before destroying a containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos_containerizer.hpp 99c1354366b3fc99f57773aeb3beece6c6544da2 
>   src/slave/containerizer/mesos_containerizer.cpp 722f3fe70c1eae3bd8aa425b3407b6823f23c32a 
> 
> Diff: https://reviews.apache.org/r/20720/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ian Downes
> 
>