You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/08 18:50:49 UTC

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #745: arch/stm32h7: Explicit support for all STM32H7x3xx

davids5 commented on a change in pull request #745: arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r405741075
 
 

 ##########
 File path: arch/arm/include/stm32h7/chip.h
 ##########
 @@ -53,16 +53,40 @@
  *
  *   PART        PACKAGE
  *   ----------- ----------------
+ *   STM32H7x3Ax UFBGA169
 
 Review comment:
   @hartmannathan 
   
   > Where is that addressed?
   
   Grep for STM32H7_NGPIO then look at the F7 and follow the pattern.
   
   For the package with different pin counts we do not want to make something that is not whole appear to be.  Or said another way: A problem found at compile time is much better then one found in the debugger.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services