[jira] [Commented] (CALCITE-4079) Remove the deprecated code from SqlDialect

["Stamatis Zampetakis (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142353#comment-17142353 ] 

Stamatis Zampetakis commented on CALCITE-4079:
----------------------------------------------

If it really causes problems I guess we can remove them now but can you provide a bit more info about how the deadlock occurs. Is this the root cause?

> Remove the deprecated code from SqlDialect
> ------------------------------------------
>
>                 Key: CALCITE-4079
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4079
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.23.0
>            Reporter: TANG Wen-hui
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> {code:java}
> /** @deprecated Use {@link AnsiSqlDialect#DEFAULT} instead. */
> @Deprecated // to be removed before 2.0
> public static final SqlDialect DUMMY =
>     AnsiSqlDialect.DEFAULT;
> /** @deprecated Use {@link CalciteSqlDialect#DEFAULT} instead. */
> @Deprecated // to be removed before 2.0
> public static final SqlDialect CALCITE =
>     CalciteSqlDialect.DEFAULT;{code}
> SqlDialect#DUMMY and SqlDialect#CALCITE are marked deprecated and have not be used in any places.
> It would be better to remove them to avoid class initialization deadlock.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)