[GitHub] [fluo] jkosh44 removed a comment on issue #1083: [WIP] POC for Command module with centralized Command Pattern logic

[GitBox <gi...@apache.org>]

jkosh44 removed a comment on issue #1083: [WIP] POC for Command module with centralized Command Pattern logic
URL: https://github.com/apache/fluo/pull/1083#issuecomment-572221755
 
 
   @keith-turner after last night's change I have no more planned changes for the actual functionality. I do still want to try and add Integration Tests. I'm not sure how I'm going to do that right now or if it's possible so I plan on looking into that next. 
   
   In terms of testing I used uno and stresso to compare running the commands of the previous version to running the commands on my version. There's still probably some edge cases and optional parameters to test but I'm going to do that after integration tests.
   
   So feel free to pull this down and test it yourself. I don't plan on changing any of the main code unless an issue is found.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services