[jira] [Commented] (AIRFLOW-2773) DataFlowPythonOperator does not handle correctly task_id containing underscores

["Apache Spark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601553#comment-16601553 ] 

Apache Spark commented on AIRFLOW-2773:
---------------------------------------

User 'kaxil' has created a pull request for this issue:
https://github.com/apache/incubator-airflow/pull/3623

> DataFlowPythonOperator does not handle correctly task_id containing underscores
> -------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-2773
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2773
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: Dataflow
>    Affects Versions: 1.9.0
>            Reporter: Evgeny Podlepaev
>            Assignee: Kaxil Naik
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> DataFlowPythonOperator generates a job name that does not get accepted by Dataflow API when task_id contains underscores. Example: DataFlowPythonOperator(task_id='analyze_search_results', ...)
> will lead to the following error:
> ValueError: Pipeline has validations errors: Invalid job_name (analyze_search_results-02e17268); the name must consist of only the characters [-a-z0-9], starting with a letter and ending with a letter or number.
> The fix seems to be as simple as changing DataFlowHook.start_python_dataflow() to do
> name = task_id.replace('_', '-')



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)