You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2021/07/06 22:32:52 UTC

[Bug 65438] New: mod_privileges.c / vhost_group not checking cfg->gid as intended

https://bz.apache.org/bugzilla/show_bug.cgi?id=65438

            Bug ID: 65438
           Summary: mod_privileges.c / vhost_group not checking cfg->gid
                    as intended
           Product: Apache httpd-2
           Version: 2.4.48
          Hardware: All
                OS: Mac OS X 10.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: mod_privileges
          Assignee: bugs@httpd.apache.org
          Reporter: salgernon@me.com
  Target Milestone: ---

This is terribly trivial, but the check should be against the newly assigned
cfg->gid rather than cfg->uid.

*** ./modules/arch/unix/mod_privileges.c.orig   2021-07-06 15:30:54.000000000
-0700
--- ./modules/arch/unix/mod_privileges.c        2021-07-06 15:31:05.000000000
-0700
***************
*** 432,438 ****
      priv_cfg *cfg = ap_get_module_config(cmd->server->module_config,
                                           &privileges_module);
      cfg->gid = ap_gname2id(arg);
!     if (cfg->uid == 0) {
          return apr_pstrcat(cmd->pool, "Invalid groupid for VHostGroup: ",
                             arg, NULL);
      }
--- 432,438 ----
      priv_cfg *cfg = ap_get_module_config(cmd->server->module_config,
                                           &privileges_module);
      cfg->gid = ap_gname2id(arg);
!     if (cfg->gid == 0) {
          return apr_pstrcat(cmd->pool, "Invalid groupid for VHostGroup: ",
                             arg, NULL);
      }

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org