You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/02 14:43:36 UTC

[GitHub] [incubator-nuttx] jlaitine commented on a change in pull request #1165: STM32H7 Spi corrections

jlaitine commented on a change in pull request #1165:
URL: https://github.com/apache/incubator-nuttx/pull/1165#discussion_r433931473



##########
File path: arch/arm/src/stm32h7/stm32_spi.c
##########
@@ -2114,6 +2109,11 @@ static void spi_exchange(FAR struct spi_dev_s *dev, FAR const void *txbuffer,
        *    bits in the SPI_CFG1 register, if DMA Tx and/or DMA Rx are used.
        */
 
+      /* TX transmission must be completed before shuttind down the SPI */

Review comment:
       I sure can, but why squash? Isn't it nicer to have separate changes as separate commits?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org