You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/01/03 20:48:35 UTC

[PR] HDDS-10000. Improve LeakDetector [ozone]

adoroszlai opened a new pull request, #5916:
URL: https://github.com/apache/ozone/pull/5916

   ## What changes were proposed in this pull request?
   
    * Let `LeakTracker` implement `UncheckedAutoCloseable` and change methods that return it to use the interface.  Tracked objects should not call other methods exposed due to `LeakTracker extends WeakReference`.
    * Distinguish detectors with the same name by appending a unique integer.
    * Split two test cases in `TestLeakDetector`.
   
   https://issues.apache.org/jira/browse/HDDS-10000
   
   ## How was this patch tested?
   
   CI:
   https://github.com/adoroszlai/ozone/actions/runs/7401596618


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-10000. Improve LeakDetector [ozone]

Posted by "duongkame (via GitHub)" <gi...@apache.org>.
duongkame commented on code in PR #5916:
URL: https://github.com/apache/ozone/pull/5916#discussion_r1442113294


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/LeakDetector.java:
##########
@@ -18,13 +18,15 @@
  */
 package org.apache.hadoop.hdds.utils;
 
+import org.apache.ratis.util.UncheckedAutoCloseable;

Review Comment:
   I don't love that Ozone depends on ratis for such a basic need. I guess it's ok for this PR as it's a general issue in Ozone.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-10000. Improve LeakDetector [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5916:
URL: https://github.com/apache/ozone/pull/5916#issuecomment-1877693065

   Thanks @duongkame for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-10000. Improve LeakDetector [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5916:
URL: https://github.com/apache/ozone/pull/5916


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-10000. Improve LeakDetector [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #5916:
URL: https://github.com/apache/ozone/pull/5916#discussion_r1442117175


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/LeakDetector.java:
##########
@@ -18,13 +18,15 @@
  */
 package org.apache.hadoop.hdds.utils;
 
+import org.apache.ratis.util.UncheckedAutoCloseable;

Review Comment:
   For now I think of Ratis as a library that provides Raft-implementation as well as useful utilities used by both Ratis and Ozone.  The problem is that we don't have a top-level "utilities" Apache (or Apache-licensed other) project.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org