You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by martinschaef <gi...@git.apache.org> on 2014/11/04 23:09:27 UTC

[GitHub] maven pull request: removed possible NullPointerException

GitHub user martinschaef opened a pull request:

    https://github.com/apache/maven/pull/30

    removed possible NullPointerException

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/martinschaef/maven master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #30
    
----
commit e5861f6ae12faad65df424371ebc077e1c4d1a41
Author: Martin <ma...@gmail.com>
Date:   2014-11-04T21:41:53Z

    Update MetadataResolutionResult.java

commit dad097c991f08e0bafc9b1d50d467dff657d8ce9
Author: Martin <ma...@gmail.com>
Date:   2014-11-04T22:08:43Z

    Update MetadataResolutionResult.java

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: removed possible NullPointerException

Posted by martinschaef <gi...@git.apache.org>.
Github user martinschaef commented on the pull request:

    https://github.com/apache/maven/pull/30#issuecomment-62033548
  
    http://jira.codehaus.org/browse/MNG-5721


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: removed possible NullPointerException

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:

    https://github.com/apache/maven/pull/30#issuecomment-61775255
  
    Can you squash the commits?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: removed possible NullPointerException

Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on a diff in the pull request:

    https://github.com/apache/maven/pull/30#discussion_r19860234
  
    --- Diff: maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionResult.java ---
    @@ -234,11 +234,10 @@ public MetadataResolutionResult addError( Exception e )
         {
             if ( exceptions == null )
             {
    -            initList( exceptions );
    +            exceptions = initList( exceptions );
             }
    -
             exceptions.add( e );
    -
    +        
             return this;
    --- End diff --
    
    Please remove that whitespace


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: removed possible NullPointerException

Posted by martinschaef <gi...@git.apache.org>.
Github user martinschaef closed the pull request at:

    https://github.com/apache/maven/pull/30


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [GitHub] maven pull request: removed possible NullPointerException

Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi Martin,

just register on xcircles..

see here:

http://maven.apache.org/issue-tracking.html


Kind regards
Karl Heinz Marbaise
On 11/5/14 5:01 PM, martinschaef wrote:
> Github user martinschaef commented on the pull request:
>
>      https://github.com/apache/maven/pull/30#issuecomment-61830233
>
>      Sorry, I don't have a JIRA account. Could you guys do that? I'm only testing my static analysis tool and already created dozens of JIRA accounts for other projects where my tool found bugs ;)
>      I revised the code again according to the way initList is used elsewhere in the class - only the last commit is important.
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] maven pull request: removed possible NullPointerException

Posted by martinschaef <gi...@git.apache.org>.
Github user martinschaef commented on the pull request:

    https://github.com/apache/maven/pull/30#issuecomment-61830233
  
    Sorry, I don't have a JIRA account. Could you guys do that? I'm only testing my static analysis tool and already created dozens of JIRA accounts for other projects where my tool found bugs ;) 
    I revised the code again according to the way initList is used elsewhere in the class - only the last commit is important.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org