You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by jvwing <gi...@git.apache.org> on 2017/01/23 17:01:46 UTC
[GitHub] nifi pull request #1439: NIFI-3382 New test keystore, truststore (0.x branch...
GitHub user jvwing opened a pull request:
https://github.com/apache/nifi/pull/1439
NIFI-3382 New test keystore, truststore (0.x branch)
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
----
This PR is for the 0.x branch only. I generated new keystore `localhost-ks.jks` and truststore `localhost-ts.jks` to match the previous ones through the following incantation:
```
keytool -genkeypair -alias localhost -keyalg RSA -storepass localtest -keypass localtest -keystore localhost-ks.jks -dname "CN=localhost, OU=Apache NiFi, O=Apache, L=Santa Monica, ST=CA, C=US" -startdate "2017/01/05" -validity 10000 -noprompt
keytool -genkeypair -alias mykey -keyalg DSA -storepass localtest -keypass localtest -keystore localhost-ks.jks -dname "CN=localhost, OU=Testing, O=Research, L=Metropolis, ST=New York, C=US" -startdate "2017/01/05" -validity 10000 -noprompt
keytool -exportcert -rfc -alias localhost -keystore localhost-ks.jks -storepass localtest -file localhost_cert.pem
keytool -importcert -v -trustcacerts -alias localhost -file localhost_cert.pem -keystore localhost-ts.jks -storepass localtest -noprompt
keytool -exportcert -rfc -alias mykey -keystore localhost-ks.jks -storepass localtest -file mykey_cert.pem
keytool -importcert -v -trustcacerts -alias mykey -file mykey_cert.pem -keystore localhost-ts.jks -storepass localtest -noprompt
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jvwing/nifi NIFI-3382-web-api-test-certs-0x-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1439.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1439
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1439: NIFI-3382 New test keystore, truststore (0.x branch...
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing closed the pull request at:
https://github.com/apache/nifi/pull/1439
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1439: NIFI-3382 New test keystore, truststore (0.x branch)
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1439
Thanks for performing these tasks @jvwing . I merged to master and closed the Jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1439: NIFI-3382 New test keystore, truststore (0.x branch)
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1439
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1439: NIFI-3382 New test keystore, truststore (0.x branch)
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1439
Thank you, @alopresto.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1439: NIFI-3382 New test keystore, truststore (0.x branch)
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1439
@jvwing can you please close this PR? Only `master` PRs automatically close via merge. Thanks.
And obviously I mistyped above when I said I merged to master, but rather correctly merged to `0.x`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1439: NIFI-3382 New test keystore, truststore (0.x branch)
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1439
No problem, I'll close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---