You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Igor Galić <i....@brainsware.org> on 2011/12/03 20:12:25 UTC

Re: svn commit: r1209947 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.h


----- Original Message -----
> Author: minfrin
> Date: Sat Dec  3 16:45:29 2011
> New Revision: 1209947
> 
> URL: http://svn.apache.org/viewvc?rev=1209947&view=rev
> Log:
> mod_proxy: Move ap_proxy_strmatch_path and ap_proxy_strmatch_domain
> out of
> the public API.
> 
> Modified:
>     httpd/httpd/trunk/modules/proxy/mod_proxy.h
>     httpd/httpd/trunk/modules/proxy/proxy_util.h
> 
> Modified: httpd/httpd/trunk/modules/proxy/mod_proxy.h
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy.h?rev=1209947&r1=1209946&r2=1209947&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/proxy/mod_proxy.h (original)
> +++ httpd/httpd/trunk/modules/proxy/mod_proxy.h Sat Dec  3 16:45:29
> 2011
> @@ -886,12 +886,7 @@ PROXY_DECLARE(int) ap_proxy_trans_match(
>   */
>  int ap_proxy_lb_workers(void);
>  
> -/* For proxy_util */
>  extern module PROXY_DECLARE_DATA proxy_module;
>  
> -extern int PROXY_DECLARE_DATA proxy_lb_workers;

Was this an accident?
It's not mentioned in the log and the name doesn't sound
like it's got much to do with the functions below.

> -extern const apr_strmatch_pattern PROXY_DECLARE_DATA
> *ap_proxy_strmatch_path;
> -extern const apr_strmatch_pattern PROXY_DECLARE_DATA
> *ap_proxy_strmatch_domain;
> -
>  #endif /*MOD_PROXY_H*/
>  /** @} */
> 
> Modified: httpd/httpd/trunk/modules/proxy/proxy_util.h
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/proxy_util.h?rev=1209947&r1=1209946&r2=1209947&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/proxy/proxy_util.h (original)
> +++ httpd/httpd/trunk/modules/proxy/proxy_util.h Sat Dec  3 16:45:29
> 2011
> @@ -31,6 +31,10 @@ PROXY_DECLARE(int) ap_proxy_is_domainnam
>  PROXY_DECLARE(int) ap_proxy_is_hostname(struct dirconn_entry *This,
>  apr_pool_t *p);
>  PROXY_DECLARE(int) ap_proxy_is_word(struct dirconn_entry *This,
>  apr_pool_t *p);
>  
> +extern int PROXY_DECLARE_DATA proxy_lb_workers;
> +extern const apr_strmatch_pattern PROXY_DECLARE_DATA
> *ap_proxy_strmatch_path;
> +extern const apr_strmatch_pattern PROXY_DECLARE_DATA
> *ap_proxy_strmatch_domain;
> +
>  /**
>   * Register optional functions declared within proxy_util.c.
>   */
> 
> 
> 

-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE


Re: svn commit: r1209947 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.h

Posted by Graham Leggett <mi...@sharp.fm>.
On 03 Dec 2011, at 9:12 PM, Igor Galić wrote:

>> -/* For proxy_util */
>> extern module PROXY_DECLARE_DATA proxy_module;
>> 
>> -extern int PROXY_DECLARE_DATA proxy_lb_workers;
> 
> Was this an accident?
> It's not mentioned in the log and the name doesn't sound
> like it's got much to do with the functions below.

It was on purpose, but accidentally left off the commit message. It's only used by proxy_util.c.

Regards,
Graham
--