You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by ni...@apache.org on 2010/04/27 05:17:30 UTC
svn commit: r938308 - in /camel/trunk/components/camel-cxf/src:
main/java/org/apache/camel/component/cxf/
main/java/org/apache/camel/component/cxf/feature/
main/java/org/apache/camel/component/cxf/jaxrs/
test/java/org/apache/camel/component/cxf/ test/j...
Author: ningjiang
Date: Tue Apr 27 03:17:30 2010
New Revision: 938308
URL: http://svn.apache.org/viewvc?rev=938308&view=rev
Log:
Clean up the @SuppressWarnings in camel-cxf
Modified:
camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/DefaultCxfBinding.java
camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/feature/AbstractDataFormatFeature.java
camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/feature/PayLoadDataFormatFeature.java
camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsComponent.java
camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsProducer.java
camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfConsumerPayloadTest.java
camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfProducerContextTest.java
camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/soap/headers/CxfMessageHeadersRelayTest.java
camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/wsdl_first/PersonProcessor.java
Modified: camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/DefaultCxfBinding.java
URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/DefaultCxfBinding.java?rev=938308&r1=938307&r2=938308&view=diff
==============================================================================
--- camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/DefaultCxfBinding.java (original)
+++ camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/DefaultCxfBinding.java Tue Apr 27 03:17:30 2010
@@ -398,6 +398,7 @@ public class DefaultCxfBinding implement
* @param camelMessage
* @param exchange provides context for filtering
*/
+ @SuppressWarnings("unchecked")
protected void propagateHeadersFromCxfToCamel(Message cxfMessage,
org.apache.camel.Message camelMessage, Exchange exchange) {
@@ -433,6 +434,7 @@ public class DefaultCxfBinding implement
}
}
+ @SuppressWarnings("unchecked")
protected void propagateHeadersFromCamelToCxf(Exchange camelExchange,
Map<String, Object> camelHeaders,
org.apache.cxf.message.Exchange cxfExchange,
@@ -498,6 +500,7 @@ public class DefaultCxfBinding implement
}
}
+ @SuppressWarnings("unchecked")
protected static Object getContentFromCxf(Message message, DataFormat dataFormat) {
Set<Class<?>> contentFormats = message.getContentFormats();
Object answer = null;
Modified: camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/feature/AbstractDataFormatFeature.java
URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/feature/AbstractDataFormatFeature.java?rev=938308&r1=938307&r2=938308&view=diff
==============================================================================
--- camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/feature/AbstractDataFormatFeature.java (original)
+++ camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/feature/AbstractDataFormatFeature.java Tue Apr 27 03:17:30 2010
@@ -31,8 +31,7 @@ import org.apache.cxf.phase.PhaseInterce
public abstract class AbstractDataFormatFeature extends AbstractFeature {
protected abstract Logger getLogger();
-
- @SuppressWarnings("unchecked")
+
protected void removeInterceptorWhichIsInThePhases(List<Interceptor> interceptors, String[] phaseNames) {
for (Interceptor i : interceptors) {
if (i instanceof PhaseInterceptor) {
@@ -48,7 +47,6 @@ public abstract class AbstractDataFormat
}
}
- @SuppressWarnings("unchecked")
protected void removeInterceptorWhichIsOutThePhases(List<Interceptor> interceptors, String[] phaseNames) {
for (Interceptor i : interceptors) {
boolean outside = false;
@@ -69,7 +67,6 @@ public abstract class AbstractDataFormat
}
- @SuppressWarnings("rawtypes")
protected void removeInterceptors(List<Interceptor> interceptors,
Collection<Class> toBeRemovedInterceptors) {
for (Interceptor interceptor : interceptors) {
Modified: camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/feature/PayLoadDataFormatFeature.java
URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/feature/PayLoadDataFormatFeature.java?rev=938308&r1=938307&r2=938308&view=diff
==============================================================================
--- camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/feature/PayLoadDataFormatFeature.java (original)
+++ camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/feature/PayLoadDataFormatFeature.java Tue Apr 27 03:17:30 2010
@@ -35,7 +35,6 @@ import org.apache.cxf.phase.Phase;
* This feature just setting up the CXF endpoint interceptor for handling the
* Message in PAYLOAD data format
*/
-@SuppressWarnings("rawtypes")
public class PayLoadDataFormatFeature extends AbstractDataFormatFeature {
private static final Logger LOG = LogUtils.getL7dLogger(PayLoadDataFormatFeature.class);
// filter the unused phase
Modified: camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsComponent.java
URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsComponent.java?rev=938308&r1=938307&r2=938308&view=diff
==============================================================================
--- camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsComponent.java (original)
+++ camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsComponent.java Tue Apr 27 03:17:30 2010
@@ -40,7 +40,6 @@ public class CxfRsComponent extends Head
super(context);
}
- @SuppressWarnings("unchecked")
@Override
protected Endpoint createEndpoint(String uri, String remaining, Map<String, Object> parameters) throws Exception {
CxfRsEndpoint answer = null;
Modified: camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsProducer.java
URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsProducer.java?rev=938308&r1=938307&r2=938308&view=diff
==============================================================================
--- camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsProducer.java (original)
+++ camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsProducer.java Tue Apr 27 03:17:30 2010
@@ -173,7 +173,6 @@ public class CxfRsProducer extends Defau
}
}
- @SuppressWarnings("unchecked")
private Method findRightMethod(List<Class<?>> resourceClasses, String methodName, Class[] parameterTypes) throws NoSuchMethodException {
Method answer = null;
for (Class<?> clazz : resourceClasses) {
Modified: camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfConsumerPayloadTest.java
URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfConsumerPayloadTest.java?rev=938308&r1=938307&r2=938308&view=diff
==============================================================================
--- camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfConsumerPayloadTest.java (original)
+++ camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfConsumerPayloadTest.java Tue Apr 27 03:17:30 2010
@@ -42,6 +42,7 @@ public class CxfConsumerPayloadTest exte
return new RouteBuilder() {
public void configure() {
from(SIMPLE_ENDPOINT_URI + "&dataFormat=PAYLOAD").to("log:info").process(new Processor() {
+ @SuppressWarnings("unchecked")
public void process(final Exchange exchange) throws Exception {
CxfPayload<SoapHeader> requestPayload = exchange.getIn().getBody(CxfPayload.class);
List<Element> inElements = requestPayload.getBody();
Modified: camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfProducerContextTest.java
URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfProducerContextTest.java?rev=938308&r1=938307&r2=938308&view=diff
==============================================================================
--- camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfProducerContextTest.java (original)
+++ camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfProducerContextTest.java Tue Apr 27 03:17:30 2010
@@ -38,6 +38,7 @@ public class CxfProducerContextTest exte
private static final String TEST_KEY = "sendSimpleMessage-test";
private static final String TEST_VALUE = "exchange property value should get passed through request context";
+ @SuppressWarnings("unchecked")
@Test
public void testExchangePropertyPropagation() throws Exception {
Exchange exchange = sendSimpleMessage();
Modified: camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/soap/headers/CxfMessageHeadersRelayTest.java
URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/soap/headers/CxfMessageHeadersRelayTest.java?rev=938308&r1=938307&r2=938308&view=diff
==============================================================================
--- camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/soap/headers/CxfMessageHeadersRelayTest.java (original)
+++ camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/soap/headers/CxfMessageHeadersRelayTest.java Tue Apr 27 03:17:30 2010
@@ -305,7 +305,7 @@ public class CxfMessageHeadersRelayTest
try {
response = proxy.inHeader(me, Constants.IN_HEADER_DATA);
} catch (Exception e) {
- int i = 0;
+ // do nothing
}
assertTrue("Expected in in band header *not* to propagate but it did",
response.getResponseType().equals("pass"));
@@ -325,7 +325,7 @@ public class CxfMessageHeadersRelayTest
try {
proxy.outHeader(me, result, header);
} catch (Exception e) {
- int i = 0;
+ // do nothing
}
assertTrue("Ultimate remote HeaderTester.outHeader() destination was not reached",
result.value.getResponseType().equals("pass"));
@@ -345,7 +345,7 @@ public class CxfMessageHeadersRelayTest
try {
result = proxy.inoutHeader(me, header);
} catch (Exception e) {
- int i = 0;
+ // do nothing
}
assertTrue("Expected in band out header *not* to propagate but it did",
result.getResponseType().equals("pass"));
@@ -613,7 +613,6 @@ public class CxfMessageHeadersRelayTest
assertTrue("HeaderHolder list expected to conain 2 object received " + oobHdr.size(),
oobHdr.size() == 2);
- int i = 0;
if (oobHdr != null & oobHdr instanceof List) {
Iterator iter = oobHdr.iterator();
while (iter.hasNext()) {
@@ -654,6 +653,7 @@ public class CxfMessageHeadersRelayTest
public static class InsertRequestOutHeaderProcessor implements Processor {
+ @SuppressWarnings("unchecked")
public void process(Exchange exchange) throws Exception {
List<SoapHeader> soapHeaders = (List)exchange.getIn().getHeader(Header.HEADER_LIST);
@@ -678,6 +678,7 @@ public class CxfMessageHeadersRelayTest
public static class InsertResponseOutHeaderProcessor implements Processor {
+ @SuppressWarnings("unchecked")
public void process(Exchange exchange) throws Exception {
List<SoapHeader> soapHeaders = (List)exchange.getIn().getHeader(Header.HEADER_LIST);
Modified: camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/wsdl_first/PersonProcessor.java
URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/wsdl_first/PersonProcessor.java?rev=938308&r1=938307&r2=938308&view=diff
==============================================================================
--- camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/wsdl_first/PersonProcessor.java (original)
+++ camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/wsdl_first/PersonProcessor.java Tue Apr 27 03:17:30 2010
@@ -30,6 +30,7 @@ public class PersonProcessor implements
private static final transient Log LOG = LogFactory.getLog(PersonProcessor.class);
+ @SuppressWarnings("unchecked")
public void process(Exchange exchange) throws Exception {
LOG.info("processing exchange in camel");