You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by de...@apache.org on 2017/09/17 12:29:33 UTC
[myfaces-trinidad] 05/07: TRINIDAD-2141 add a new 'browser-generic'
agent applied patch #JIRA2141 - 10032011.patch this removes the code that
creates the genericDekstop agent for the 'offline' output mode. thanks to
Pavitra Subramaniam
This is an automated email from the ASF dual-hosted git repository.
deki pushed a commit to branch jwaldman-offline-mode-branch
in repository https://gitbox.apache.org/repos/asf/myfaces-trinidad.git
commit abff115176bbe9384c14b8aa6d8b45bd31a1dd45
Author: Jeanne Waldman <jw...@apache.org>
AuthorDate: Mon Oct 3 19:57:25 2011 +0000
TRINIDAD-2141 add a new 'browser-generic' agent
applied patch #JIRA2141 - 10032011.patch
this removes the code that creates the genericDekstop agent for the 'offline' output mode.
thanks to Pavitra Subramaniam
---
.../trinidadinternal/agent/AgentFactoryImpl.java | 30 +---------------------
1 file changed, 1 insertion(+), 29 deletions(-)
diff --git a/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/agent/AgentFactoryImpl.java b/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/agent/AgentFactoryImpl.java
index 6295abb..a79542f 100644
--- a/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/agent/AgentFactoryImpl.java
+++ b/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/agent/AgentFactoryImpl.java
@@ -24,7 +24,6 @@ import java.util.Map;
import javax.faces.context.FacesContext;
import org.apache.myfaces.trinidad.context.Agent;
-import org.apache.myfaces.trinidad.context.RequestContext;
import org.apache.myfaces.trinidad.logging.TrinidadLogger;
import org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.XhtmlConstants;
@@ -84,7 +83,6 @@ public class AgentFactoryImpl implements AgentFactory
{
Map<String, String> requestParamMap = facesContext.getExternalContext().getRequestParameterMap();
isEmail = requestParamMap.get(_EMAIL_PARAM);
- outputMode = requestParamMap.get(_OUTPUTMODE_PARAM);
}
if ("true".equals(isEmail))
@@ -92,16 +90,7 @@ public class AgentFactoryImpl implements AgentFactory
_populateEmailAgentImpl(agent);
return;
}
-
- RequestContext reqContext = RequestContext.getCurrentInstance();
- if ((reqContext != null &&
- RequestContext.OutputMode.OFFLINE.id().equals(reqContext.getOutputMode())) ||
- RequestContext.OutputMode.OFFLINE.id().equals(outputMode))
- {
- _populateGenericDesktopAgentImpl(agent);
- return;
- }
-
+
if ((userAgent != null) && userAgent.startsWith("PTG"))
{
_populateIaswAgentImpl(userAgent,
@@ -679,21 +668,6 @@ public class AgentFactoryImpl implements AgentFactory
agentObj.setType(Agent.TYPE_PHONE);
}
- /**
- * Returns an AgentEntry for a generic desktop agent
- */
- private void _populateGenericDesktopAgentImpl(AgentImpl agent)
- {
- // Generic Desktop agent
- agent.setType(Agent.TYPE_DESKTOP);
-
- agent.setAgent(Agent.AGENT_GENERIC_DESKTOP);
- agent.setAgentVersion("0.0"); // we don't know the version
- agent.setPlatform(Agent.PLATFORM_UNKNOWN);
- agent.setPlatformVersion(Agent.PLATFORM_VERSION_UNKNOWN);
- agent.setMakeModel(Agent.MAKE_MODEL_UNKNOWN);
- }
-
/**
* Returns an AgentEntry for the browsers that use the Gecko Layout Engine.
@@ -1109,8 +1083,6 @@ public class AgentFactoryImpl implements AgentFactory
}
static private final String _EMAIL_PARAM =
"org.apache.myfaces.trinidad.agent.email";
- static private final String _OUTPUTMODE_PARAM =
- "org.apache.myfaces.trinidad.outputMode";
static final private String _IASW_DEVICE_HINT_PARAM = "X-Oracle-Device.Class";
static final private TrinidadLogger _LOG = TrinidadLogger.createTrinidadLogger(AgentFactoryImpl.class);
--
To stop receiving notification emails like this one, please contact
"commits@myfaces.apache.org" <co...@myfaces.apache.org>.