You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/12 13:07:48 UTC
[GitHub] [arrow] mqy opened a new pull request #9176: ARROW-11222: [Rust] [Arrow] Catch up with flatbuffers 0.8.1 which had some UB problems fixed
mqy opened a new pull request #9176:
URL: https://github.com/apache/arrow/pull/9176
The major change of [flatbuffers 0.8.1](https://docs.rs/flatbuffers/0.8.1/flatbuffers/index.html) since 0.8.0 is [This PR](https://github.com/google/flatbuffers/pull/6393), which fixed some possible memory alignment issues.
In this PR, the ipc/gen/*.rs files are generated by `regen.sh`, without and manual change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9176: ARROW-11222: [Rust] [Arrow] Catch up with flatbuffers 0.8.1 which had some UB problems fixed
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9176:
URL: https://github.com/apache/arrow/pull/9176#issuecomment-759442287
I suggest we hold off merging this PR until the Arrow 3.0 release is completed (happening in the next day or two) to minimize the chance we break something right before the release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9176: ARROW-11222: [Rust] Catch up with flatbuffers 0.8.1 which had some UB problems fixed
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9176:
URL: https://github.com/apache/arrow/pull/9176
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mqy commented on pull request #9176: ARROW-11222: [Rust] [Arrow] Catch up with flatbuffers 0.8.1 which had some UB problems fixed
Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9176:
URL: https://github.com/apache/arrow/pull/9176#issuecomment-760669800
> I suggest we hold off merging this PR until the Arrow 3.0 release is completed (happening in the next day or two) to minimize the chance we break something right before the release
@alamb thanks for the review! Since there are no direct evidence that this PR can fix something in arrow, it's OK to me to hold off merging this PR.
BTW, I've exploring the cause of `test_struct` test failure for several days, filed several issues, but can't figure out the exact reason. The latest issue is filed and commented at https://issues.apache.org/jira/projects/ARROW/issues/ARROW-11239. It looks like `ArrayRef::slice()` is not bug-free. I suggest you evaluate this problem seriously before the 3.0 release.
CC @jorgecarleitao I'm glad if you can take time for this possible problem at this weekend, as you said :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mqy commented on pull request #9176: ARROW-11222: [Rust] [Arrow] Catch up with flatbuffers 0.8.1 which had some UB problems fixed
Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9176:
URL: https://github.com/apache/arrow/pull/9176#issuecomment-758693375
The crate `flatbuffers` is not pinned to `0.8.1`, so let's run `cargo update` to pull it locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mqy edited a comment on pull request #9176: ARROW-11222: [Rust] [Arrow] Catch up with flatbuffers 0.8.1 which had some UB problems fixed
Posted by GitBox <gi...@apache.org>.
mqy edited a comment on pull request #9176:
URL: https://github.com/apache/arrow/pull/9176#issuecomment-760669800
> I suggest we hold off merging this PR until the Arrow 3.0 release is completed (happening in the next day or two) to minimize the chance we break something right before the release
@alamb thanks for the review! Since there is no direct evidence that this PR can fix something in arrow, it's OK to me to hold off merging this PR.
BTW, I've exploring the cause of `test_struct` test failure for several days, filed several issues, but can't figure out the exact reason. The latest issue is filed and commented at https://issues.apache.org/jira/projects/ARROW/issues/ARROW-11239. It looks like `ArrayRef::slice()` is not bug-free. I suggest you evaluate this problem seriously before the 3.0 release.
CC @jorgecarleitao I'm glad if you can take time for this possible problem at this weekend, as you said :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9176: ARROW-11222: [Rust] Catch up with flatbuffers 0.8.1 which had some UB problems fixed
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9176:
URL: https://github.com/apache/arrow/pull/9176#issuecomment-763140489
I merged this branch (locally) to master and re-ran the tests to verify things still work. Everything still looks good, so merging it in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9176: ARROW-11222: [Rust] Catch up with flatbuffers 0.8.1 which had some UB problems fixed
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9176:
URL: https://github.com/apache/arrow/pull/9176#issuecomment-761773226
I apologize for the delay in merging Rust PRs -- the 3.0 release is being finalized now and are planning to minimize entropy by postponing merging changes not critical for the release until the process was complete. I hope the process is complete in the next few days. There is more [discussion](https://lists.apache.org/list.html?dev@arrow.apache.org) in the mailing list
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mqy commented on pull request #9176: ARROW-11222: [Rust] Catch up with flatbuffers 0.8.1 which had some UB problems fixed
Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9176:
URL: https://github.com/apache/arrow/pull/9176#issuecomment-761778034
> I apologize for the delay in merging Rust PRs
@alamb I understand the common releasing process that freezes pushing/merging unless for those fully tested or fatal bug fix, this is really important. You are welcome, no need to apologize at all 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9176: ARROW-11222: [Rust] [Arrow] Catch up with flatbuffers 0.8.1 which had some UB problems fixed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9176:
URL: https://github.com/apache/arrow/pull/9176#issuecomment-758644069
https://issues.apache.org/jira/browse/ARROW-11222
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org