You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2012/05/31 21:12:23 UTC
svn commit: r1344869 - /subversion/trunk/subversion/libsvn_repos/dump.c
Author: stsp
Date: Thu May 31 19:12:23 2012
New Revision: 1344869
URL: http://svn.apache.org/viewvc?rev=1344869&view=rev
Log:
* subversion/libsvn_repos/dump.c
(close_directory): Explain in a comment why entries are sorted lexically,
rather than as paths.
Suggested by: julianfoad
Modified:
subversion/trunk/subversion/libsvn_repos/dump.c
Modified: subversion/trunk/subversion/libsvn_repos/dump.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/dump.c?rev=1344869&r1=1344868&r2=1344869&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_repos/dump.c (original)
+++ subversion/trunk/subversion/libsvn_repos/dump.c Thu May 31 19:12:23 2012
@@ -739,6 +739,10 @@ close_directory(void *dir_baton,
unsigned int i;
apr_array_header_t *sorted_entries;
+ /* Sort entries lexically instead of as paths. Even though the entries
+ * are full paths they're all in the same directory (see comment in struct
+ * dir_baton definition). So we really want to sort by basename, in which
+ * case the lexical sort function is more efficient. */
sorted_entries = svn_sort__hash(db->deleted_entries,
svn_sort_compare_items_lexically, pool);
for (i = 0; i < sorted_entries->nelts; i++)