You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/03/12 15:40:09 UTC
[GitHub] [airflow] potiuk opened a new pull request, #30054: Update scripts to make our pgbouncer-related scripts multiplatform
potiuk opened a new pull request, #30054:
URL: https://github.com/apache/airflow/pull/30054
The images were traditionally amd-only and they are used by the Helm Chart, however this means that if someone uses the chart on ARM, they have an emulated performance (16x slower or so).
This change switches our scripts to use the buildx and qemu (by default installed with Docker Desktop) to build and push multiplatform images.
Fixes: #29967
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #30054: Update scripts to make our pgbouncer-related scripts multiplatform
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #30054:
URL: https://github.com/apache/airflow/pull/30054#discussion_r1137798001
##########
chart/newsfragments/30054.improvement.rst:
##########
@@ -0,0 +1 @@
+The pgbouncer and pgbouncer-images are now based on newer software and os versions. Thye also have native AMD64 and ARM64 support (previously only AMD had native support)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #30054: Update scripts to make our pgbouncer-related scripts multiplatform
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #30054:
URL: https://github.com/apache/airflow/pull/30054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #30054: Update scripts to make our pgbouncer-related scripts multiplatform
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #30054:
URL: https://github.com/apache/airflow/pull/30054#discussion_r1134584981
##########
chart/newsfragments/30054.improvement.rst:
##########
@@ -0,0 +1 @@
+The pgbouncer and pgbouncer-images are now based on newer software and os versions. Thye also have native AMD64 and ARM64 support (previously only AMD had native support)
Review Comment:
```suggestion
The pgbouncer and pgbouncer-images are now based on newer software and os versions. They also have native AMD64 and ARM64 support (previously only AMD had native support).
```
It might be worth doing a significant entry, so we can more easily list out what each one updated to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org