You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/07 01:21:04 UTC

[GitHub] [kafka] d-t-w opened a new pull request, #12260: MINOR: add note on IDEMPOTENT_WRITE ACL to 3.2.0 notable changes

d-t-w opened a new pull request, #12260:
URL: https://github.com/apache/kafka/pull/12260

   Update 3.2.0 notable changes documentation to include a subsection on requiring IDEMPOTENT_WRITE permission when producing messages with default/idempotent configuration and broker version lower than 2.8.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] ijuma commented on a diff in pull request #12260: MINOR: add note on IDEMPOTENT_WRITE ACL to 3.2.0 notable changes

Posted by GitBox <gi...@apache.org>.
ijuma commented on code in PR #12260:
URL: https://github.com/apache/kafka/pull/12260#discussion_r944939422


##########
docs/upgrade.html:
##########
@@ -67,6 +67,9 @@ <h5><a id="upgrade_320_notable" href="#upgrade_320_notable">Notable changes in 3
             which meant that idempotence remained disabled unless the user had explicitly set <code>enable.idempotence</code> to true
             (See <a href="https://issues.apache.org/jira/browse/KAFKA-13598">KAFKA-13598</a>for more details).
             This issue was fixed and the default is properly applied in 3.0.1, 3.1.1, and 3.2.0.</li>
+        <ul>
+            <li>When the broker version is lower than 2.8.0, and the client version is 3.0.1, 3.1.1, and later, the IDEMPOTENT_WRITE permission is required to produce data</li>

Review Comment:
   Sorry, I was unclear here. I clarified in https://github.com/apache/kafka/pull/12260#issuecomment-1213588315



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] ijuma commented on pull request #12260: MINOR: add note on IDEMPOTENT_WRITE ACL to 3.2.0 notable changes

Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #12260:
URL: https://github.com/apache/kafka/pull/12260#issuecomment-1213588315

   @d-t-w I tweaked it a bit. Does this look OK to you? Basically, I wanted to include this note in the main bullet point regarding the change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] ijuma commented on a diff in pull request #12260: MINOR: add note on IDEMPOTENT_WRITE ACL to 3.2.0 notable changes

Posted by GitBox <gi...@apache.org>.
ijuma commented on code in PR #12260:
URL: https://github.com/apache/kafka/pull/12260#discussion_r891237342


##########
docs/upgrade.html:
##########
@@ -67,6 +67,9 @@ <h5><a id="upgrade_320_notable" href="#upgrade_320_notable">Notable changes in 3
             which meant that idempotence remained disabled unless the user had explicitly set <code>enable.idempotence</code> to true
             (See <a href="https://issues.apache.org/jira/browse/KAFKA-13598">KAFKA-13598</a>for more details).
             This issue was fixed and the default is properly applied in 3.0.1, 3.1.1, and 3.2.0.</li>
+        <ul>
+            <li>When the broker version is lower than 2.8.0, and the client version is 3.0.1, 3.1.1, and later, the IDEMPOTENT_WRITE permission is required to produce data</li>

Review Comment:
   I would say something like: Please read the relevant KIP section for the compatibility implications - a noteworthy item worth highlighting is...
   
   Also, we should use the same approach for this and other lines. It's unclear to me why we added a `ul` here, but not in the other case. I'd probably include this paragraph in the previous <li>



##########
docs/upgrade.html:
##########
@@ -67,6 +67,9 @@ <h5><a id="upgrade_320_notable" href="#upgrade_320_notable">Notable changes in 3
             which meant that idempotence remained disabled unless the user had explicitly set <code>enable.idempotence</code> to true
             (See <a href="https://issues.apache.org/jira/browse/KAFKA-13598">KAFKA-13598</a>for more details).
             This issue was fixed and the default is properly applied in 3.0.1, 3.1.1, and 3.2.0.</li>
+        <ul>
+            <li>When the broker version is lower than 2.8.0, and the client version is 3.0.1, 3.1.1, and later, the IDEMPOTENT_WRITE permission is required to produce data</li>

Review Comment:
   I would say something like: Please read the relevant KIP section for the compatibility implications - a noteworthy item worth highlighting is...
   
   Also, we should use the same approach for this and other lines. It's unclear to me why we added a `ul` here, but not in the other case. I'd probably include this paragraph in the previous `li`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] d-t-w commented on pull request #12260: MINOR: add note on IDEMPOTENT_WRITE ACL to 3.2.0 notable changes

Posted by GitBox <gi...@apache.org>.
d-t-w commented on PR #12260:
URL: https://github.com/apache/kafka/pull/12260#issuecomment-1213596640

   Hi @ijuma yes it looks good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] d-t-w commented on pull request #12260: MINOR: add note on IDEMPOTENT_WRITE ACL to 3.2.0 notable changes

Posted by GitBox <gi...@apache.org>.
d-t-w commented on PR #12260:
URL: https://github.com/apache/kafka/pull/12260#issuecomment-1149320749

   Hi @ijuma I rm'd the `ul` tag.
   
   That format was originally requested in the comments here: https://issues.apache.org/jira/browse/KAFKA-13598
   
   More info here: https://kpow.io/articles/kafka-producer-breaking-change/
   
   I'm not sure including this line in the previous `li` is a good idea that mixes this note into the context of a statement about Connect, this breaking change impacts any user of Kafka where:
   
   1. The Kafka Cluster has brokers running version < 2.8.0, and
   2. The Kafka Cluster has ACLs configured, but not IDEMPOTENT_WRITE, and
   3. Producer configuration is default, or capable of being defaulted to idempotent
   4. The producing application is using Kafka-Clients version > 3.2.0
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] ijuma merged pull request #12260: MINOR: add note on IDEMPOTENT_WRITE ACL to 3.2.0 notable changes

Posted by GitBox <gi...@apache.org>.
ijuma merged PR #12260:
URL: https://github.com/apache/kafka/pull/12260


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] ijuma commented on pull request #12260: MINOR: add note on IDEMPOTENT_WRITE ACL to 3.2.0 notable changes

Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #12260:
URL: https://github.com/apache/kafka/pull/12260#issuecomment-1213640348

   Merged to trunk, 3.3, 3.2, 3.1 and 3.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] d-t-w commented on pull request #12260: MINOR: add note on IDEMPOTENT_WRITE ACL to 3.2.0 notable changes

Posted by GitBox <gi...@apache.org>.
d-t-w commented on PR #12260:
URL: https://github.com/apache/kafka/pull/12260#issuecomment-1148497056

   Thanks @showuon I have updated per your comment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org