You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/09/22 14:02:17 UTC

[GitHub] [doris] jackwener opened a new pull request, #12890: [fix](Nereids): fix Outer LAsscom and improve onConditon checker

jackwener opened a new pull request, #12890:
URL: https://github.com/apache/doris/pull/12890

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   - fix Outer LAsscom, current forgot to check onCondtion for Outer LAsscom
   - improve onConditon checker.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [x] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [x] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [x] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [x] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [x] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jackwener commented on pull request #12890: [feature](Nereids): support Alias join reorder and fix bug.

Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #12890:
URL: https://github.com/apache/doris/pull/12890#issuecomment-1259171597

   TODO feature: we can separete `Alias project` and `project` to different Rule to reduce time cost


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #12890: [feature](Nereids): support Alias join reorder and fix bug.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12890:
URL: https://github.com/apache/doris/pull/12890#issuecomment-1263370411

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morrySnow commented on a diff in pull request #12890: [feature](Nereids): support Alias join reorder and fix bug.

Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #12890:
URL: https://github.com/apache/doris/pull/12890#discussion_r983213345


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/InnerJoinLAsscom.java:
##########
@@ -40,19 +52,72 @@ public class InnerJoinLAsscom extends OneExplorationRuleFactory {
     @Override
     public Rule build() {
         return innerLogicalJoin(innerLogicalJoin(), group())
-                .when(topJoin -> check(topJoin, topJoin.left()))
+                .when(topJoin -> checkReorder(topJoin, topJoin.left()))
                 .then(topJoin -> {
-                    JoinLAsscomHelper helper = new JoinLAsscomHelper(topJoin, topJoin.left());
-                    if (!helper.initJoinOnCondition()) {
+                    LogicalJoin<GroupPlan, GroupPlan> bottomJoin = topJoin.left();
+                    Preconditions.checkState(!topJoin.getOtherJoinCondition().isPresent());
+                    Preconditions.checkState(!bottomJoin.getOtherJoinCondition().isPresent());

Review Comment:
   use when to avoid this situation and add a TODO



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/InnerJoinLAsscomProject.java:
##########
@@ -39,14 +62,141 @@ public class InnerJoinLAsscomProject extends OneExplorationRuleFactory {
     @Override
     public Rule build() {
         return innerLogicalJoin(logicalProject(innerLogicalJoin()), group())
-                .when(topJoin -> InnerJoinLAsscom.check(topJoin, topJoin.left().child()))
+                .when(topJoin -> InnerJoinLAsscom.checkReorder(topJoin, topJoin.left().child()))
                 .then(topJoin -> {
-                    JoinLAsscomHelper helper = new JoinLAsscomHelper(topJoin, topJoin.left().child());
-                    helper.initProject(topJoin.left());
-                    if (!helper.initJoinOnCondition()) {
+
+                    /* ********** init ********** */
+                    List<NamedExpression> projects = topJoin.left().getProjects();
+                    LogicalJoin<GroupPlan, GroupPlan> bottomJoin = topJoin.left().child();
+                    Preconditions.checkState(!topJoin.getOtherJoinCondition().isPresent());

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #12890: [feature](Nereids): support Alias join reorder and fix bug.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12890:
URL: https://github.com/apache/doris/pull/12890#issuecomment-1263370455

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jackwener merged pull request #12890: [feature](Nereids): support Alias join reorder and fix bug.

Posted by GitBox <gi...@apache.org>.
jackwener merged PR #12890:
URL: https://github.com/apache/doris/pull/12890


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org