You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by jo...@apache.org on 2016/04/28 19:50:27 UTC
spark git commit: [SPARK-14935][CORE] DistributedSuite "local-cluster
format" shouldn't actually launch clusters
Repository: spark
Updated Branches:
refs/heads/master bed0b0020 -> 5743352a2
[SPARK-14935][CORE] DistributedSuite "local-cluster format" shouldn't actually launch clusters
https://issues.apache.org/jira/browse/SPARK-14935
In DistributedSuite, the "local-cluster format" test actually launches a bunch of clusters, but this doesn't seem necessary for what should just be a unit test of a regex. We should clean up the code so that this is testable without actually launching a cluster, which should buy us about 20 seconds per build.
Passed unit test on my local machine
Author: Xin Ren <ia...@126.com>
Closes #12744 from keypointt/SPARK-14935.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/5743352a
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/5743352a
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/5743352a
Branch: refs/heads/master
Commit: 5743352a28fffbfbaca2201208ce7a1d7893f813
Parents: bed0b00
Author: Xin Ren <ia...@126.com>
Authored: Thu Apr 28 10:49:58 2016 -0700
Committer: Josh Rosen <jo...@databricks.com>
Committed: Thu Apr 28 10:50:06 2016 -0700
----------------------------------------------------------------------
.../org/apache/spark/DistributedSuite.scala | 27 +++++++++++---------
1 file changed, 15 insertions(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/5743352a/core/src/test/scala/org/apache/spark/DistributedSuite.scala
----------------------------------------------------------------------
diff --git a/core/src/test/scala/org/apache/spark/DistributedSuite.scala b/core/src/test/scala/org/apache/spark/DistributedSuite.scala
index 2110d3d..a0086e1 100644
--- a/core/src/test/scala/org/apache/spark/DistributedSuite.scala
+++ b/core/src/test/scala/org/apache/spark/DistributedSuite.scala
@@ -51,18 +51,21 @@ class DistributedSuite extends SparkFunSuite with Matchers with LocalSparkContex
}
test("local-cluster format") {
- sc = new SparkContext("local-cluster[2,1,1024]", "test")
- assert(sc.parallelize(1 to 2, 2).count() == 2)
- resetSparkContext()
- sc = new SparkContext("local-cluster[2 , 1 , 1024]", "test")
- assert(sc.parallelize(1 to 2, 2).count() == 2)
- resetSparkContext()
- sc = new SparkContext("local-cluster[2, 1, 1024]", "test")
- assert(sc.parallelize(1 to 2, 2).count() == 2)
- resetSparkContext()
- sc = new SparkContext("local-cluster[ 2, 1, 1024 ]", "test")
- assert(sc.parallelize(1 to 2, 2).count() == 2)
- resetSparkContext()
+ import SparkMasterRegex._
+
+ val masterStrings = Seq(
+ "local-cluster[2,1,1024]",
+ "local-cluster[2 , 1 , 1024]",
+ "local-cluster[2, 1, 1024]",
+ "local-cluster[ 2, 1, 1024 ]"
+ )
+
+ masterStrings.foreach {
+ case LOCAL_CLUSTER_REGEX(numSlaves, coresPerSlave, memoryPerSlave) =>
+ assert(numSlaves.toInt == 2)
+ assert(coresPerSlave.toInt == 1)
+ assert(memoryPerSlave.toInt == 1024)
+ }
}
test("simple groupByKey") {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org