You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/02 20:23:10 UTC

[GitHub] [arrow] kou commented on a diff in pull request #13299: ARROW-16722: [CI][C++] Fix Minio failures specifying the Minio version to use

kou commented on code in PR #13299:
URL: https://github.com/apache/arrow/pull/13299#discussion_r888382083


##########
ci/scripts/install_minio.sh:
##########
@@ -51,15 +51,21 @@ fi
 arch=${archs[$arch]}
 platform=${platforms[$platform]}
 
+# Use specific versions for minio server and client to avoid CI failures on new releases.
+minio_version="minio.RELEASE.2022-05-26T05-48-41Z"
+mc_version="mc.RELEASE.2022-05-09T04-08-26Z"
+
 if [[ ! -x ${prefix}/bin/minio ]]; then
-  url="https://dl.min.io/server/minio/release/${platform}-${arch}/minio"
+  url="https://dl.min.io/server/minio/release/${platform}-${arch}/archive/${minio_version}"
   echo "Fetching ${url}..."
   wget -nv -P ${prefix}/bin ${url}
+  mv ${prefix}/bin/${minio_version} ${prefix}/bin/minio

Review Comment:
   ```suggestion
     wget -nv --output-document ${prefix}/bin/minio ${url}
   ```



##########
ci/scripts/install_minio.sh:
##########
@@ -51,15 +51,21 @@ fi
 arch=${archs[$arch]}
 platform=${platforms[$platform]}
 
+# Use specific versions for minio server and client to avoid CI failures on new releases.
+minio_version="minio.RELEASE.2022-05-26T05-48-41Z"
+mc_version="mc.RELEASE.2022-05-09T04-08-26Z"
+
 if [[ ! -x ${prefix}/bin/minio ]]; then
-  url="https://dl.min.io/server/minio/release/${platform}-${arch}/minio"
+  url="https://dl.min.io/server/minio/release/${platform}-${arch}/archive/${minio_version}"
   echo "Fetching ${url}..."
   wget -nv -P ${prefix}/bin ${url}
+  mv ${prefix}/bin/${minio_version} ${prefix}/bin/minio
   chmod +x ${prefix}/bin/minio
 fi
 if [[ ! -x ${prefix}/bin/mc ]]; then
-  url="https://dl.min.io/client/mc/release/${platform}-${arch}/mc"
+  url="https://dl.min.io/client/mc/release/${platform}-${arch}/archive/${mc_version}"
   echo "Fetching ${url}..."
   wget -nv -P ${prefix}/bin ${url}
+  mv ${prefix}/bin/${mc_version} ${prefix}/bin/mc

Review Comment:
   ```suggestion
     wget -nv --output-document ${prefix}/bin/mc ${url}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org