You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-dev@hadoop.apache.org by "Philippe Gassmann (JIRA)" <ji...@apache.org> on 2007/02/23 14:55:05 UTC

[jira] Commented: (HADOOP-1034) RuntimeException and Error not catched in DataNode.DataXceiver.run()

    [ https://issues.apache.org/jira/browse/HADOOP-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475341 ] 

Philippe Gassmann commented on HADOOP-1034:
-------------------------------------------

More generally, in a bunch of hadoop code, only IOException are caught. (eg: same issue on DataNode.DataXceiveServer.run())

I think a little cleanup is needed, especially while catching an exception in a run() of a Thread...

> RuntimeException and Error not catched in DataNode.DataXceiver.run()
> --------------------------------------------------------------------
>
>                 Key: HADOOP-1034
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1034
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Philippe Gassmann
>             Fix For: 0.10.1, 0.11.0, 0.11.1, 0.11.2, 0.12.0
>
>         Attachments: patch-catch-throwable
>
>
> Only IOException is catched and logged (in warn). 
> Every Throwable should be logged in error.
> Eg: a RuntimeException occurs in the writeBlock() method. The exception will not be logged, but simply ignored. The socket is closed silently and nothing and an non understandable exception will be thrown in the DFSClient sending the block....

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.