You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/22 01:55:11 UTC
[GitHub] [doris] englefly commented on a diff in pull request #11043: [feature] (Nereids) Merge memo group recursively
englefly commented on code in PR #11043:
URL: https://github.com/apache/doris/pull/11043#discussion_r927225634
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java:
##########
@@ -188,19 +189,24 @@ private void mergeGroup(Group source, Group destination) {
children.set(i, destination);
}
}
- if (groupExpressions.containsKey(groupExpression)) {
- // TODO: need to merge group recursively
- groupExpression.getOwnerGroup().removeGroupExpression(groupExpression);
+ GroupExpression that = groupExpressions.get(groupExpression);
+ if (that != null) {
+ mergeGroup(groupExpression.getOwnerGroup(), that.getOwnerGroup());
} else {
groupExpressions.put(groupExpression, groupExpression);
}
}
- for (GroupExpression groupExpression : source.getLogicalExpressions()) {
- source.removeGroupExpression(groupExpression);
+
+ Iterator<GroupExpression> iterator = source.getLogicalExpressions().iterator();
+ while (iterator.hasNext()) {
+ GroupExpression groupExpression = iterator.next();
+ iterator.remove();
destination.addGroupExpression(groupExpression);
}
- for (GroupExpression groupExpression : source.getPhysicalExpressions()) {
- source.removeGroupExpression(groupExpression);
+ iterator = source.getPhysicalExpressions().iterator();
Review Comment:
add two API in Group
public void moveLogicalExpressionOwnership(Group target);
public void movePhysicalExpressionOwnership(Group target);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org