You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "nytai (via GitHub)" <gi...@apache.org> on 2023/03/16 00:58:18 UTC
[GitHub] [superset] nytai opened a new pull request, #23388: fix: update default WEBDRIVER_OPTION_ARGS
nytai opened a new pull request, #23388:
URL: https://github.com/apache/superset/pull/23388
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This default arg doesn't work with newer versions of the geckodriver. We should remove it so alerts/report/thumbnails work out of the box
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23388: fix: update default WEBDRIVER_OPTION_ARGS
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23388:
URL: https://github.com/apache/superset/pull/23388#issuecomment-1471128925
## [Codecov](https://codecov.io/gh/apache/superset/pull/23388?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23388](https://codecov.io/gh/apache/superset/pull/23388?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e50d340) into [master](https://codecov.io/gh/apache/superset/commit/da3791ad3daa209631a588394600d1a8b635e814?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (da3791a) will **increase** coverage by `9.52%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head e50d340 differs from pull request most recent head 4e3aa42. Consider uploading reports for the commit 4e3aa42 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23388 +/- ##
==========================================
+ Coverage 56.27% 65.79% +9.52%
==========================================
Files 1907 1907
Lines 73495 73495
Branches 7977 7977
==========================================
+ Hits 41356 48353 +6997
+ Misses 30091 23094 -6997
Partials 2048 2048
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `78.44% <100.00%> (?)` | |
| postgres | `78.49% <100.00%> (?)` | |
| presto | `?` | |
| python | `78.60% <100.00%> (+19.69%)` | :arrow_up: |
| sqlite | `76.98% <100.00%> (?)` | |
| unit | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/23388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.78% <100.00%> (+0.58%)` | :arrow_up: |
... and [350 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23388/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai merged pull request #23388: fix: update default WEBDRIVER_OPTION_ARGS and add Firefox libs to Dockerfile
Posted by "nytai (via GitHub)" <gi...@apache.org>.
nytai merged PR #23388:
URL: https://github.com/apache/superset/pull/23388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org