You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@creadur.apache.org by GitBox <gi...@apache.org> on 2022/08/10 18:54:50 UTC

[GitHub] [creadur-rat] michael-o opened a new pull request, #78: [RAT-309] Upgrade Maven Reporting API to 3.1.1/Complete with Maven Re…

michael-o opened a new pull request, #78:
URL: https://github.com/apache/creadur-rat/pull/78

   …porting Impl 3.2.0
   
   This not only upgrades to Maven Reporting API 3.1.1, but also logically
   completes this plugin with bits from Maven Reporting Impl 3.2.0 because
   we cannot inherit from AbstractMavenReport since Java does not support
   multiple inheritance. It should now behave as if using m-r-impl.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [creadur-rat] michael-o commented on pull request #78: RAT-309: Upgrade Maven Reporting API to 3.1.1/Complete with Maven Re…

Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #78:
URL: https://github.com/apache/creadur-rat/pull/78#issuecomment-1214451184

   > @michael-o can you say something concerning the warnings:
   > 
   > ```
   > [INFO] --- maven-plugin-plugin:3.6.4:descriptor (mojo-descriptor) @ apache-rat-plugin ---
   > [ERROR] 
   > 
   > Some dependencies of Maven Plugins are expected to be in provided scope.
   > Please make sure that dependencies listed below declared in POM
   > have set '<scope>provided</scope>' as well.
   > 
   > The following dependencies are in wrong scope:
   >  * org.apache.maven:maven-artifact:jar:2.2.1:compile
   >  * org.apache.maven:maven-artifact-manager:jar:2.2.1:compile
   >  * org.apache.maven:maven-repository-metadata:jar:2.2.1:compile
   >  * org.apache.maven:maven-model:jar:2.2.1:compile
   >  * org.apache.maven:maven-project:jar:2.2.1:compile
   >  * org.apache.maven:maven-profile:jar:2.2.1:compile
   >  * org.apache.maven:maven-plugin-registry:jar:2.2.1:compile
   > 
   > [INFO] Using 'UTF-8' encoding to read mojo source files.
   > [INFO] java-javadoc mojo extractor found 0 mojo descriptor.
   > [INFO] bsh mojo extractor found 0 mojo descriptor.
   > [INFO] ant mojo extractor found 0 mojo descriptor.
   > [INFO] java-annotations mojo extractor found 3 mojo descriptors.
   > ```
   > 
   > Can they be fixed easily in the pom.xml?
   
   It's not related to this change, first of all.
   Reasoning of that message: A plugin should use the Maven Core artifacts provided by the Maven runtime, not a specific version your compiled against.
   Two reasons:
   * Saves bunch of downloads because Maven has then bundled anyway.
   * Assures that your plugin benefits for new Maven improvements which `compile` won't give you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [creadur-rat] ottlinger commented on pull request #78: RAT-309: Upgrade Maven Reporting API to 3.1.1/Complete with Maven Re…

Posted by GitBox <gi...@apache.org>.
ottlinger commented on PR #78:
URL: https://github.com/apache/creadur-rat/pull/78#issuecomment-1214450504

   @michael-o can you say something concerning the warnings:
   
   ```
   [INFO] --- maven-plugin-plugin:3.6.4:descriptor (mojo-descriptor) @ apache-rat-plugin ---
   [ERROR] 
   
   Some dependencies of Maven Plugins are expected to be in provided scope.
   Please make sure that dependencies listed below declared in POM
   have set '<scope>provided</scope>' as well.
   
   The following dependencies are in wrong scope:
    * org.apache.maven:maven-artifact:jar:2.2.1:compile
    * org.apache.maven:maven-artifact-manager:jar:2.2.1:compile
    * org.apache.maven:maven-repository-metadata:jar:2.2.1:compile
    * org.apache.maven:maven-model:jar:2.2.1:compile
    * org.apache.maven:maven-project:jar:2.2.1:compile
    * org.apache.maven:maven-profile:jar:2.2.1:compile
    * org.apache.maven:maven-plugin-registry:jar:2.2.1:compile
   
   [INFO] Using 'UTF-8' encoding to read mojo source files.
   [INFO] java-javadoc mojo extractor found 0 mojo descriptor.
   [INFO] bsh mojo extractor found 0 mojo descriptor.
   [INFO] ant mojo extractor found 0 mojo descriptor.
   [INFO] java-annotations mojo extractor found 3 mojo descriptors.
   
   ```
   
   Can they be fixed easily in the pom.xml?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [creadur-rat] michael-o commented on pull request #78: [RAT-309] Upgrade Maven Reporting API to 3.1.1/Complete with Maven Re…

Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #78:
URL: https://github.com/apache/creadur-rat/pull/78#issuecomment-1211133727

   Guys, please reformat to Creadur style as you think fit. I have copied 1:1 from Maven source code with our formatting to have 1:1 mapping of the code. (Makes diffing easier)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [creadur-rat] ottlinger merged pull request #78: RAT-309: Upgrade Maven Reporting API to 3.1.1/Complete with Maven Re…

Posted by GitBox <gi...@apache.org>.
ottlinger merged PR #78:
URL: https://github.com/apache/creadur-rat/pull/78


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org