[GitHub] [beam] TheNeuralBit commented on pull request #15410: [BEAM-10277] Encoding position initial implementation

[GitBox <gi...@apache.org>]

TheNeuralBit commented on pull request #15410:
URL: https://github.com/apache/beam/pull/15410#issuecomment-934593431


   Thanks @pabloem! I still need to take a closer look, but I have a couple of initial comments:
   - Looks like you need ro merge or rebase to resolve a conflict in row_coder_test.py
   - Could you also look at adding test case(s) to standard_coders.yaml, like this one: https://github.com/apache/beam/blob/master/model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml#L401-L410
   
   It's nice to have test cases there since we verify them for every SDK (Java does this in [CommonCoderTest.java](https://github.com/apache/beam/blob/master/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/CommonCoderTest.java), Python in [standard_coders_test.py](https://github.com/apache/beam/blob/master/sdks/python/apache_beam/coders/standard_coders_test.py))


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org