[jira] [Commented] (FELIX-5225) Felix SCR bnd plugin does not include modified classfiles

["Pierre De Rop (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218973#comment-15218973 ] 

Pierre De Rop commented on FELIX-5225:
--------------------------------------

Hello Brian,

So, just to see if I understand correctly: you are talking about the case where a field is annotated with an @Reference annotation, and then, the SCRGenerator injects the bind/unbind methods using ASM; but in this case, the modified classes are then not added in the bundle generated by the bnd scrplugin ?

am I correct ? I ask this because I tried to reproduce the issue but it actually worked well.
I did the following tests (I'm using the version from the trunk):

1) first, I created a maven project, and invoked the maven-bundle-plugin (using the _plugin option). I then created a simple
component that declares a @Reference annotation applied on a class field (without bind/unbind methods).
So, In this scenario, the SCRGenerator injected the bind/unbind methods and the sample worked correctly.

2) I then created a pure bndtools project (not using maven at all), and did the same test: a component that depends on a service using a @Reference only applied on a class field.

So both tests worked well. I think that it worked because bnd collected the classes that were modified by the SCRDescriptorGenerator.

but maybe I'm missing somehing ? can you please attach a sample project (either a maven project or a bndtools project) which reproduces the issue ?

many thanks;
/Pierre



> Felix SCR bnd plugin does not include modified classfiles
> ---------------------------------------------------------
>
>                 Key: FELIX-5225
>                 URL: https://issues.apache.org/jira/browse/FELIX-5225
>             Project: Felix
>          Issue Type: Bug
>          Components: SCR Tooling
>    Affects Versions: scr bnd plugin 1.4.0
>            Reporter: Brian O'Connor
>         Attachments: FELIX-5225.diff
>
>
> The SCRDescriptorGenerator successfully add the bind/unbind methods for references, and then returns the modified files in the result.
> However, these files are not put on the bnd analyzer, and thus not included in the output jar.
> The effect is that the component's classfiles in the generated jar lack the bind/unbind methods for all references.
> I have a working fix in downstream fork, and I would like to contribute it.
> https://gerrit.onosproject.org/#/c/8360/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)