Re: error log cleanup

[Randy Terbush <ra...@zyzzyva.com>]

These errors raise what looks to me to be an interesting issue.

The following code from send_mmap()


        while (n && !r->connection->aborted) {
            w = bwrite(r->connection->client, (char *)mm + offset, n);
            if (w > 0) {
                reset_timeout(r); /* reset timeout after successful write */
                total_bytes_sent += w;
                n -= w;
                offset += w;
            }
            else if (w < 0) {
                if (r->connection->aborted)
                    break;
                else if (errno == EAGAIN)
                    continue;
                else {
                    aplog_error(APLOG_MARK, APLOG_NOTICE, r->server,
                                "send mmap lost connection to %s",
                                get_remote_host(r->connection,
                                                r->per_dir_config, REMOTE_NAME))
;
                    bsetflag(r->connection->client, B_EOUT, 1);
                    r->connection->aborted = 1;
                    break;
                }
            }
        }
    

The first error below comes from the bit of code above, the second 
error comes from timeout(). Should we be blocking the timeout() 
alarm to allow us to finish this loop? Either the error here, or 
that in timeout seems somewhat redundant.

                                                            
> 
> These mean the same thing, yes?  If so, the error level should be equal;
> might also be good to remove "client":
> 
> 
> [Tue Sep  2 20:04:28 1997] [notice] send mmap lost connection to
> 206.250.242.100
> [Tue Sep  2 20:04:29 1997] [warn] send mmap lost connection to client
> 207.172.148.134
> 
> 
> 	Brian
> 
> 
> --=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
> "Why not?" - TL           brian@organic.com - hyperreal.org - apache.org