You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/06/17 03:47:28 UTC

[PR] Add stable diagnostic categories [shardingsphere]

terrymanu opened a new pull request, #38858:
URL: https://github.com/apache/shardingsphere/pull/38858

   - Rename runtime database validation discovery to database_gateway_validate_runtime_database
   - Keep database_gateway_validate_proxy_connectivity as a hidden compatibility alias
   - Add non-sensitive categories for runtime status, HTTP security, query failures, and metadata visibility
   - Return actionable recovery payloads for transport security and query execution errors
   - Update MCP docs after resolving the first five troubleshooting follow-ups
   
   For #35294.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add stable diagnostic categories [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #38858:
URL: https://github.com/apache/shardingsphere/pull/38858


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add stable diagnostic categories [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #38858:
URL: https://github.com/apache/shardingsphere/pull/38858#issuecomment-4727093141

   Merge Decision: Mergeable
   
   ### Summary
   
   The latest public PR head resolves the earlier metadata-search classification issue and removes the generated classpath artifact from the PR scope. I did not find any remaining merge-blocking issues in the reviewed MCP changes.
   
   ### Evidence
   
   - Scope was verified against the latest public head `11075e7a73fec51f199cb496242e6e4bf8c71622` with merge-base `3cfde6a259663ee2727d5f987bf183f0ee1fb855`; GitHub files API and local merge-base diff both report 59 files.
   - No generated `.codex/tmp`, `e2e-classpath`, or `target/` file remains in the PR file list.
   - `SearchMetadataToolHandler` now checks schema visibility with the metadata facade before returning `schema_not_visible`, so a valid schema with a missing object is correctly classified as `object_not_visible`; `SearchMetadataToolHandlerTest` includes the regression case.
   - The runtime-database validation rename is compatible: the public descriptor/docs/baselines expose `database_gateway_validate_runtime_database`, while `ToolDefinitionRegistry` still accepts the legacy `database_gateway_validate_proxy_connectivity` alias.
   - Query and transport recovery now use stable diagnostic categories, and the tests cover SQLState classification, transport security categories, and secret-safe query failure recovery.
   - The PR diff does not introduce direct `ConcurrentHashMap#computeIfAbsent` usage in MCP/runtime paths.
   
   ### Review Details
   
   Local verification passed:
   
   - `./mvnw -pl mcp/core -am -DskipITs -Dspotless.skip=true -Dsurefire.failIfNoSpecifiedTests=false test` exited 0.
   - `./mvnw -pl mcp/bootstrap -am -DskipITs -Dspotless.skip=true -Dsurefire.failIfNoSpecifiedTests=false test` exited 0.
   - `./mvnw -pl test/e2e/mcp -am -DskipTests -DskipITs -Dspotless.skip=true test-compile` exited 0.
   - `./mvnw -pl mcp/bootstrap,mcp/core,mcp/support,test/e2e/mcp -am -DskipTests checkstyle:check -Pcheck -T1C` exited 0.
   - `./mvnw -pl mcp/bootstrap,mcp/core,mcp/support,test/e2e/mcp -am -DskipTests spotless:check -Pcheck -T1C` exited 0.
   
   Full production E2E runtime was not started locally; the changed E2E files are expected-name/baseline synchronizations and the E2E MCP test sources compile successfully.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org