You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/06/26 07:37:49 UTC

[GitHub] [calcite] rubenada commented on a change in pull request #1279: [CALCITE-3128] Joining two tables producing only NULLs will return 0 …

rubenada commented on a change in pull request #1279: [CALCITE-3128] Joining two tables producing only NULLs will return 0 …
URL: https://github.com/apache/calcite/pull/1279#discussion_r297522160
 
 

 ##########
 File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java
 ##########
 @@ -1078,7 +1084,9 @@ public void close() {
           Enumerator<TInner> inners = Linq4j.emptyEnumerator();
           Set<TKey> unmatchedKeys =
               generateNullsOnLeft
-                  ? new HashSet<>(innerLookup.keySet())
+                  ? !isConditionAlwaysTrue
 
 Review comment:
   Couldn't this be simplified?
   ```
   (generateNullsOnLeft && !isConditionAlwaysTrue)
       ? new HashSet<>(innerLookup.keySet())
       : null;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services