You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/10 21:59:21 UTC

[GitHub] [beam] y1chi opened a new pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

y1chi opened a new pull request #12817:
URL: https://github.com/apache/beam/pull/12817


   …overflows
   
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   Post-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
   --- | --- | --- | --- | --- | --- | ---
   Go | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
   Java | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/i
 con)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[![Build Status](htt
 ps://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
   Python | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_
 Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_P
 ostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
   XLang | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
   
   Pre-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   --- |Java | Python | Go | Website | Whitespace | Typescript
   --- | --- | --- | --- | --- | --- | ---
   Non-portable | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/be
 am_PreCommit_Go_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
   Portable | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
   
   See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
   
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12817:
URL: https://github.com/apache/beam/pull/12817#issuecomment-690788920


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=h1) Report
   > Merging [#12817](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/8846a15697e454310725470fbac9b266240953e2?el=desc) will **increase** coverage by `42.00%`.
   > The diff coverage is `84.31%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12817/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12817       +/-   ##
   ===========================================
   + Coverage   40.38%   82.39%   +42.00%     
   ===========================================
     Files         451      451               
     Lines       53721    53769       +48     
   ===========================================
   + Hits        21696    44301    +22605     
   + Misses      32025     9468    -22557     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...n/apache\_beam/runners/dataflow/dataflow\_metrics.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19tZXRyaWNzLnB5) | `74.32% <33.33%> (+50.18%)` | :arrow_up: |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `92.85% <69.23%> (+63.80%)` | :arrow_up: |
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `94.78% <90.90%> (+69.78%)` | :arrow_up: |
   | [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `89.74% <100.00%> (+65.22%)` | :arrow_up: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `88.17% <100.00%> (+74.55%)` | :arrow_up: |
   | [sdks/python/apache\_beam/coders/slow\_stream.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Nsb3dfc3RyZWFtLnB5) | `92.43% <0.00%> (+1.68%)` | :arrow_up: |
   | [sdks/python/apache\_beam/utils/profiler.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvZmlsZXIucHk=) | `32.11% <0.00%> (+1.83%)` | :arrow_up: |
   | [...on/apache\_beam/runners/direct/sdf\_direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3Qvc2RmX2RpcmVjdF9ydW5uZXIucHk=) | `36.21% <0.00%> (+2.46%)` | :arrow_up: |
   | [sdks/python/apache\_beam/coders/coder\_impl.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyX2ltcGwucHk=) | `95.25% <0.00%> (+2.64%)` | :arrow_up: |
   | [sdks/python/apache\_beam/io/azure/blobstorageio.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXp1cmUvYmxvYnN0b3JhZ2Vpby5weQ==) | `26.95% <0.00%> (+3.19%)` | :arrow_up: |
   | ... and [273 more](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=footer). Last update [68e7f2e...0249004](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] angoenka merged pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
angoenka merged pull request #12817:
URL: https://github.com/apache/beam/pull/12817


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12817:
URL: https://github.com/apache/beam/pull/12817#issuecomment-690788920


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=h1) Report
   > Merging [#12817](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d647db6ad6706a22a1d3ee2ea446e8560c929d2?el=desc) will **increase** coverage by `41.99%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12817/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12817       +/-   ##
   ===========================================
   + Coverage   40.37%   82.36%   +41.99%     
   ===========================================
     Files         451      451               
     Lines       53750    53753        +3     
   ===========================================
   + Hits        21699    44274    +22575     
   + Misses      32051     9479    -22572     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...n/apache\_beam/runners/dataflow/dataflow\_metrics.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19tZXRyaWNzLnB5) | `74.32% <33.33%> (+50.18%)` | :arrow_up: |
   | [sdks/python/apache\_beam/coders/slow\_stream.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Nsb3dfc3RyZWFtLnB5) | `92.43% <0.00%> (+1.68%)` | :arrow_up: |
   | [sdks/python/apache\_beam/utils/profiler.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvZmlsZXIucHk=) | `32.11% <0.00%> (+1.83%)` | :arrow_up: |
   | [...on/apache\_beam/runners/direct/sdf\_direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3Qvc2RmX2RpcmVjdF9ydW5uZXIucHk=) | `36.21% <0.00%> (+2.46%)` | :arrow_up: |
   | [sdks/python/apache\_beam/coders/coder\_impl.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyX2ltcGwucHk=) | `95.25% <0.00%> (+2.64%)` | :arrow_up: |
   | [sdks/python/apache\_beam/io/azure/blobstorageio.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXp1cmUvYmxvYnN0b3JhZ2Vpby5weQ==) | `26.95% <0.00%> (+3.19%)` | :arrow_up: |
   | [sdks/python/apache\_beam/utils/proto\_utils.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvdG9fdXRpbHMucHk=) | `63.07% <0.00%> (+4.61%)` | :arrow_up: |
   | [...pache\_beam/examples/cookbook/bigquery\_tornadoes.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29va2Jvb2svYmlncXVlcnlfdG9ybmFkb2VzLnB5) | `45.00% <0.00%> (+5.00%)` | :arrow_up: |
   | [...runners/interactive/options/interactive\_options.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2ludGVyYWN0aXZlX29wdGlvbnMucHk=) | `86.66% <0.00%> (+6.66%)` | :arrow_up: |
   | [...apache\_beam/examples/cookbook/custom\_ptransform.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29va2Jvb2svY3VzdG9tX3B0cmFuc2Zvcm0ucHk=) | `53.48% <0.00%> (+6.97%)` | :arrow_up: |
   | ... and [269 more](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=footer). Last update [68e7f2e...f188fca](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] angoenka merged pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
angoenka merged pull request #12817:
URL: https://github.com/apache/beam/pull/12817


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] angoenka commented on a change in pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
angoenka commented on a change in pull request #12817:
URL: https://github.com/apache/beam/pull/12817#discussion_r486688088



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
##########
@@ -210,6 +210,14 @@ def _get_metric_value(self, metric):
       dist_sum = _get_match(
           metric.distribution.object_value.properties,
           lambda x: x.key == 'sum').value.integer_value
+      if not dist_sum:
+        # distribution metric is not meant to use on large values, but in case
+        # it is, the value can overflow and become double_value, the correctness
+        # of the value may not be guaranteed.
+        dist_sum = int(

Review comment:
       Should we also add the metric name in the logs for easier debugging.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] y1chi commented on a change in pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
y1chi commented on a change in pull request #12817:
URL: https://github.com/apache/beam/pull/12817#discussion_r487177713



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
##########
@@ -210,6 +210,14 @@ def _get_metric_value(self, metric):
       dist_sum = _get_match(
           metric.distribution.object_value.properties,
           lambda x: x.key == 'sum').value.integer_value
+      if not dist_sum:
+        # distribution metric is not meant to use on large values, but in case
+        # it is, the value can overflow and become double_value, the correctness
+        # of the value may not be guaranteed.
+        dist_sum = int(

Review comment:
       done.

##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
##########
@@ -210,6 +210,14 @@ def _get_metric_value(self, metric):
       dist_sum = _get_match(
           metric.distribution.object_value.properties,
           lambda x: x.key == 'sum').value.integer_value
+      if not dist_sum:
+        # distribution metric is not meant to use on large values, but in case
+        # it is, the value can overflow and become double_value, the correctness
+        # of the value may not be guaranteed.
+        dist_sum = int(

Review comment:
       done.

##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
##########
@@ -210,6 +210,14 @@ def _get_metric_value(self, metric):
       dist_sum = _get_match(
           metric.distribution.object_value.properties,
           lambda x: x.key == 'sum').value.integer_value
+      if not dist_sum:
+        # distribution metric is not meant to use on large values, but in case
+        # it is, the value can overflow and become double_value, the correctness
+        # of the value may not be guaranteed.
+        dist_sum = int(

Review comment:
       done.

##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
##########
@@ -210,6 +210,14 @@ def _get_metric_value(self, metric):
       dist_sum = _get_match(
           metric.distribution.object_value.properties,
           lambda x: x.key == 'sum').value.integer_value
+      if not dist_sum:
+        # distribution metric is not meant to use on large values, but in case
+        # it is, the value can overflow and become double_value, the correctness
+        # of the value may not be guaranteed.
+        dist_sum = int(

Review comment:
       done.

##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
##########
@@ -210,6 +210,14 @@ def _get_metric_value(self, metric):
       dist_sum = _get_match(
           metric.distribution.object_value.properties,
           lambda x: x.key == 'sum').value.integer_value
+      if not dist_sum:
+        # distribution metric is not meant to use on large values, but in case
+        # it is, the value can overflow and become double_value, the correctness
+        # of the value may not be guaranteed.
+        dist_sum = int(

Review comment:
       done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] angoenka merged pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
angoenka merged pull request #12817:
URL: https://github.com/apache/beam/pull/12817


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12817:
URL: https://github.com/apache/beam/pull/12817#issuecomment-690788920


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=h1) Report
   > Merging [#12817](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/8846a15697e454310725470fbac9b266240953e2?el=desc) will **increase** coverage by `42.00%`.
   > The diff coverage is `84.31%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12817/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12817       +/-   ##
   ===========================================
   + Coverage   40.38%   82.39%   +42.00%     
   ===========================================
     Files         451      451               
     Lines       53721    53769       +48     
   ===========================================
   + Hits        21696    44301    +22605     
   + Misses      32025     9468    -22557     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...n/apache\_beam/runners/dataflow/dataflow\_metrics.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19tZXRyaWNzLnB5) | `74.32% <33.33%> (+50.18%)` | :arrow_up: |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `92.85% <69.23%> (+63.80%)` | :arrow_up: |
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `94.78% <90.90%> (+69.78%)` | :arrow_up: |
   | [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `89.74% <100.00%> (+65.22%)` | :arrow_up: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `88.17% <100.00%> (+74.55%)` | :arrow_up: |
   | [sdks/python/apache\_beam/coders/slow\_stream.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Nsb3dfc3RyZWFtLnB5) | `92.43% <0.00%> (+1.68%)` | :arrow_up: |
   | [sdks/python/apache\_beam/utils/profiler.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvZmlsZXIucHk=) | `32.11% <0.00%> (+1.83%)` | :arrow_up: |
   | [...on/apache\_beam/runners/direct/sdf\_direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3Qvc2RmX2RpcmVjdF9ydW5uZXIucHk=) | `36.21% <0.00%> (+2.46%)` | :arrow_up: |
   | [sdks/python/apache\_beam/coders/coder\_impl.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyX2ltcGwucHk=) | `95.25% <0.00%> (+2.64%)` | :arrow_up: |
   | [sdks/python/apache\_beam/io/azure/blobstorageio.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXp1cmUvYmxvYnN0b3JhZ2Vpby5weQ==) | `26.95% <0.00%> (+3.19%)` | :arrow_up: |
   | ... and [273 more](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=footer). Last update [68e7f2e...0249004](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] angoenka commented on a change in pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
angoenka commented on a change in pull request #12817:
URL: https://github.com/apache/beam/pull/12817#discussion_r486685114



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
##########
@@ -210,6 +210,14 @@ def _get_metric_value(self, metric):
       dist_sum = _get_match(
           metric.distribution.object_value.properties,
           lambda x: x.key == 'sum').value.integer_value
+      if not dist_sum:
+        # distribution metric is not meant to use on large values, but in case
+        # it is, the value can overflow and become double_value, the correctness
+        # of the value may not be guaranteed.
+        dist_sum = int(

Review comment:
       Do we need to log if this happens else this will be a silent failure.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #12817:
URL: https://github.com/apache/beam/pull/12817#issuecomment-690788920


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=h1) Report
   > Merging [#12817](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d647db6ad6706a22a1d3ee2ea446e8560c929d2?el=desc) will **increase** coverage by `41.99%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12817/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12817       +/-   ##
   ===========================================
   + Coverage   40.37%   82.36%   +41.99%     
   ===========================================
     Files         451      451               
     Lines       53750    53753        +3     
   ===========================================
   + Hits        21699    44274    +22575     
   + Misses      32051     9479    -22572     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...n/apache\_beam/runners/dataflow/dataflow\_metrics.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19tZXRyaWNzLnB5) | `74.32% <33.33%> (+50.18%)` | :arrow_up: |
   | [sdks/python/apache\_beam/coders/slow\_stream.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Nsb3dfc3RyZWFtLnB5) | `92.43% <0.00%> (+1.68%)` | :arrow_up: |
   | [sdks/python/apache\_beam/utils/profiler.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvZmlsZXIucHk=) | `32.11% <0.00%> (+1.83%)` | :arrow_up: |
   | [...on/apache\_beam/runners/direct/sdf\_direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3Qvc2RmX2RpcmVjdF9ydW5uZXIucHk=) | `36.21% <0.00%> (+2.46%)` | :arrow_up: |
   | [sdks/python/apache\_beam/coders/coder\_impl.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyX2ltcGwucHk=) | `95.25% <0.00%> (+2.64%)` | :arrow_up: |
   | [sdks/python/apache\_beam/io/azure/blobstorageio.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXp1cmUvYmxvYnN0b3JhZ2Vpby5weQ==) | `26.95% <0.00%> (+3.19%)` | :arrow_up: |
   | [sdks/python/apache\_beam/utils/proto\_utils.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvdG9fdXRpbHMucHk=) | `63.07% <0.00%> (+4.61%)` | :arrow_up: |
   | [...pache\_beam/examples/cookbook/bigquery\_tornadoes.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29va2Jvb2svYmlncXVlcnlfdG9ybmFkb2VzLnB5) | `45.00% <0.00%> (+5.00%)` | :arrow_up: |
   | [...runners/interactive/options/interactive\_options.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2ludGVyYWN0aXZlX29wdGlvbnMucHk=) | `86.66% <0.00%> (+6.66%)` | :arrow_up: |
   | [...apache\_beam/examples/cookbook/custom\_ptransform.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29va2Jvb2svY3VzdG9tX3B0cmFuc2Zvcm0ucHk=) | `53.48% <0.00%> (+6.97%)` | :arrow_up: |
   | ... and [269 more](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=footer). Last update [68e7f2e...f188fca](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12817:
URL: https://github.com/apache/beam/pull/12817#issuecomment-690788920






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] y1chi commented on a change in pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
y1chi commented on a change in pull request #12817:
URL: https://github.com/apache/beam/pull/12817#discussion_r487177713



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
##########
@@ -210,6 +210,14 @@ def _get_metric_value(self, metric):
       dist_sum = _get_match(
           metric.distribution.object_value.properties,
           lambda x: x.key == 'sum').value.integer_value
+      if not dist_sum:
+        # distribution metric is not meant to use on large values, but in case
+        # it is, the value can overflow and become double_value, the correctness
+        # of the value may not be guaranteed.
+        dist_sum = int(

Review comment:
       done.

##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
##########
@@ -210,6 +210,14 @@ def _get_metric_value(self, metric):
       dist_sum = _get_match(
           metric.distribution.object_value.properties,
           lambda x: x.key == 'sum').value.integer_value
+      if not dist_sum:
+        # distribution metric is not meant to use on large values, but in case
+        # it is, the value can overflow and become double_value, the correctness
+        # of the value may not be guaranteed.
+        dist_sum = int(

Review comment:
       done.

##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
##########
@@ -210,6 +210,14 @@ def _get_metric_value(self, metric):
       dist_sum = _get_match(
           metric.distribution.object_value.properties,
           lambda x: x.key == 'sum').value.integer_value
+      if not dist_sum:
+        # distribution metric is not meant to use on large values, but in case
+        # it is, the value can overflow and become double_value, the correctness
+        # of the value may not be guaranteed.
+        dist_sum = int(

Review comment:
       done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] y1chi commented on a change in pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
y1chi commented on a change in pull request #12817:
URL: https://github.com/apache/beam/pull/12817#discussion_r486685631



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
##########
@@ -210,6 +210,14 @@ def _get_metric_value(self, metric):
       dist_sum = _get_match(
           metric.distribution.object_value.properties,
           lambda x: x.key == 'sum').value.integer_value
+      if not dist_sum:
+        # distribution metric is not meant to use on large values, but in case
+        # it is, the value can overflow and become double_value, the correctness
+        # of the value may not be guaranteed.
+        dist_sum = int(

Review comment:
       Sounds good.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] y1chi commented on a change in pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
y1chi commented on a change in pull request #12817:
URL: https://github.com/apache/beam/pull/12817#discussion_r487177713



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
##########
@@ -210,6 +210,14 @@ def _get_metric_value(self, metric):
       dist_sum = _get_match(
           metric.distribution.object_value.properties,
           lambda x: x.key == 'sum').value.integer_value
+      if not dist_sum:
+        # distribution metric is not meant to use on large values, but in case
+        # it is, the value can overflow and become double_value, the correctness
+        # of the value may not be guaranteed.
+        dist_sum = int(

Review comment:
       done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12817:
URL: https://github.com/apache/beam/pull/12817#issuecomment-690788920


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=h1) Report
   > Merging [#12817](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/3d647db6ad6706a22a1d3ee2ea446e8560c929d2?el=desc) will **increase** coverage by `41.99%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12817/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12817       +/-   ##
   ===========================================
   + Coverage   40.37%   82.36%   +41.99%     
   ===========================================
     Files         451      451               
     Lines       53750    53753        +3     
   ===========================================
   + Hits        21699    44274    +22575     
   + Misses      32051     9479    -22572     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...n/apache\_beam/runners/dataflow/dataflow\_metrics.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19tZXRyaWNzLnB5) | `74.32% <33.33%> (+50.18%)` | :arrow_up: |
   | [sdks/python/apache\_beam/coders/slow\_stream.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Nsb3dfc3RyZWFtLnB5) | `92.43% <0.00%> (+1.68%)` | :arrow_up: |
   | [sdks/python/apache\_beam/utils/profiler.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvZmlsZXIucHk=) | `32.11% <0.00%> (+1.83%)` | :arrow_up: |
   | [...on/apache\_beam/runners/direct/sdf\_direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3Qvc2RmX2RpcmVjdF9ydW5uZXIucHk=) | `36.21% <0.00%> (+2.46%)` | :arrow_up: |
   | [sdks/python/apache\_beam/coders/coder\_impl.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyX2ltcGwucHk=) | `95.25% <0.00%> (+2.64%)` | :arrow_up: |
   | [sdks/python/apache\_beam/io/azure/blobstorageio.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXp1cmUvYmxvYnN0b3JhZ2Vpby5weQ==) | `26.95% <0.00%> (+3.19%)` | :arrow_up: |
   | [sdks/python/apache\_beam/utils/proto\_utils.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvdG9fdXRpbHMucHk=) | `63.07% <0.00%> (+4.61%)` | :arrow_up: |
   | [...pache\_beam/examples/cookbook/bigquery\_tornadoes.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29va2Jvb2svYmlncXVlcnlfdG9ybmFkb2VzLnB5) | `45.00% <0.00%> (+5.00%)` | :arrow_up: |
   | [...runners/interactive/options/interactive\_options.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2ludGVyYWN0aXZlX29wdGlvbnMucHk=) | `86.66% <0.00%> (+6.66%)` | :arrow_up: |
   | [...apache\_beam/examples/cookbook/custom\_ptransform.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29va2Jvb2svY3VzdG9tX3B0cmFuc2Zvcm0ucHk=) | `53.48% <0.00%> (+6.97%)` | :arrow_up: |
   | ... and [269 more](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=footer). Last update [68e7f2e...f188fca](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] angoenka merged pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
angoenka merged pull request #12817:
URL: https://github.com/apache/beam/pull/12817






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] y1chi commented on pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #12817:
URL: https://github.com/apache/beam/pull/12817#issuecomment-690773882


   R: @angoenka 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12817:
URL: https://github.com/apache/beam/pull/12817#issuecomment-690788920


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=h1) Report
   > Merging [#12817](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/8846a15697e454310725470fbac9b266240953e2?el=desc) will **increase** coverage by `41.97%`.
   > The diff coverage is `84.31%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12817/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12817       +/-   ##
   ===========================================
   + Coverage   40.38%   82.36%   +41.97%     
   ===========================================
     Files         451      451               
     Lines       53721    53753       +32     
   ===========================================
   + Hits        21696    44274    +22578     
   + Misses      32025     9479    -22546     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...n/apache\_beam/runners/dataflow/dataflow\_metrics.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19tZXRyaWNzLnB5) | `74.32% <33.33%> (+50.18%)` | :arrow_up: |
   | [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `92.85% <69.23%> (+63.80%)` | :arrow_up: |
   | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `94.78% <90.90%> (+69.78%)` | :arrow_up: |
   | [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `89.53% <100.00%> (+65.01%)` | :arrow_up: |
   | [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `88.17% <100.00%> (+74.55%)` | :arrow_up: |
   | [sdks/python/apache\_beam/coders/slow\_stream.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Nsb3dfc3RyZWFtLnB5) | `92.43% <0.00%> (+1.68%)` | :arrow_up: |
   | [sdks/python/apache\_beam/utils/profiler.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvZmlsZXIucHk=) | `32.11% <0.00%> (+1.83%)` | :arrow_up: |
   | [...on/apache\_beam/runners/direct/sdf\_direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3Qvc2RmX2RpcmVjdF9ydW5uZXIucHk=) | `36.21% <0.00%> (+2.46%)` | :arrow_up: |
   | [sdks/python/apache\_beam/coders/coder\_impl.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyX2ltcGwucHk=) | `95.25% <0.00%> (+2.64%)` | :arrow_up: |
   | [sdks/python/apache\_beam/io/azure/blobstorageio.py](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXp1cmUvYmxvYnN0b3JhZ2Vpby5weQ==) | `26.95% <0.00%> (+3.19%)` | :arrow_up: |
   | ... and [273 more](https://codecov.io/gh/apache/beam/pull/12817/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=footer). Last update [68e7f2e...0249004](https://codecov.io/gh/apache/beam/pull/12817?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12817:
URL: https://github.com/apache/beam/pull/12817#issuecomment-690788920






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] y1chi commented on a change in pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

Posted by GitBox <gi...@apache.org>.
y1chi commented on a change in pull request #12817:
URL: https://github.com/apache/beam/pull/12817#discussion_r487177713



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
##########
@@ -210,6 +210,14 @@ def _get_metric_value(self, metric):
       dist_sum = _get_match(
           metric.distribution.object_value.properties,
           lambda x: x.key == 'sum').value.integer_value
+      if not dist_sum:
+        # distribution metric is not meant to use on large values, but in case
+        # it is, the value can overflow and become double_value, the correctness
+        # of the value may not be guaranteed.
+        dist_sum = int(

Review comment:
       done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org