You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2010/05/09 22:17:21 UTC

svn commit: r942606 - in /maven/shared/trunk/maven-reporting-impl/src: main/java/org/apache/maven/reporting/AbstractMavenReport.java main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java site/apt/index.apt

Author: hboutemy
Date: Sun May  9 20:17:20 2010
New Revision: 942606

URL: http://svn.apache.org/viewvc?rev=942606&view=rev
Log:
little code and documentation improvements

Modified:
    maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java
    maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
    maven/shared/trunk/maven-reporting-impl/src/site/apt/index.apt

Modified: maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java?rev=942606&r1=942605&r2=942606&view=diff
==============================================================================
--- maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java (original)
+++ maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java Sun May  9 20:17:20 2010
@@ -66,7 +66,7 @@ public abstract class AbstractMavenRepor
     /**
      * This method is called when the report generation is invoked directly as a standalone Mojo.
      *
-     * @throws MojoExecutionException if an error uccurs when generating the report
+     * @throws MojoExecutionException if an error occurs when generating the report
      * @see org.apache.maven.plugins.site.ReportDocumentRender
      * @see org.apache.maven.plugin.Mojo#execute()
      */
@@ -139,7 +139,8 @@ public abstract class AbstractMavenRepor
     public void generate( org.codehaus.doxia.sink.Sink aSink, Locale aLocale )
         throws MavenReportException
     {
-        getLog().warn( "Deprecated API called - not org.apache.maven.doxia.sink.Sink instance and no SinkFactory available. Please update this plugin." );
+        getLog().warn( "Deprecated API called - not org.apache.maven.doxia.sink.Sink instance and no SinkFactory"
+                       + " available. Please update this plugin." );
         generate( aSink, null, aLocale );
     }
 
@@ -177,7 +178,8 @@ public abstract class AbstractMavenRepor
 
         if ( !canGenerateReport() )
         {
-            getLog().info( "This report cannot be generated as part of the current build. The report name should be referenced in this line of output." );
+            getLog().info( "This report cannot be generated as part of the current build. "
+                           + "The report name should be referenced in this line of output." );
             return;
         }
 

Modified: maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java?rev=942606&r1=942605&r2=942606&view=diff
==============================================================================
--- maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java (original)
+++ maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java Sun May  9 20:17:20 2010
@@ -620,9 +620,9 @@ public abstract class AbstractMavenRepor
         String[] schemes = {"http", "https"};
         UrlValidator urlValidator = new UrlValidator( schemes );
 
-        if ( ( EmailValidator.getInstance().isValid( href ) ) ||
-             ( ( href.indexOf( "?" ) != -1 ) &&
-               ( EmailValidator.getInstance().isValid( href.substring( 0, href.indexOf( "?" ) ) ) ) ) )
+        if ( ( EmailValidator.getInstance().isValid( href ) )
+            || ( ( href.indexOf( "?" ) != -1 )
+                 && ( EmailValidator.getInstance().isValid( href.substring( 0, href.indexOf( "?" ) ) ) ) ) )
         {
             return "mailto:" + href;
         }
@@ -655,7 +655,7 @@ public abstract class AbstractMavenRepor
             {
                 if ( href.length() > 2 )
                 {
-                    return href.substring(2, href.length() );
+                    return href.substring( 2, href.length() );
                 }
 
                 return ".";

Modified: maven/shared/trunk/maven-reporting-impl/src/site/apt/index.apt
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-reporting-impl/src/site/apt/index.apt?rev=942606&r1=942605&r2=942606&view=diff
==============================================================================
--- maven/shared/trunk/maven-reporting-impl/src/site/apt/index.apt (original)
+++ maven/shared/trunk/maven-reporting-impl/src/site/apt/index.apt Sun May  9 20:17:20 2010
@@ -15,7 +15,7 @@ Maven Reporting Implementation
   moved to shared components to improve fexibility: starting with Maven 2.0.5, each plugin can choose its
   <<<maven-reporting-impl>>> version independently from Maven.
 
-  <<<maven-reporting-impl 2.0.x>>> uses Doxia 1.0, then is used for plugins wanting Maven 2.0.x compatibility.
+  <<<maven-reporting-impl 2.0.x>>> uses Doxia 1.0, then is used for reporting plugins wanting Maven 2.0.x compatibility.
 
-  <<<maven-reporting-impl 2.1.x>>> uses Doxia 1.1: using this version implies for a plugin that it has Maven 2.1
+  <<<maven-reporting-impl 2.1.x>>> uses Doxia 1.1: using this version implies for a reporting plugin that it has Maven 2.1
   as prerequisite.