Re: [PATCH] svn_client_commit[ 23] broken on trunk

[Karl Fogel <kf...@red-bean.com>]

John Peacock <jo...@havurah-software.org> writes:
> I am resending this with a new subject line, because I don't think it was
> obvious enough before.  Even though the breakage showed up in the
> Perl bindings tests, it actually affects any code that uses any of
> the svn_client_commit calls except for *_commit4.

+1 here, and I think SVN_DEPTH_INFINITY_OR_FILES() is the right way to
go.  Sorry for forgetting to update this in r26241.

-Karl

> [[[
> New depth argument for svn_client_commit4 wasn't promoted to
> svn_client_commit3, thus breaking all older commit API calls.
>
> * subversion/libsvn_client/commit.c
>   (svn_client_commit3): synthesize depth argument from old recurse argument
> ]]]
>
> Index: subversion/libsvn_client/commit.c
> ===================================================================
> --- subversion/libsvn_client/commit.c   (revision 27297)
> +++ subversion/libsvn_client/commit.c   (working copy)
> @@ -1770,7 +1770,9 @@
>                     svn_client_ctx_t *ctx,
>                     apr_pool_t *pool)
>  {
> -  return svn_client_commit4(commit_info_p, targets, recurse, keep_locks,
> +  svn_depth_t depth = SVN_DEPTH_INFINITY_OR_FILES(recurse);
> +
> +  return svn_client_commit4(commit_info_p, targets, depth, keep_locks,
>                              FALSE, NULL, ctx, pool);
>  }

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] svn_client_commit[ 23] broken on trunk

[John Peacock <jo...@havurah-software.org>]

Karl Fogel wrote:
> +1 here, and I think SVN_DEPTH_INFINITY_OR_FILES() is the right way to
> go.  Sorry for forgetting to update this in r26241.

Not a problem.  Committed in 27302.

John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org