You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/01/18 15:55:08 UTC
[GitHub] [kylin] wangjie-fourth opened a new pull request #1549: KYLIN-4879 Fix removeCommentInSql function
wangjie-fourth opened a new pull request #1549:
URL: https://github.com/apache/kylin/pull/1549
## Proposed changes
recode removeCommentInSql method of QueryUtil. In some case, the original code can not process right.
you can see detail in [KYLIN-4879](https://issues.apache.org/jira/browse/KYLIN-4879)
If you think something is not good, please comment below, i will keep eye on it.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ x] I have create an issue on [KYLIN-4879](https://issues.apache.org/jira/browse/KYLIN-4879), and have described the bug/feature there in detail
- [x ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [x ] Compiling and unit tests pass locally with my changes
- [x ] I have added tests that prove my fix is effective or that my feature works
- [ x] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-io commented on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-762615808
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=h1) Report
> Merging [#1549](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=desc) (e539e59) into [master](https://codecov.io/gh/apache/kylin/commit/5c12d08be9713266ae060796f6e85726cedd6256?el=desc) (5c12d08) will **decrease** coverage by `0.03%`.
> The diff coverage is `23.55%`.
[](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1549 +/- ##
============================================
- Coverage 25.43% 25.40% -0.04%
- Complexity 6767 6824 +57
============================================
Files 1508 1509 +1
Lines 93918 94711 +793
Branches 13158 13315 +157
============================================
+ Hits 23890 24059 +169
- Misses 67653 68232 +579
- Partials 2375 2420 +45
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ain/java/org/apache/kylin/query/util/SqlLexer.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvU3FsTGV4ZXIuamF2YQ==) | `21.99% <21.99%> (ø)` | `58.00 <58.00> (?)` | |
| [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `64.28% <100.00%> (+3.88%)` | `28.00 <4.00> (+2.00)` | |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | |
| [.../apache/kylin/tool/query/ProbabilityGenerator.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9xdWVyeS9Qcm9iYWJpbGl0eUdlbmVyYXRvci5qYXZh) | `71.05% <0.00%> (-5.27%)` | `11.00% <0.00%> (ø%)` | |
| [...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==) | `89.47% <0.00%> (-5.27%)` | `6.00% <0.00%> (-1.00%)` | |
| [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0.00%> (-3.41%)` | `8.00% <0.00%> (ø%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0.00%> (-0.92%)` | `7.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=footer). Last update [5c12d08...e539e59](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] wangjie-fourth removed a comment on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
wangjie-fourth removed a comment on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-765099986
@hit-lacus Hi, could you please review ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] wangjie-fourth closed pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
wangjie-fourth closed pull request #1549:
URL: https://github.com/apache/kylin/pull/1549
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-764449666
Thanks @wangjie-fourth , you are great .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-766299758
Thanks a lot for taking a lot of effort on this issues, I was thinking if it is a better to solve this via javacc. I am doing a small research on this. Will update soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-762577953
Hi @wangjie-fourth , thanks for your contribution, I have re-trigger a re-run for **LGTM analysis: Java**, let's wait and see.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] wangjie-fourth commented on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
wangjie-fourth commented on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-762569471
@hit-lacus hi,could you please help me ?`LGTM analysis: Java` seems to fail because it did not download the jar package successful, Should I re-push to trigger these checks?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] wangjie-fourth commented on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
wangjie-fourth commented on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-765099986
@hit-lacus Hi, could you please review ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-764401154
@wangjie-fourth Sorry for late reply, the patch looks good to me, but I wonder if it is OK that you can use Apache Calcite API to do the same things.
From my oponion, deleting comments is a relative trivial matter, it is not worthwhile to introduce an external(not from apache but using apache license) dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-io edited a comment on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-762615808
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=h1) Report
> Merging [#1549](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=desc) (a8888f0) into [master](https://codecov.io/gh/apache/kylin/commit/5c12d08be9713266ae060796f6e85726cedd6256?el=desc) (5c12d08) will **decrease** coverage by `0.00%`.
> The diff coverage is `31.38%`.
[](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1549 +/- ##
============================================
- Coverage 25.43% 25.43% -0.01%
+ Complexity 6767 6766 -1
============================================
Files 1508 1509 +1
Lines 93918 94289 +371
Branches 13158 13241 +83
============================================
+ Hits 23890 23982 +92
- Misses 67653 67910 +257
- Partials 2375 2397 +22
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/kylin/query/util/SqlSimpleParser.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvU3FsU2ltcGxlUGFyc2VyLmphdmE=) | `30.83% <30.83%> (ø)` | `4.00 <4.00> (?)` | |
| [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `59.59% <100.00%> (-0.81%)` | `25.00 <1.00> (-1.00)` | |
| [.../apache/kylin/tool/query/ProbabilityGenerator.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9xdWVyeS9Qcm9iYWJpbGl0eUdlbmVyYXRvci5qYXZh) | `71.05% <0.00%> (-5.27%)` | `11.00% <0.00%> (ø%)` | |
| [...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==) | `89.47% <0.00%> (-5.27%)` | `6.00% <0.00%> (-1.00%)` | |
| [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0.00%> (-3.41%)` | `8.00% <0.00%> (ø%)` | |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `73.25% <0.00%> (-2.33%)` | `12.00% <0.00%> (ø%)` | |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | |
| [...va/org/apache/kylin/tool/query/QueryGenerator.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9xdWVyeS9RdWVyeUdlbmVyYXRvci5qYXZh) | `78.88% <0.00%> (-2.23%)` | `22.00% <0.00%> (-2.00%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.60% <0.00%> (-1.52%)` | `7.00% <0.00%> (ø%)` | |
| ... and [1 more](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=footer). Last update [5c12d08...a8888f0](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] wangjie-fourth commented on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
wangjie-fourth commented on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-762623918
@hit-lacus hi,it is done already. could you please review ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] wangjie-fourth commented on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
wangjie-fourth commented on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-764434454
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls commented on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-762617030
## Pull Request Test Coverage Report for [Build 6798](https://coveralls.io/builds/36418975)
* **228** of **798** **(28.57%)** changed or added relevant lines in **2** files are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage increased (+**0.002%**) to **27.962%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [query/src/main/java/org/apache/kylin/query/util/SqlLexer.java](https://coveralls.io/builds/36418975/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FSqlLexer.java#L97) | 212 | 782 | 27.11%
<!-- | **Total:** | **228** | **798** | **28.57%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/36418975/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/36418975) |
| :-- | --: |
| Change from base [Build 6729](https://coveralls.io/builds/36067968): | 0.002% |
| Covered Lines: | 26483 |
| Relevant Lines: | 94711 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls edited a comment on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-762617030
## Pull Request Test Coverage Report for [Build 6815](https://coveralls.io/builds/36520122)
* **131** of **375** **(34.93%)** changed or added relevant lines in **2** files are covered.
* **9** unchanged lines in **4** files lost coverage.
* Overall coverage increased (+**0.02%**) to **27.98%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [query/src/main/java/org/apache/kylin/query/util/SqlSimpleParser.java](https://coveralls.io/builds/36520122/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FSqlSimpleParser.java#L51) | 129 | 373 | 34.58%
<!-- | **Total:** | **131** | **375** | **34.93%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/36520122/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
| [tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/36520122/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L44) | 1 | 81.58% |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/36520122/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/36520122/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
<!-- | **Total:** | **9** | | -->
| Totals | [](https://coveralls.io/builds/36520122) |
| :-- | --: |
| Change from base [Build 6729](https://coveralls.io/builds/36067968): | 0.02% |
| Covered Lines: | 26382 |
| Relevant Lines: | 94288 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-io edited a comment on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-762615808
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=h1) Report
> Merging [#1549](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=desc) (b891d17) into [master](https://codecov.io/gh/apache/kylin/commit/5c12d08be9713266ae060796f6e85726cedd6256?el=desc) (5c12d08) will **increase** coverage by `0.01%`.
> The diff coverage is `35.20%`.
[](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1549 +/- ##
============================================
+ Coverage 25.43% 25.45% +0.01%
- Complexity 6767 6768 +1
============================================
Files 1508 1509 +1
Lines 93918 94288 +370
Branches 13158 13241 +83
============================================
+ Hits 23890 24001 +111
- Misses 67653 67892 +239
- Partials 2375 2395 +20
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/kylin/query/util/SqlSimpleParser.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvU3FsU2ltcGxlUGFyc2VyLmphdmE=) | `34.85% <34.85%> (ø)` | `5.00 <5.00> (?)` | |
| [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `59.18% <100.00%> (-1.22%)` | `25.00 <1.00> (-1.00)` | |
| [.../apache/kylin/tool/query/ProbabilityGenerator.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9xdWVyeS9Qcm9iYWJpbGl0eUdlbmVyYXRvci5qYXZh) | `71.05% <0.00%> (-5.27%)` | `11.00% <0.00%> (ø%)` | |
| [...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==) | `89.47% <0.00%> (-5.27%)` | `6.00% <0.00%> (-1.00%)` | |
| [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0.00%> (-3.41%)` | `8.00% <0.00%> (ø%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.30% <0.00%> (-1.83%)` | `7.00% <0.00%> (ø%)` | |
| [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0.00%> (-0.80%)` | `17.00% <0.00%> (-1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=footer). Last update [5c12d08...b891d17](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-io edited a comment on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-762615808
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=h1) Report
> Merging [#1549](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=desc) (a8888f0) into [master](https://codecov.io/gh/apache/kylin/commit/5c12d08be9713266ae060796f6e85726cedd6256?el=desc) (5c12d08) will **decrease** coverage by `0.00%`.
> The diff coverage is `31.38%`.
[](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1549 +/- ##
============================================
- Coverage 25.43% 25.43% -0.01%
+ Complexity 6767 6766 -1
============================================
Files 1508 1509 +1
Lines 93918 94289 +371
Branches 13158 13241 +83
============================================
+ Hits 23890 23982 +92
- Misses 67653 67910 +257
- Partials 2375 2397 +22
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/kylin/query/util/SqlSimpleParser.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvU3FsU2ltcGxlUGFyc2VyLmphdmE=) | `30.83% <30.83%> (ø)` | `4.00 <4.00> (?)` | |
| [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `59.59% <100.00%> (-0.81%)` | `25.00 <1.00> (-1.00)` | |
| [.../apache/kylin/tool/query/ProbabilityGenerator.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9xdWVyeS9Qcm9iYWJpbGl0eUdlbmVyYXRvci5qYXZh) | `71.05% <0.00%> (-5.27%)` | `11.00% <0.00%> (ø%)` | |
| [...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==) | `89.47% <0.00%> (-5.27%)` | `6.00% <0.00%> (-1.00%)` | |
| [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0.00%> (-3.41%)` | `8.00% <0.00%> (ø%)` | |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `73.25% <0.00%> (-2.33%)` | `12.00% <0.00%> (ø%)` | |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | |
| [...va/org/apache/kylin/tool/query/QueryGenerator.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9xdWVyeS9RdWVyeUdlbmVyYXRvci5qYXZh) | `78.88% <0.00%> (-2.23%)` | `22.00% <0.00%> (-2.00%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.60% <0.00%> (-1.52%)` | `7.00% <0.00%> (ø%)` | |
| ... and [1 more](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=footer). Last update [5c12d08...a8888f0](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-io edited a comment on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-762615808
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=h1) Report
> Merging [#1549](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=desc) (87b591e) into [master](https://codecov.io/gh/apache/kylin/commit/5c12d08be9713266ae060796f6e85726cedd6256?el=desc) (5c12d08) will **increase** coverage by `0.00%`.
> The diff coverage is `32.00%`.
[](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1549 +/- ##
==========================================
Coverage 25.43% 25.43%
- Complexity 6767 6768 +1
==========================================
Files 1508 1509 +1
Lines 93918 94288 +370
Branches 13158 13241 +83
==========================================
+ Hits 23890 23985 +95
- Misses 67653 67910 +257
- Partials 2375 2393 +18
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/kylin/query/util/SqlSimpleParser.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvU3FsU2ltcGxlUGFyc2VyLmphdmE=) | `31.63% <31.63%> (ø)` | `5.00 <5.00> (?)` | |
| [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `59.18% <100.00%> (-1.22%)` | `25.00 <1.00> (-1.00)` | |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | |
| [.../apache/kylin/tool/query/ProbabilityGenerator.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9xdWVyeS9Qcm9iYWJpbGl0eUdlbmVyYXRvci5qYXZh) | `71.05% <0.00%> (-5.27%)` | `11.00% <0.00%> (ø%)` | |
| [...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==) | `89.47% <0.00%> (-5.27%)` | `6.00% <0.00%> (-1.00%)` | |
| [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0.00%> (-3.41%)` | `8.00% <0.00%> (ø%)` | |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.30% <0.00%> (-1.83%)` | `7.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=footer). Last update [5c12d08...87b591e](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls edited a comment on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-762617030
## Pull Request Test Coverage Report for [Build 6814](https://coveralls.io/builds/36519542)
* **130** of **374** **(34.76%)** changed or added relevant lines in **2** files are covered.
* **5** unchanged lines in **3** files lost coverage.
* Overall coverage increased (+**0.02%**) to **27.979%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [query/src/main/java/org/apache/kylin/query/util/SqlSimpleParser.java](https://coveralls.io/builds/36519542/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FSqlSimpleParser.java#L51) | 129 | 373 | 34.58%
<!-- | **Total:** | **130** | **374** | **34.76%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/36519542/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/36519542/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
| [tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/36519542/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L51) | 2 | 76.32% |
<!-- | **Total:** | **5** | | -->
| Totals | [](https://coveralls.io/builds/36519542) |
| :-- | --: |
| Change from base [Build 6729](https://coveralls.io/builds/36067968): | 0.02% |
| Covered Lines: | 26381 |
| Relevant Lines: | 94289 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls edited a comment on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-762617030
## Pull Request Test Coverage Report for [Build 6807](https://coveralls.io/builds/36505108)
* **132** of **376** **(35.11%)** changed or added relevant lines in **2** files are covered.
* **3** unchanged lines in **2** files lost coverage.
* Overall coverage increased (+**0.02%**) to **27.981%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [query/src/main/java/org/apache/kylin/query/util/SqlSimpleParser.java](https://coveralls.io/builds/36505108/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FSqlSimpleParser.java#L51) | 129 | 373 | 34.58%
<!-- | **Total:** | **132** | **376** | **35.11%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/36505108/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553) | 1 | 78.12% |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/36505108/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/36505108) |
| :-- | --: |
| Change from base [Build 6729](https://coveralls.io/builds/36067968): | 0.02% |
| Covered Lines: | 26383 |
| Relevant Lines: | 94289 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls edited a comment on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-762617030
## Pull Request Test Coverage Report for [Build 6807](https://coveralls.io/builds/36505108)
* **132** of **376** **(35.11%)** changed or added relevant lines in **2** files are covered.
* **3** unchanged lines in **2** files lost coverage.
* Overall coverage increased (+**0.02%**) to **27.981%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [query/src/main/java/org/apache/kylin/query/util/SqlSimpleParser.java](https://coveralls.io/builds/36505108/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FSqlSimpleParser.java#L51) | 129 | 373 | 34.58%
<!-- | **Total:** | **132** | **376** | **35.11%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/36505108/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553) | 1 | 78.12% |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/36505108/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/36505108) |
| :-- | --: |
| Change from base [Build 6729](https://coveralls.io/builds/36067968): | 0.02% |
| Covered Lines: | 26383 |
| Relevant Lines: | 94289 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls edited a comment on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-762617030
## Pull Request Test Coverage Report for [Build 6820](https://coveralls.io/builds/36544384)
* **146** of **375** **(38.93%)** changed or added relevant lines in **2** files are covered.
* **5** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.04%**) to **27.999%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [query/src/main/java/org/apache/kylin/query/util/SqlSimpleParser.java](https://coveralls.io/builds/36544384/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FSqlSimpleParser.java#L51) | 144 | 373 | 38.61%
<!-- | **Total:** | **146** | **375** | **38.93%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/36544384/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
<!-- | **Total:** | **5** | | -->
| Totals | [](https://coveralls.io/builds/36544384) |
| :-- | --: |
| Change from base [Build 6729](https://coveralls.io/builds/36067968): | 0.04% |
| Covered Lines: | 26400 |
| Relevant Lines: | 94288 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls edited a comment on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-762617030
## Pull Request Test Coverage Report for [Build 6824](https://coveralls.io/builds/36546613)
* **82** of **88** **(93.18%)** changed or added relevant lines in **2** files are covered.
* **4** unchanged lines in **3** files lost coverage.
* Overall coverage increased (+**0.06%**) to **28.018%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [query/src/main/java/org/apache/kylin/query/util/SqlCommentParser.java](https://coveralls.io/builds/36546613/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FSqlCommentParser.java#L132) | 81 | 87 | 93.1%
<!-- | **Total:** | **82** | **88** | **93.18%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/36546613/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146) | 1 | 59.09% |
| [tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/36546613/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L44) | 1 | 81.58% |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/36546613/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
<!-- | **Total:** | **4** | | -->
| Totals | [](https://coveralls.io/builds/36546613) |
| :-- | --: |
| Change from base [Build 6729](https://coveralls.io/builds/36067968): | 0.06% |
| Covered Lines: | 26337 |
| Relevant Lines: | 94001 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-io edited a comment on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-762615808
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=h1) Report
> Merging [#1549](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=desc) (c4ead40) into [master](https://codecov.io/gh/apache/kylin/commit/5c12d08be9713266ae060796f6e85726cedd6256?el=desc) (5c12d08) will **decrease** coverage by `0.00%`.
> The diff coverage is `31.38%`.
[](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1549 +/- ##
============================================
- Coverage 25.43% 25.43% -0.01%
+ Complexity 6767 6765 -2
============================================
Files 1508 1509 +1
Lines 93918 94289 +371
Branches 13158 13241 +83
============================================
+ Hits 23890 23981 +91
- Misses 67653 67912 +259
- Partials 2375 2396 +21
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/kylin/query/util/SqlSimpleParser.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvU3FsU2ltcGxlUGFyc2VyLmphdmE=) | `30.83% <30.83%> (ø)` | `4.00 <4.00> (?)` | |
| [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `59.59% <100.00%> (-0.81%)` | `25.00 <1.00> (-1.00)` | |
| [.../apache/kylin/tool/query/ProbabilityGenerator.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9xdWVyeS9Qcm9iYWJpbGl0eUdlbmVyYXRvci5qYXZh) | `65.78% <0.00%> (-10.53%)` | `10.00% <0.00%> (-1.00%)` | |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | |
| [...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==) | `89.47% <0.00%> (-5.27%)` | `6.00% <0.00%> (-1.00%)` | |
| [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0.00%> (-3.41%)` | `8.00% <0.00%> (ø%)` | |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `73.25% <0.00%> (-2.33%)` | `12.00% <0.00%> (ø%)` | |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0.00%> (-0.92%)` | `7.00% <0.00%> (ø%)` | |
| ... and [2 more](https://codecov.io/gh/apache/kylin/pull/1549/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=footer). Last update [5c12d08...87b591e](https://codecov.io/gh/apache/kylin/pull/1549?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] wangjie-fourth commented on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
wangjie-fourth commented on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-764434454
@hit-lacus you are right.I will use calcite to solve this problem later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] wangjie-fourth commented on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
wangjie-fourth commented on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-766163187
@hit-lacus Hi, when I try to use Apache Calcite to solve this problem, I realized something
The function of this method includes:
(1) Correctly delete comments in sql
(2) The parameter string may contain multiple SQL,and could be DDL、DML...
(3) The result of string should retain the original sql style;E.g, select need be select,can not converted to SELECT
(4) This function does not need to verify whether the SQL conforms to the SQL syntax specification
I can't find a suitable API in Apache Calcite to meet the above requirements.In my opinion, even using Apache Calcite's API to solve this problem will be very troublesome.
Maybe it’s because I’m not very familiar with Apache Calcite. If you have a good solution,please share it with me.
So,I wrote a SqlCommentParser.class to solve this problem.Do you think this solution meets your requirements?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1549: KYLIN-4879 Fix removeCommentInSql function
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-764401154
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org