[GitHub] [arrow] ianmcook commented on a change in pull request #9800: ARROW-12082: [R][Dataset] Allow create dataset from vector of file paths [WIP]

[GitBox <gi...@apache.org>]

ianmcook commented on a change in pull request #9800:
URL: https://github.com/apache/arrow/pull/9800#discussion_r605207187



##########
File path: r/R/dataset-factory.R
##########
@@ -45,15 +45,18 @@ DatasetFactory$create <- function(x,
     return(dataset___UnionDatasetFactory__Make(x))
   }
 
-  path_and_fs <- get_path_and_filesystem(x, filesystem)
-  selector <- FileSelector$create(path_and_fs$path, allow_not_found = FALSE, recursive = TRUE)
-
   if (is.character(format)) {
     format <- FileFormat$create(match.arg(format), ...)
   } else {
     assert_is(format, "FileFormat")
   }
 
+  path_and_fs <- get_path_and_filesystem(x, filesystem)
+
+  if (length(path_and_fs$path) > 1) {

Review comment:
       Done in 4929f99b5b96b8082f9f10c3eeaedc38f23f5287




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org