You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2010/06/28 22:36:16 UTC
svn commit: r958713 -
/maven/plugins/branches/maven-site-plugin-3.x/src/main/java/org/apache/maven/plugins/site/ReportDocumentRenderer.java
Author: hboutemy
Date: Mon Jun 28 20:36:15 2010
New Revision: 958713
URL: http://svn.apache.org/viewvc?rev=958713&view=rev
Log:
improved comments in code
Modified:
maven/plugins/branches/maven-site-plugin-3.x/src/main/java/org/apache/maven/plugins/site/ReportDocumentRenderer.java
Modified: maven/plugins/branches/maven-site-plugin-3.x/src/main/java/org/apache/maven/plugins/site/ReportDocumentRenderer.java
URL: http://svn.apache.org/viewvc/maven/plugins/branches/maven-site-plugin-3.x/src/main/java/org/apache/maven/plugins/site/ReportDocumentRenderer.java?rev=958713&r1=958712&r2=958713&view=diff
==============================================================================
--- maven/plugins/branches/maven-site-plugin-3.x/src/main/java/org/apache/maven/plugins/site/ReportDocumentRenderer.java (original)
+++ maven/plugins/branches/maven-site-plugin-3.x/src/main/java/org/apache/maven/plugins/site/ReportDocumentRenderer.java Mon Jun 28 20:36:15 2010
@@ -160,14 +160,12 @@ public class ReportDocumentRenderer
{
if ( report instanceof MavenMultiPageReport )
{
+ // extended multi-page API
( (MavenMultiPageReport) report ).generate( sink, sf, locale );
}
else
{
- // old API compatibility
- // warning message is not welcome at this time: "old" MavenReport API is still fine
- //log.warn( "\"" + localReportName + "\" report is using old MavenReport API: "
- // + "please upgrade report to a version using MavenMultiPageReport." );
+ // old single-page-only API
report.generate( sink, locale );
}
}
@@ -177,10 +175,8 @@ public class ReportDocumentRenderer
}
catch ( LinkageError e )
{
- StringBuilder stringBuilder =
- new StringBuilder( " an issue has occured with report " + report.getClass().getName() );
- stringBuilder.append( ", skip LinkageError " + e.getMessage() + ", please report an issue to maven dev team." );
- log.warn( stringBuilder.toString(), e );
+ log.warn( "An issue has occurred with report " + report.getClass().getName() + ", skip LinkageError "
+ + e.getMessage() + ", please report an issue to Maven dev team.", e );
}
finally
{