You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2021/01/17 01:37:51 UTC

[commons-collections] 02/02: Use isEmpty().

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git

commit 2b23b7add8dfb9627e5e76ee5dbaba6177b58399
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Jan 16 20:37:44 2021 -0500

    Use isEmpty().
---
 .../commons/collections4/bag/AbstractMapBag.java   |  2 +-
 .../bloomfilter/HasherBloomFilter.java             |  2 +-
 .../bloomfilter/hasher/StaticHasher.java           |  9 ++++++++
 .../collections4/comparators/ComparatorChain.java  |  2 +-
 .../collections4/functors/ChainedClosure.java      |  2 +-
 .../collections4/functors/ChainedTransformer.java  |  2 +-
 .../collections4/functors/SwitchTransformer.java   |  2 +-
 .../collections4/iterators/LoopingIterator.java    |  2 +-
 .../collections4/list/AbstractLinkedList.java      |  2 +-
 .../commons/collections4/list/SetUniqueList.java   |  2 +-
 .../collections4/map/AbstractHashedMap.java        |  8 ++++----
 .../collections4/map/AbstractLinkedMap.java        |  6 +++---
 .../apache/commons/collections4/map/Flat3Map.java  |  6 +++---
 .../commons/collections4/map/ListOrderedMap.java   |  4 ++--
 .../commons/collections4/map/MultiValueMap.java    |  2 +-
 .../commons/collections4/map/StaticBucketMap.java  |  2 +-
 .../multimap/AbstractMultiValuedMap.java           |  2 +-
 .../collections4/trie/AbstractPatriciaTrie.java    |  2 +-
 .../commons/collections4/CollectionUtilsTest.java  |  2 +-
 .../collections4/iterators/IteratorChainTest.java  |  4 ++--
 .../iterators/LazyIteratorChainTest.java           |  4 ++--
 .../commons/collections4/map/AbstractMapTest.java  | 24 +++++++++++-----------
 .../multiset/AbstractMultiSetTest.java             |  2 +-
 .../splitmap/TransformedSplitMapTest.java          |  4 ++--
 24 files changed, 54 insertions(+), 45 deletions(-)

diff --git a/src/main/java/org/apache/commons/collections4/bag/AbstractMapBag.java b/src/main/java/org/apache/commons/collections4/bag/AbstractMapBag.java
index 33cf454..114968a 100644
--- a/src/main/java/org/apache/commons/collections4/bag/AbstractMapBag.java
+++ b/src/main/java/org/apache/commons/collections4/bag/AbstractMapBag.java
@@ -599,7 +599,7 @@ public abstract class AbstractMapBag<E> implements Bag<E> {
      */
     @Override
     public String toString() {
-        if (size() == 0) {
+        if (isEmpty()) {
             return "[]";
         }
         final StringBuilder buf = new StringBuilder();
diff --git a/src/main/java/org/apache/commons/collections4/bloomfilter/HasherBloomFilter.java b/src/main/java/org/apache/commons/collections4/bloomfilter/HasherBloomFilter.java
index 0b5405b..71272e6 100644
--- a/src/main/java/org/apache/commons/collections4/bloomfilter/HasherBloomFilter.java
+++ b/src/main/java/org/apache/commons/collections4/bloomfilter/HasherBloomFilter.java
@@ -96,7 +96,7 @@ public class HasherBloomFilter extends AbstractBloomFilter {
 
     @Override
     public long[] getBits() {
-        if (hasher.size() == 0) {
+        if (hasher.isEmpty()) {
             return EMPTY;
         }
 
diff --git a/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/StaticHasher.java b/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/StaticHasher.java
index eec96d1..1c028fa 100644
--- a/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/StaticHasher.java
+++ b/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/StaticHasher.java
@@ -106,6 +106,15 @@ public final class StaticHasher implements Hasher {
     }
 
     /**
+     * Tests emptiness (size == 0).
+     * 
+     * @return Whether or not this is empty.
+     */
+    public boolean isEmpty() {
+        return size() == 0;
+    }
+
+    /**
      * Gets an iterator of integers that are the bits to enable in the Bloom
      * filter based on the shape.  The iterator will not return the same value multiple
      * times.  Values will be returned in ascending order.
diff --git a/src/main/java/org/apache/commons/collections4/comparators/ComparatorChain.java b/src/main/java/org/apache/commons/collections4/comparators/ComparatorChain.java
index 2153dfd..88ebfd9 100644
--- a/src/main/java/org/apache/commons/collections4/comparators/ComparatorChain.java
+++ b/src/main/java/org/apache/commons/collections4/comparators/ComparatorChain.java
@@ -251,7 +251,7 @@ public class ComparatorChain<E> implements Comparator<E>, Serializable {
      * @throws UnsupportedOperationException if the {@link ComparatorChain} is empty
      */
     private void checkChainIntegrity() {
-        if (comparatorChain.size() == 0) {
+        if (comparatorChain.isEmpty()) {
             throw new UnsupportedOperationException("ComparatorChains must contain at least one Comparator");
         }
     }
diff --git a/src/main/java/org/apache/commons/collections4/functors/ChainedClosure.java b/src/main/java/org/apache/commons/collections4/functors/ChainedClosure.java
index 84730ba..074baf5 100644
--- a/src/main/java/org/apache/commons/collections4/functors/ChainedClosure.java
+++ b/src/main/java/org/apache/commons/collections4/functors/ChainedClosure.java
@@ -66,7 +66,7 @@ public class ChainedClosure<E> implements Closure<E>, Serializable {
     @SuppressWarnings("unchecked")
     public static <E> Closure<E> chainedClosure(final Collection<? extends Closure<? super E>> closures) {
         Objects.requireNonNull(closures, "closures");
-        if (closures.size() == 0) {
+        if (closures.isEmpty()) {
             return NOPClosure.<E>nopClosure();
         }
         // convert to array like this to guarantee iterator() ordering
diff --git a/src/main/java/org/apache/commons/collections4/functors/ChainedTransformer.java b/src/main/java/org/apache/commons/collections4/functors/ChainedTransformer.java
index 3c3e4ba..3cc39de 100644
--- a/src/main/java/org/apache/commons/collections4/functors/ChainedTransformer.java
+++ b/src/main/java/org/apache/commons/collections4/functors/ChainedTransformer.java
@@ -72,7 +72,7 @@ public class ChainedTransformer<T> implements Transformer<T, T>, Serializable {
     public static <T> Transformer<T, T> chainedTransformer(
             final Collection<? extends Transformer<? super T, ? extends T>> transformers) {
         Objects.requireNonNull(transformers, "transformers");
-        if (transformers.size() == 0) {
+        if (transformers.isEmpty()) {
             return NOPTransformer.<T>nopTransformer();
         }
         // convert to array like this to guarantee iterator() ordering
diff --git a/src/main/java/org/apache/commons/collections4/functors/SwitchTransformer.java b/src/main/java/org/apache/commons/collections4/functors/SwitchTransformer.java
index 2175cce..4f5030d 100644
--- a/src/main/java/org/apache/commons/collections4/functors/SwitchTransformer.java
+++ b/src/main/java/org/apache/commons/collections4/functors/SwitchTransformer.java
@@ -94,7 +94,7 @@ public class SwitchTransformer<I, O> implements Transformer<I, O>, Serializable
             final Map<? extends Predicate<? super I>, ? extends Transformer<? super I, ? extends O>> map) {
 
         Objects.requireNonNull(map, "map");
-        if (map.size() == 0) {
+        if (map.isEmpty()) {
             return ConstantTransformer.<I, O>nullTransformer();
         }
         // convert to array like this to guarantee iterator() ordering
diff --git a/src/main/java/org/apache/commons/collections4/iterators/LoopingIterator.java b/src/main/java/org/apache/commons/collections4/iterators/LoopingIterator.java
index 4c2614b..df0625e 100644
--- a/src/main/java/org/apache/commons/collections4/iterators/LoopingIterator.java
+++ b/src/main/java/org/apache/commons/collections4/iterators/LoopingIterator.java
@@ -81,7 +81,7 @@ public class LoopingIterator<E> implements ResettableIterator<E> {
      */
     @Override
     public E next() {
-        if (collection.size() == 0) {
+        if (collection.isEmpty()) {
             throw new NoSuchElementException("There are no elements for this iterator to loop on");
         }
         if (iterator.hasNext() == false) {
diff --git a/src/main/java/org/apache/commons/collections4/list/AbstractLinkedList.java b/src/main/java/org/apache/commons/collections4/list/AbstractLinkedList.java
index 8954c70..067c86c 100644
--- a/src/main/java/org/apache/commons/collections4/list/AbstractLinkedList.java
+++ b/src/main/java/org/apache/commons/collections4/list/AbstractLinkedList.java
@@ -402,7 +402,7 @@ public abstract class AbstractLinkedList<E> implements List<E> {
 
     @Override
     public String toString() {
-        if (size() == 0) {
+        if (isEmpty()) {
             return "[]";
         }
         final StringBuilder buf = new StringBuilder(16 * size());
diff --git a/src/main/java/org/apache/commons/collections4/list/SetUniqueList.java b/src/main/java/org/apache/commons/collections4/list/SetUniqueList.java
index 1a5dada..84a014d 100644
--- a/src/main/java/org/apache/commons/collections4/list/SetUniqueList.java
+++ b/src/main/java/org/apache/commons/collections4/list/SetUniqueList.java
@@ -276,7 +276,7 @@ public class SetUniqueList<E> extends AbstractSerializableListDecorator<E> {
         if (result == false) {
             return false;
         }
-        if (set.size() == 0) {
+        if (set.isEmpty()) {
             super.clear();
         } else {
             // use the set as parameter for the call to retainAll to improve performance
diff --git a/src/main/java/org/apache/commons/collections4/map/AbstractHashedMap.java b/src/main/java/org/apache/commons/collections4/map/AbstractHashedMap.java
index 5e0e818..146968c 100644
--- a/src/main/java/org/apache/commons/collections4/map/AbstractHashedMap.java
+++ b/src/main/java/org/apache/commons/collections4/map/AbstractHashedMap.java
@@ -826,7 +826,7 @@ public class AbstractHashedMap<K, V> extends AbstractMap<K, V> implements Iterab
      * @return the entrySet iterator
      */
     protected Iterator<Map.Entry<K, V>> createEntrySetIterator() {
-        if (size() == 0) {
+        if (isEmpty()) {
             return EmptyIterator.<Map.Entry<K, V>>emptyIterator();
         }
         return new EntrySetIterator<>(this);
@@ -926,7 +926,7 @@ public class AbstractHashedMap<K, V> extends AbstractMap<K, V> implements Iterab
      * @return the keySet iterator
      */
     protected Iterator<K> createKeySetIterator() {
-        if (size() == 0) {
+        if (isEmpty()) {
             return EmptyIterator.<K>emptyIterator();
         }
         return new KeySetIterator<>(this);
@@ -1014,7 +1014,7 @@ public class AbstractHashedMap<K, V> extends AbstractMap<K, V> implements Iterab
      * @return the values iterator
      */
     protected Iterator<V> createValuesIterator() {
-        if (size() == 0) {
+        if (isEmpty()) {
             return EmptyIterator.<V>emptyIterator();
         }
         return new ValuesIterator<>(this);
@@ -1387,7 +1387,7 @@ public class AbstractHashedMap<K, V> extends AbstractMap<K, V> implements Iterab
      */
     @Override
     public String toString() {
-        if (size() == 0) {
+        if (isEmpty()) {
             return "{}";
         }
         final StringBuilder buf = new StringBuilder(32 * size());
diff --git a/src/main/java/org/apache/commons/collections4/map/AbstractLinkedMap.java b/src/main/java/org/apache/commons/collections4/map/AbstractLinkedMap.java
index 8d9ad7c..efc5262 100644
--- a/src/main/java/org/apache/commons/collections4/map/AbstractLinkedMap.java
+++ b/src/main/java/org/apache/commons/collections4/map/AbstractLinkedMap.java
@@ -410,7 +410,7 @@ public abstract class AbstractLinkedMap<K, V> extends AbstractHashedMap<K, V> im
      */
     @Override
     protected Iterator<Map.Entry<K, V>> createEntrySetIterator() {
-        if (size() == 0) {
+        if (isEmpty()) {
             return EmptyOrderedIterator.<Map.Entry<K, V>>emptyOrderedIterator();
         }
         return new EntrySetIterator<>(this);
@@ -446,7 +446,7 @@ public abstract class AbstractLinkedMap<K, V> extends AbstractHashedMap<K, V> im
      */
     @Override
     protected Iterator<K> createKeySetIterator() {
-        if (size() == 0) {
+        if (isEmpty()) {
             return EmptyOrderedIterator.<K>emptyOrderedIterator();
         }
         return new KeySetIterator<>(this);
@@ -483,7 +483,7 @@ public abstract class AbstractLinkedMap<K, V> extends AbstractHashedMap<K, V> im
      */
     @Override
     protected Iterator<V> createValuesIterator() {
-        if (size() == 0) {
+        if (isEmpty()) {
             return EmptyOrderedIterator.<V>emptyOrderedIterator();
         }
         return new ValuesIterator<>(this);
diff --git a/src/main/java/org/apache/commons/collections4/map/Flat3Map.java b/src/main/java/org/apache/commons/collections4/map/Flat3Map.java
index 473d98b..fcaa424 100644
--- a/src/main/java/org/apache/commons/collections4/map/Flat3Map.java
+++ b/src/main/java/org/apache/commons/collections4/map/Flat3Map.java
@@ -793,7 +793,7 @@ public class Flat3Map<K, V> implements IterableMap<K, V>, Serializable, Cloneabl
             if (parent.delegateMap != null) {
                 return parent.delegateMap.entrySet().iterator();
             }
-            if (parent.size() == 0) {
+            if (parent.isEmpty()) {
                 return EmptyIterator.<Map.Entry<K, V>>emptyIterator();
             }
             return new EntrySetIterator<>(parent);
@@ -1016,7 +1016,7 @@ public class Flat3Map<K, V> implements IterableMap<K, V>, Serializable, Cloneabl
             if (parent.delegateMap != null) {
                 return parent.delegateMap.keySet().iterator();
             }
-            if (parent.size() == 0) {
+            if (parent.isEmpty()) {
                 return EmptyIterator.<K>emptyIterator();
             }
             return new KeySetIterator<>(parent);
@@ -1084,7 +1084,7 @@ public class Flat3Map<K, V> implements IterableMap<K, V>, Serializable, Cloneabl
             if (parent.delegateMap != null) {
                 return parent.delegateMap.values().iterator();
             }
-            if (parent.size() == 0) {
+            if (parent.isEmpty()) {
                 return EmptyIterator.<V>emptyIterator();
             }
             return new ValuesIterator<>(parent);
diff --git a/src/main/java/org/apache/commons/collections4/map/ListOrderedMap.java b/src/main/java/org/apache/commons/collections4/map/ListOrderedMap.java
index 13234c5..9417b8d 100644
--- a/src/main/java/org/apache/commons/collections4/map/ListOrderedMap.java
+++ b/src/main/java/org/apache/commons/collections4/map/ListOrderedMap.java
@@ -171,7 +171,7 @@ public class ListOrderedMap<K, V>
      */
     @Override
     public K firstKey() {
-        if (size() == 0) {
+        if (isEmpty()) {
             throw new NoSuchElementException("Map is empty");
         }
         return insertOrder.get(0);
@@ -185,7 +185,7 @@ public class ListOrderedMap<K, V>
      */
     @Override
     public K lastKey() {
-        if (size() == 0) {
+        if (isEmpty()) {
             throw new NoSuchElementException("Map is empty");
         }
         return insertOrder.get(size() - 1);
diff --git a/src/main/java/org/apache/commons/collections4/map/MultiValueMap.java b/src/main/java/org/apache/commons/collections4/map/MultiValueMap.java
index 2a22186..42b242c 100644
--- a/src/main/java/org/apache/commons/collections4/map/MultiValueMap.java
+++ b/src/main/java/org/apache/commons/collections4/map/MultiValueMap.java
@@ -383,7 +383,7 @@ public class MultiValueMap<K, V> extends AbstractMapDecorator<K, Object> impleme
      * @return true if this map changed
      */
     public boolean putAll(final K key, final Collection<V> values) {
-        if (values == null || values.size() == 0) {
+        if (values == null || values.isEmpty()) {
             return false;
         }
         boolean result = false;
diff --git a/src/main/java/org/apache/commons/collections4/map/StaticBucketMap.java b/src/main/java/org/apache/commons/collections4/map/StaticBucketMap.java
index 8a2c51c..53e29b3 100644
--- a/src/main/java/org/apache/commons/collections4/map/StaticBucketMap.java
+++ b/src/main/java/org/apache/commons/collections4/map/StaticBucketMap.java
@@ -192,7 +192,7 @@ public final class StaticBucketMap<K, V> extends AbstractIterableMap<K, V> {
      */
     @Override
     public boolean isEmpty() {
-        return (size() == 0);
+        return size() == 0;
     }
 
     /**
diff --git a/src/main/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMap.java b/src/main/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMap.java
index 9bdaa19..1ea509a 100644
--- a/src/main/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMap.java
+++ b/src/main/java/org/apache/commons/collections4/multimap/AbstractMultiValuedMap.java
@@ -354,7 +354,7 @@ public abstract class AbstractMultiValuedMap<K, V> implements MultiValuedMap<K,
 
     @Override
     public MapIterator<K, V> mapIterator() {
-        if (size() == 0) {
+        if (isEmpty()) {
             return EmptyMapIterator.emptyMapIterator();
         }
         return new MultiValuedMapIterator();
diff --git a/src/main/java/org/apache/commons/collections4/trie/AbstractPatriciaTrie.java b/src/main/java/org/apache/commons/collections4/trie/AbstractPatriciaTrie.java
index c66541d..f051243 100644
--- a/src/main/java/org/apache/commons/collections4/trie/AbstractPatriciaTrie.java
+++ b/src/main/java/org/apache/commons/collections4/trie/AbstractPatriciaTrie.java
@@ -772,7 +772,7 @@ abstract class AbstractPatriciaTrie<K, V> extends AbstractBitwiseTrie<K, V> {
 
     @Override
     public K firstKey() {
-        if (size() == 0) {
+        if (isEmpty()) {
             throw new NoSuchElementException();
         }
         return firstEntry().getKey();
diff --git a/src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java b/src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java
index 114ce95..5215549 100644
--- a/src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java
+++ b/src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java
@@ -332,7 +332,7 @@ public class CollectionUtilsTest extends MockTestCase {
         assertTrue(collection.size() == collectionA.size());
         assertTrue(collection.contains(2L) && !collection.contains(1));
         collection = CollectionUtils.collect((Iterator<Integer>) null, (Transformer<Integer, Number>) null);
-        assertTrue(collection.size() == 0);
+        assertTrue(collection.isEmpty());
 
         final int size = collectionA.size();
         collectionB = CollectionUtils.collect((Collection<Integer>) null, transformer, collectionB);
diff --git a/src/test/java/org/apache/commons/collections4/iterators/IteratorChainTest.java b/src/test/java/org/apache/commons/collections4/iterators/IteratorChainTest.java
index e3d8e32..9c45e33 100644
--- a/src/test/java/org/apache/commons/collections4/iterators/IteratorChainTest.java
+++ b/src/test/java/org/apache/commons/collections4/iterators/IteratorChainTest.java
@@ -134,9 +134,9 @@ public class IteratorChainTest extends AbstractIteratorTest<String> {
             }
         }
 
-        assertTrue("List is empty", list1.size() == 0);
+        assertTrue("List is empty", list1.isEmpty());
         assertTrue("List is empty", list2.size() == 1);
-        assertTrue("List is empty", list3.size() == 0);
+        assertTrue("List is empty", list3.isEmpty());
     }
 
     public void testFirstIteratorIsEmptyBug() {
diff --git a/src/test/java/org/apache/commons/collections4/iterators/LazyIteratorChainTest.java b/src/test/java/org/apache/commons/collections4/iterators/LazyIteratorChainTest.java
index 3827c41..33b9398 100644
--- a/src/test/java/org/apache/commons/collections4/iterators/LazyIteratorChainTest.java
+++ b/src/test/java/org/apache/commons/collections4/iterators/LazyIteratorChainTest.java
@@ -148,9 +148,9 @@ public class LazyIteratorChainTest extends AbstractIteratorTest<String> {
             }
         }
 
-        assertTrue("List is empty", list1.size() == 0);
+        assertTrue("List is empty", list1.isEmpty());
         assertTrue("List is empty", list2.size() == 1);
-        assertTrue("List is empty", list3.size() == 0);
+        assertTrue("List is empty", list3.isEmpty());
     }
 
     public void testFirstIteratorIsEmptyBug() {
diff --git a/src/test/java/org/apache/commons/collections4/map/AbstractMapTest.java b/src/test/java/org/apache/commons/collections4/map/AbstractMapTest.java
index 95280dc..d24936c 100644
--- a/src/test/java/org/apache/commons/collections4/map/AbstractMapTest.java
+++ b/src/test/java/org/apache/commons/collections4/map/AbstractMapTest.java
@@ -1036,8 +1036,8 @@ public abstract class AbstractMapTest<K, V> extends AbstractObjectTest {
         assertTrue(getMap().size() > 0);
         assertTrue(values.size() > 0);
         values.clear();
-        assertTrue(getMap().size() == 0);
-        assertTrue(values.size() == 0);
+        assertTrue(getMap().isEmpty());
+        assertTrue(values.isEmpty());
 
         // clear map, reflected in values
         resetFull();
@@ -1045,8 +1045,8 @@ public abstract class AbstractMapTest<K, V> extends AbstractObjectTest {
         assertTrue(getMap().size() > 0);
         assertTrue(values.size() > 0);
         getMap().clear();
-        assertTrue(getMap().size() == 0);
-        assertTrue(values.size() == 0);
+        assertTrue(getMap().isEmpty());
+        assertTrue(values.isEmpty());
     }
 
     /**
@@ -1064,8 +1064,8 @@ public abstract class AbstractMapTest<K, V> extends AbstractObjectTest {
         assertTrue(getMap().size() > 0);
         assertTrue(keySet.size() > 0);
         keySet.clear();
-        assertTrue(getMap().size() == 0);
-        assertTrue(keySet.size() == 0);
+        assertTrue(getMap().isEmpty());
+        assertTrue(keySet.isEmpty());
 
         // clear map, reflected in values
         resetFull();
@@ -1073,8 +1073,8 @@ public abstract class AbstractMapTest<K, V> extends AbstractObjectTest {
         assertTrue(getMap().size() > 0);
         assertTrue(keySet.size() > 0);
         getMap().clear();
-        assertTrue(getMap().size() == 0);
-        assertTrue(keySet.size() == 0);
+        assertTrue(getMap().isEmpty());
+        assertTrue(keySet.isEmpty());
     }
 
     /**
@@ -1092,8 +1092,8 @@ public abstract class AbstractMapTest<K, V> extends AbstractObjectTest {
         assertTrue(getMap().size() > 0);
         assertTrue(entrySet.size() > 0);
         entrySet.clear();
-        assertTrue(getMap().size() == 0);
-        assertTrue(entrySet.size() == 0);
+        assertTrue(getMap().isEmpty());
+        assertTrue(entrySet.isEmpty());
 
         // clear map, reflected in values
         resetFull();
@@ -1101,8 +1101,8 @@ public abstract class AbstractMapTest<K, V> extends AbstractObjectTest {
         assertTrue(getMap().size() > 0);
         assertTrue(entrySet.size() > 0);
         getMap().clear();
-        assertTrue(getMap().size() == 0);
-        assertTrue(entrySet.size() == 0);
+        assertTrue(getMap().isEmpty());
+        assertTrue(entrySet.isEmpty());
     }
 
     //-----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/collections4/multiset/AbstractMultiSetTest.java b/src/test/java/org/apache/commons/collections4/multiset/AbstractMultiSetTest.java
index 3e4a490..ac0dcb1 100644
--- a/src/test/java/org/apache/commons/collections4/multiset/AbstractMultiSetTest.java
+++ b/src/test/java/org/apache/commons/collections4/multiset/AbstractMultiSetTest.java
@@ -696,7 +696,7 @@ public abstract class AbstractMultiSetTest<T> extends AbstractCollectionTest<T>
         final MultiSet<T> multiset = makeObject();
         if (multiset instanceof Serializable && !skipSerializedCanonicalTests() && isTestSerialization()) {
             final MultiSet<?> multiset2 = (MultiSet<?>) readExternalFormFromDisk(getCanonicalEmptyCollectionName(multiset));
-            assertTrue("MultiSet is empty", multiset2.size() == 0);
+            assertTrue("MultiSet is empty", multiset2.isEmpty());
             assertEquals(multiset, multiset2);
         }
     }
diff --git a/src/test/java/org/apache/commons/collections4/splitmap/TransformedSplitMapTest.java b/src/test/java/org/apache/commons/collections4/splitmap/TransformedSplitMapTest.java
index 45416a3..8059a9f 100644
--- a/src/test/java/org/apache/commons/collections4/splitmap/TransformedSplitMapTest.java
+++ b/src/test/java/org/apache/commons/collections4/splitmap/TransformedSplitMapTest.java
@@ -118,7 +118,7 @@ public class TransformedSplitMapTest extends BulkTest {
         in.close();
 
         final TransformedSplitMap<?, ?, ?, ?> readMap = (TransformedSplitMap<?, ?, ?, ?>) readObject;
-        assertTrue( "Map should be empty", readMap.size() == 0 );
+        assertTrue( "Map should be empty", readMap.isEmpty() );
         assertEquals( map.entrySet(), readMap.entrySet() );
     }
 
@@ -138,7 +138,7 @@ public class TransformedSplitMapTest extends BulkTest {
         in.close();
 
         final TransformedSplitMap<?, ?, ?, ?> readMap = (TransformedSplitMap<?, ?, ?, ?>) readObject;
-        assertFalse( "Map should not be empty", readMap.size() == 0 );
+        assertFalse( "Map should not be empty", readMap.isEmpty() );
         assertEquals( map.entrySet(), readMap.entrySet() );
     }