You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/27 19:45:51 UTC

[GitHub] [spark] chia7712 opened a new pull request #35033: SPARK-37754 the version of black in reformat-python is inconsistent t…

chia7712 opened a new pull request #35033:
URL: https://github.com/apache/spark/pull/35033


   ### What changes were proposed in this pull request?
   
   Make version of `black` in `reformat-python` be consistent to `build_and_test.yml`
   
   
   ### Why are the changes needed?
   
   If we install the old version of black recommended by `reformat-python`, it produces style error happening on `python/pyspark/shuffle.py`
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   
   ### How was this patch tested?
   
   This patch only changes the error message


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] chia7712 commented on pull request #35033: [SPARK-37754][PYTHON] Fix black version in dev/reformat-python

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #35033:
URL: https://github.com/apache/spark/pull/35033#issuecomment-1001766228


   > Could you please adjust the title to match the format we use, i.e. [SPARK-37754][PYTHON] Fix black version in dev/reformat-python?
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 edited a comment on pull request #35033: SPARK-37754 the version of black in reformat-python is inconsistent t…

Posted by GitBox <gi...@apache.org>.
zero323 edited a comment on pull request #35033:
URL: https://github.com/apache/spark/pull/35033#issuecomment-1001726926






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on pull request #35033: SPARK-37754 the version of black in reformat-python is inconsistent t…

Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #35033:
URL: https://github.com/apache/spark/pull/35033#issuecomment-1001726926


   Could you please adjust the title to match the format we use, i.e. `[SPARK-37754][PYTHON] ...`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on pull request #35033: [SPARK-37754][PYTHON] Fix black version in dev/reformat-python

Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #35033:
URL: https://github.com/apache/spark/pull/35033#issuecomment-1001975163


   Merged into master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 closed pull request #35033: [SPARK-37754][PYTHON] Fix black version in dev/reformat-python

Posted by GitBox <gi...@apache.org>.
zero323 closed pull request #35033:
URL: https://github.com/apache/spark/pull/35033


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 edited a comment on pull request #35033: SPARK-37754 the version of black in reformat-python is inconsistent t…

Posted by GitBox <gi...@apache.org>.
zero323 edited a comment on pull request #35033:
URL: https://github.com/apache/spark/pull/35033#issuecomment-1001726926


   Could you please adjust the title to match the format we use, i.e. `[SPARK-37754][PYTHON] Fix black version in dev/reformat-python`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #35033: SPARK-37754 the version of black in reformat-python is inconsistent t…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35033:
URL: https://github.com/apache/spark/pull/35033#issuecomment-1001725750


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] chia7712 commented on pull request #35033: [SPARK-37754][PYTHON] Fix black version in dev/reformat-python

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #35033:
URL: https://github.com/apache/spark/pull/35033#issuecomment-1001888449


   > let's fix as @zero323 suggested.
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on pull request #35033: [SPARK-37754][PYTHON] Fix black version in dev/reformat-python

Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #35033:
URL: https://github.com/apache/spark/pull/35033#issuecomment-1001769466


   Maybe, we should  also set Black version explicitly in `dev/pyproject.toml`
   
   ```patch
   diff --git a/dev/pyproject.toml b/dev/pyproject.toml
   index b90257fc03..0ad817988e 100644
   --- a/dev/pyproject.toml
   +++ b/dev/pyproject.toml
   @@ -25,6 +25,9 @@ testpaths = [
    ]
    
    [tool.black]
   +# When changing the version, we have to update
   +# GitHub workflow version and dev/reformat-python
   +required-version = "21.12b0"
    line-length = 100
    target-version = ['py37']
    include = '\.pyi?$'
   ```
   
   @HyukjinKwon  WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #35033: [SPARK-37754][PYTHON] Fix black version in dev/reformat-python

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35033:
URL: https://github.com/apache/spark/pull/35033#issuecomment-1001823673


   @chia7712 let's fix as @zero323 suggested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org