You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/21 07:47:31 UTC

[GitHub] [arrow-datafusion] msathis commented on a change in pull request #578: in ballista also check for UI prettier changes

msathis commented on a change in pull request #578:
URL: https://github.com/apache/arrow-datafusion/pull/578#discussion_r655149026



##########
File path: .github/workflows/dev.yml
##########
@@ -50,3 +50,10 @@ jobs:
           # if you encounter error, try rerun the command below with --write instead of --check
           # and commit the changes
           npx prettier@2.3.0 --check {ballista,datafusion,datafusion-examples,dev,docs,python}/**/*.md README.md DEVELOPERS.md
+      - name: Prettier check for Ballista UI
+        run: |
+          cd ballista/ui/scheduler
+          npx yarn
+          # if you encounter error, try rerun the command below with --write instead of --check
+          # and commit the changes
+          npx yarn prettier --check **/*.{ts,tsx}

Review comment:
       @Jimexist We should include css also?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org