[GitHub] [activemq-artemis] jbertram commented on pull request #3853: ARTEMIS-3574 multiple bindings for embedded webserver

[GitBox <gi...@apache.org>]

jbertram commented on pull request #3853:
URL: https://github.com/apache/activemq-artemis/pull/3853#issuecomment-969131667


   In general I like this idea since the underlying Jetty server supports this kind of behavior natively. I was concerned at first that supporting this would require creating two instances of Jetty, but that is not the case. This is good work, @MM53!
   
   The problem is that there is no backwards compatibility with the previous configuration. Using the previous configuration results in an NPE, i.e.:
   ```
   java.lang.NullPointerException
           at org.apache.activemq.artemis.dto.WebServerDTO.getBindings(WebServerDTO.java:96)
           at org.apache.activemq.artemis.component.WebServerComponent.configure(WebServerComponent.java:87)
           at org.apache.activemq.artemis.cli.commands.Run.execute(Run.java:125)
           at org.apache.activemq.artemis.cli.Artemis.internalExecute(Artemis.java:157)
           at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:105)
           at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:132)
           at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
           at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
           at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
           at java.base/java.lang.reflect.Method.invoke(Method.java:566)
           at org.apache.activemq.artemis.boot.Artemis.execute(Artemis.java:134)
           at org.apache.activemq.artemis.boot.Artemis.main(Artemis.java:50)
   ```
   This is a *breaking* change and we cannot introduce it in a minor release. It would need to wait until the next major release.
   
   Alternatively you could provide backwards compatibility and then I think this could be merged and used in the next minor release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org