You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Li Jing Qin (JIRA)" <ji...@apache.org> on 2009/07/07 09:22:14 UTC
[jira] Created: (HARMONY-6259) [classlib][luni]
PipedInputStream.read throw different info when IOException is raised
[classlib][luni] PipedInputStream.read throw different info when IOException is raised
--------------------------------------------------------------------------------------
Key: HARMONY-6259
URL: https://issues.apache.org/jira/browse/HARMONY-6259
Project: Harmony
Issue Type: Bug
Reporter: Li Jing Qin
When the write end is closed unexpectedly, RI returns "Write end dead". Harmony do not differentiate the "Pipe is broken" and "Write end dead"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6259) [classlib][luni]
PipedInputStream.read throw different info when IOException is raised
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison updated HARMONY-6259:
---------------------------------
Fix Version/s: 5.0M11
> [classlib][luni] PipedInputStream.read throw different info when IOException is raised
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-6259
> URL: https://issues.apache.org/jira/browse/HARMONY-6259
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Li Jing Qin
> Assignee: Tim Ellison
> Fix For: 5.0M11
>
> Attachments: HARMONY-6259.diff, HARMONY-6259.v2.diff
>
>
> When the write end is closed unexpectedly, RI returns "Write end dead". Harmony do not differentiate the "Pipe is broken" and "Write end dead"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-6259) [classlib][luni]
PipedInputStream.read throw different info when IOException is raised
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison reassigned HARMONY-6259:
------------------------------------
Assignee: Tim Ellison
> [classlib][luni] PipedInputStream.read throw different info when IOException is raised
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-6259
> URL: https://issues.apache.org/jira/browse/HARMONY-6259
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Li Jing Qin
> Assignee: Tim Ellison
> Attachments: HARMONY-6259.diff, HARMONY-6259.v2.diff
>
>
> When the write end is closed unexpectedly, RI returns "Write end dead". Harmony do not differentiate the "Pipe is broken" and "Write end dead"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6259) [classlib][luni]
PipedInputStream.read throw different info when IOException is raised
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730662#action_12730662 ]
Li Jing Qin commented on HARMONY-6259:
--------------------------------------
It does not make a huge difference. But ant (i am investigating on it these
days) treat "Write end dead" differently. It will log the the "Write end
dead" and eat the Exception.
It is absolutely a non-big difference with RI. But it will fail the ant
redirector task. HARMONY-6260 also in the same situation.
--
Yours sincerely,
Charles Lee
> [classlib][luni] PipedInputStream.read throw different info when IOException is raised
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-6259
> URL: https://issues.apache.org/jira/browse/HARMONY-6259
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Li Jing Qin
> Assignee: Tim Ellison
> Fix For: 5.0M11
>
> Attachments: HARMONY-6259.diff, HARMONY-6259.v2.diff
>
>
> When the write end is closed unexpectedly, RI returns "Write end dead". Harmony do not differentiate the "Pipe is broken" and "Write end dead"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6259) [classlib][luni]
PipedInputStream.read throw different info when IOException is raised
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Jing Qin updated HARMONY-6259:
---------------------------------
Attachment: HARMONY-6259.diff
Would anyone try this?
> [classlib][luni] PipedInputStream.read throw different info when IOException is raised
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-6259
> URL: https://issues.apache.org/jira/browse/HARMONY-6259
> Project: Harmony
> Issue Type: Bug
> Reporter: Li Jing Qin
> Attachments: HARMONY-6259.diff
>
>
> When the write end is closed unexpectedly, RI returns "Write end dead". Harmony do not differentiate the "Pipe is broken" and "Write end dead"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6259) [classlib][luni]
PipedInputStream.read throw different info when IOException is raised
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730656#action_12730656 ]
Li Jing Qin commented on HARMONY-6259:
--------------------------------------
Thanks Tim.
!isClosed check is not redundant, the reason is:
1. PipedInputStream and PipedOutputStream are often on the different thread
2. isConnected is set to true by the PipedOutputStream.connect() and will
never set back to false. (At first this seems odd to me. That means input
stream can connect to output stream only once. I have tested on the RI and
it is correct unfortunately)
3. When PipedOutputStream close, it only change isClose to false
Since HARMONY-6259 and HARMONY-6260 are fixes on the same file, should I put
them together, create a new diff?
--
Yours sincerely,
Charles Lee
> [classlib][luni] PipedInputStream.read throw different info when IOException is raised
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-6259
> URL: https://issues.apache.org/jira/browse/HARMONY-6259
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Li Jing Qin
> Assignee: Tim Ellison
> Fix For: 5.0M11
>
> Attachments: HARMONY-6259.diff, HARMONY-6259.v2.diff
>
>
> When the write end is closed unexpectedly, RI returns "Write end dead". Harmony do not differentiate the "Pipe is broken" and "Write end dead"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6259) [classlib][luni]
PipedInputStream.read throw different info when IOException is raised
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Jing Qin updated HARMONY-6259:
---------------------------------
Attachment: HARMONY-6259.v2.diff
Using the isClosed instead of closeByWriter.
> [classlib][luni] PipedInputStream.read throw different info when IOException is raised
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-6259
> URL: https://issues.apache.org/jira/browse/HARMONY-6259
> Project: Harmony
> Issue Type: Bug
> Reporter: Li Jing Qin
> Attachments: HARMONY-6259.diff, HARMONY-6259.v2.diff
>
>
> When the write end is closed unexpectedly, RI returns "Write end dead". Harmony do not differentiate the "Pipe is broken" and "Write end dead"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-6259) [classlib][luni]
PipedInputStream.read throw different info when IOException is raised
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison resolved HARMONY-6259.
----------------------------------
Resolution: Fixed
Thanks Li Jing,
Not sure that it makes a huge difference, since they are messages in an IOException that people should not be dependent upon.
However, I applied the patch to the LUNI module at repo revision r793606 with a minor modification. i think the !isClosed check is redundant since the previous check has established that already.
Please verify this fixes the issue for you.
> [classlib][luni] PipedInputStream.read throw different info when IOException is raised
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-6259
> URL: https://issues.apache.org/jira/browse/HARMONY-6259
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Li Jing Qin
> Assignee: Tim Ellison
> Attachments: HARMONY-6259.diff, HARMONY-6259.v2.diff
>
>
> When the write end is closed unexpectedly, RI returns "Write end dead". Harmony do not differentiate the "Pipe is broken" and "Write end dead"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6259) [classlib][luni]
PipedInputStream.read throw different info when IOException is raised
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov updated HARMONY-6259:
-------------------------------------
Component/s: Classlib
> [classlib][luni] PipedInputStream.read throw different info when IOException is raised
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-6259
> URL: https://issues.apache.org/jira/browse/HARMONY-6259
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Li Jing Qin
> Attachments: HARMONY-6259.diff, HARMONY-6259.v2.diff
>
>
> When the write end is closed unexpectedly, RI returns "Write end dead". Harmony do not differentiate the "Pipe is broken" and "Write end dead"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.