You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/01/26 22:17:21 UTC

[GitHub] eolivelli commented on a change in pull request #1065: ISSUE #1049: Add PERMITTED_STARTUP_USERS to limit bookie startup users

eolivelli commented on a change in pull request #1065: ISSUE #1049: Add PERMITTED_STARTUP_USERS to limit bookie startup users
URL: https://github.com/apache/bookkeeper/pull/1065#discussion_r164235500
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
 ##########
 @@ -118,6 +120,20 @@ protected AbstractConfiguration() {
         }
     }
 
+    /**
+     * Limit who can start the application to prevent future permission errors.
+     */
+    public void setPermittedStartupUsers(String s) {
+        setProperty(PERMITTED_STARTUP_USERS, s);
+    }
+
+    /**
+     * Get array of users specified in this property.
+     */
+    public String[] getPermittedStartupUsers() {
 
 Review comment:
   Can't we have consistent return type, in regards to the setter?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services