You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Mohit Sabharwal (JIRA)" <ji...@apache.org> on 2015/06/17 02:20:00 UTC
[jira] [Commented] (PIG-4604) Clean up: refactor the package import
order in the files under
pig/src/org/apache/pig/backend/hadoop/executionengine/spark according to
certain rule
[ https://issues.apache.org/jira/browse/PIG-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589075#comment-14589075 ]
Mohit Sabharwal commented on PIG-4604:
--------------------------------------
LGTM. +1 (non-binding)
> Clean up: refactor the package import order in the files under pig/src/org/apache/pig/backend/hadoop/executionengine/spark according to certain rule
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-4604
> URL: https://issues.apache.org/jira/browse/PIG-4604
> Project: Pig
> Issue Type: Sub-task
> Components: spark
> Reporter: liyunzhang_intel
> Assignee: liyunzhang_intel
> Fix For: spark-branch
>
> Attachments: IntelliJ_Java_codeStyle_Imports1.png, IntelliJ_Java_codeStyle_Imports2.png, PIG-4604.patch
>
>
> after discussion with [~mohitsabharwal],[~xuefuz],[~praveenr019], [~kexianda]:
> now we use following rule about the package import order in files under pig/src/org/apache/pig/backend/hadoop/executionengine/spark:
> 1. java.* and javax.*
> 2. blank line
> 3. scala.*
> 4. blank line
> 5. Project classes (org.apache.*)
> 6. blank line
> 7. Third party libraries (org.*, com.*, etc.)
> If you use IntelliJ as your IDE, you can reference the attachment to configure your import layout of your java code style:
> 1. Use IntelliJ
> 2. Select “File”->”Settings”->”Code Style”->”Java”->”Imports”->”Import
> Layout”
> Now the files under pig/src/org/apache/pig/backend/hadoop/executionengine/spark has different package import order. They should be in the same order.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)