You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/23 17:42:15 UTC

[GitHub] [arrow] zeroshade commented on a diff in pull request #14179: ARROW-17515: [C++][Archery] JSON integration testing with RLE

zeroshade commented on code in PR #14179:
URL: https://github.com/apache/arrow/pull/14179#discussion_r978930675


##########
cpp/src/arrow/ipc/writer.cc:
##########
@@ -526,6 +526,14 @@ class RecordBatchSerializer {
     return VisitType(*array.indices());
   }
 
+  Status Visit(const RunLengthEncodedArray& array) {
+    --max_recursion_depth_;
+    RETURN_NOT_OK(VisitArray(*array.run_ends_array()));
+    RETURN_NOT_OK(VisitArray(*array.values_array()));
+    ++max_recursion_depth_;
+    return Status::OK();
+  }

Review Comment:
   How are we handling the logical offset with the IPC?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org