You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by po...@apache.org on 2021/08/16 20:12:39 UTC

[airflow] branch v2-1-test updated (da79226 -> 102ad7d)

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a change to branch v2-1-test
in repository https://gitbox.apache.org/repos/asf/airflow.git.


 discard da79226  Forces rebuilding the image for cache pushing
     new 102ad7d  Forces rebuilding the image for cache pushing

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (da79226)
            \
             N -- N -- N   refs/heads/v2-1-test (102ad7d)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:

[airflow] 01/01: Forces rebuilding the image for cache pushing

Posted by po...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a commit to branch v2-1-test
in repository https://gitbox.apache.org/repos/asf/airflow.git

commit 102ad7d9c22b45b3de401e9816a3a839be29262c
Author: Jarek Potiuk <ja...@potiuk.com>
AuthorDate: Mon Aug 16 16:07:47 2021 +0200

    Forces rebuilding the image for cache pushing
    
    Fixes bug in pushing latest image to cache on "push/schedule".
    
    When the build is successful and passes all tests vi either
    `push' or 'schedule' events, we attempt to rebuild the image
    with latest constraints just pushed and push it as a fresh
    cache for Github Registry. This keeps the time to build image
    small without manually refreshing the cache, it also automatically
    checks if there is a new "python" base image available so that
    we can use it in the new cache.
    
    There was a bug that the image has not been FORCE_PULLED and
    rebuilt in this case - just latest images were used.
    
    This had so far no negative effects because due to test
    instability, latest main images pretty much never succeeded in
    all tests, so the images in `main` were refreshed manually
    periodically anyway. However for v2-1-test the scope of tests
    run is far smaller now (no Helm tests, no Provider tests)
    and they succeed mostly when they should.
    
    This PR fixes it so that the images are built properly and pushed.
    
    (cherry picked from commit 7162b32e2e72878eabfa73ad8e6ad849f537929e)
---
 .github/workflows/ci.yml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 0d65286..9f064c9 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -1145,10 +1145,18 @@ ${{ hashFiles('.pre-commit-config.yaml') }}"
     env:
       RUNS_ON: ${{ fromJson(needs.build-info.outputs.runsOn) }}
       PYTHON_MAJOR_MINOR_VERSION: ${{ matrix.python-version }}
+      # Rebuild images before push using the latest constraints (just pushed) without
+      # eager upgrade. Do not wait for images, but rebuild them, but always check if
+      # there is a new Python base image to pull and rebuild. This way, when latest python
+      # is not pushed, we will re-use the last cache to start from and when there is
+      # a new python image, we will rebuild it from scratch (same as during the "build-images.ci")
       GITHUB_REGISTRY_PULL_IMAGE_TAG: "latest"
       GITHUB_REGISTRY_PUSH_IMAGE_TAG: "latest"
       PUSH_PYTHON_BASE_IMAGE: "true"
+      FORCE_PULL_IMAGES: "true"
       CHECK_IF_BASE_PYTHON_IMAGE_UPDATED: "true"
+      GITHUB_REGISTRY_WAIT_FOR_IMAGE: "false"
+      UPGRADE_TO_NEWER_DEPENDENCIES: "false"
     steps:
       - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
         uses: actions/checkout@v2